Unverified Commit 6e1372ec authored by Joseph's avatar Joseph Committed by GitHub

fix: Add Chrome-ligthouse to htmlLimitedBots (#80656)

Co-authored-by: 's avatarJiachi Liu <inbox@huozhi.im>
parent b2f9fa45
// This regex contains the bots that we need to do a blocking render for and can't safely stream the response // This regex contains the bots that we need to do a blocking render for and can't safely stream the response
// due to how they parse the DOM. For example, they might explicitly check for metadata in the `head` tag, so we can't stream metadata tags after the `head` was sent. // due to how they parse the DOM. For example, they might explicitly check for metadata in the `head` tag, so we can't stream metadata tags after the `head` was sent.
export const HTML_LIMITED_BOT_UA_RE = export const HTML_LIMITED_BOT_UA_RE =
/Mediapartners-Google|Slurp|DuckDuckBot|baiduspider|yandex|sogou|bitlybot|tumblr|vkShare|quora link preview|redditbot|ia_archiver|Bingbot|BingPreview|applebot|facebookexternalhit|facebookcatalog|Twitterbot|LinkedInBot|Slackbot|Discordbot|WhatsApp|SkypeUriPreview|Yeti/i /Mediapartners-Google|Chrome-Lighthouse|Slurp|DuckDuckBot|baiduspider|yandex|sogou|bitlybot|tumblr|vkShare|quora link preview|redditbot|ia_archiver|Bingbot|BingPreview|applebot|facebookexternalhit|facebookcatalog|Twitterbot|LinkedInBot|Slackbot|Discordbot|WhatsApp|SkypeUriPreview|Yeti/i
...@@ -182,5 +182,20 @@ describe('app-dir - metadata-streaming', () => { ...@@ -182,5 +182,20 @@ describe('app-dir - metadata-streaming', () => {
expect($('title').length).toBe(1) expect($('title').length).toBe(1)
expect($('head title').text()).toBe('partial static page') expect($('head title').text()).toBe('partial static page')
}) })
it('should still render blocking metadata for Google speed insights bot (special case)', async () => {
const $ = await next.render$(
'/static/partial',
{},
{
headers: {
'user-agent':
'UA Mozilla/5.0 (Linux; Android 7.0; Moto G (4)) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4590.2 Mobile Safari/537.36 Chrome-Lighthouse',
},
}
)
expect($('title').length).toBe(1)
expect($('head title').text()).toBe('partial static page')
})
}) })
}) })
...@@ -11,7 +11,7 @@ describe('app-dir - metadata-streaming-config', () => { ...@@ -11,7 +11,7 @@ describe('app-dir - metadata-streaming-config', () => {
) )
expect(requiredServerFiles.config.htmlLimitedBots).toMatchInlineSnapshot( expect(requiredServerFiles.config.htmlLimitedBots).toMatchInlineSnapshot(
`"Mediapartners-Google|Slurp|DuckDuckBot|baiduspider|yandex|sogou|bitlybot|tumblr|vkShare|quora link preview|redditbot|ia_archiver|Bingbot|BingPreview|applebot|facebookexternalhit|facebookcatalog|Twitterbot|LinkedInBot|Slackbot|Discordbot|WhatsApp|SkypeUriPreview|Yeti"` `"Mediapartners-Google|Chrome-Lighthouse|Slurp|DuckDuckBot|baiduspider|yandex|sogou|bitlybot|tumblr|vkShare|quora link preview|redditbot|ia_archiver|Bingbot|BingPreview|applebot|facebookexternalhit|facebookcatalog|Twitterbot|LinkedInBot|Slackbot|Discordbot|WhatsApp|SkypeUriPreview|Yeti"`
) )
const prerenderManifest = JSON.parse( const prerenderManifest = JSON.parse(
...@@ -38,7 +38,7 @@ describe('app-dir - metadata-streaming-config', () => { ...@@ -38,7 +38,7 @@ describe('app-dir - metadata-streaming-config', () => {
"/ppr": { "/ppr": {
"key": "user-agent", "key": "user-agent",
"type": "header", "type": "header",
"value": "Mediapartners-Google|Slurp|DuckDuckBot|baiduspider|yandex|sogou|bitlybot|tumblr|vkShare|quora link preview|redditbot|ia_archiver|Bingbot|BingPreview|applebot|facebookexternalhit|facebookcatalog|Twitterbot|LinkedInBot|Slackbot|Discordbot|WhatsApp|SkypeUriPreview|Yeti", "value": "Mediapartners-Google|Chrome-Lighthouse|Slurp|DuckDuckBot|baiduspider|yandex|sogou|bitlybot|tumblr|vkShare|quora link preview|redditbot|ia_archiver|Bingbot|BingPreview|applebot|facebookexternalhit|facebookcatalog|Twitterbot|LinkedInBot|Slackbot|Discordbot|WhatsApp|SkypeUriPreview|Yeti",
}, },
} }
`) `)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment