Unverified Commit 71f9bda3 authored by Hendrik Liebau's avatar Hendrik Liebau Committed by GitHub

[ci] Fix Rspack/Turbopack test manifest generation (#88845)

The recent change to always run all tests without aborting on failure
(#88435) inadvertently broke manifest generation. Previously, test
output was emitted for all tests when `NEXT_TEST_CONTINUE_ON_ERROR` was
set, but that variable was removed. Now test output is only emitted for
failing tests, causing the manifest to lose all passing test entries.

This adds a new `NEXT_TEST_EMIT_ALL_OUTPUT` environment variable that
restores the full output behavior specifically for the manifest
generation workflows.
parent d5d76054
...@@ -94,6 +94,7 @@ jobs: ...@@ -94,6 +94,7 @@ jobs:
export NEXT_TEST_MODE=${{ export NEXT_TEST_MODE=${{
inputs.test_type == 'development' && 'dev' || 'start' inputs.test_type == 'development' && 'dev' || 'start'
}} }}
export NEXT_TEST_EMIT_ALL_OUTPUT=1
${{ inputs.run_before_test }} ${{ inputs.run_before_test }}
...@@ -129,6 +130,7 @@ jobs: ...@@ -129,6 +130,7 @@ jobs:
'TURBOPACK_DEV=1' || 'TURBOPACK_DEV=1' ||
'TURBOPACK_BUILD=1' 'TURBOPACK_BUILD=1'
}} }}
export NEXT_TEST_EMIT_ALL_OUTPUT=1
${{ inputs.run_before_test }} ${{ inputs.run_before_test }}
......
...@@ -695,8 +695,9 @@ ${ENDGROUP}`) ...@@ -695,8 +695,9 @@ ${ENDGROUP}`)
console.error(`${test.file} failed to pass within ${numRetries} retries`) console.error(`${test.file} failed to pass within ${numRetries} retries`)
} }
// Emit test output, parsed by the commenter webhook to notify about failing tests // Emit test output, parsed by the commenter webhook to notify about failing tests.
if (!passed && isTestJob) { // Also emit for all tests when NEXT_TEST_EMIT_ALL_OUTPUT is set (for manifest generation).
if ((!passed || process.env.NEXT_TEST_EMIT_ALL_OUTPUT) && isTestJob) {
try { try {
const testsOutput = await fsp.readFile( const testsOutput = await fsp.readFile(
`${test.file}${RESULTS_EXT}`, `${test.file}${RESULTS_EXT}`,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment