Unverified Commit 72e381c8 authored by JJ Kasper's avatar JJ Kasper Committed by GitHub

Fix tests exit race condition (#60757)

This ensures we don't allow a following exit condition to override a
previous as async work is done before the `process.exit` actually occurs
so a follow-up one could override the first giving a false negative.

Closes NEXT-1911
parent a2115666
...@@ -124,7 +124,15 @@ ${output} ...@@ -124,7 +124,15 @@ ${output}
} }
} }
let exiting = false
const cleanUpAndExit = async (code) => { const cleanUpAndExit = async (code) => {
if (exiting) {
return
}
exiting = true
console.log(`exiting with code ${code}`)
if (process.env.NEXT_TEST_STARTER) { if (process.env.NEXT_TEST_STARTER) {
await fsp.rm(process.env.NEXT_TEST_STARTER, { await fsp.rm(process.env.NEXT_TEST_STARTER, {
recursive: true, recursive: true,
...@@ -140,11 +148,7 @@ const cleanUpAndExit = async (code) => { ...@@ -140,11 +148,7 @@ const cleanUpAndExit = async (code) => {
if (process.env.CI) { if (process.env.CI) {
await maybeLogSummary() await maybeLogSummary()
} }
console.log(`exiting with code ${code}`) process.exit(code)
setTimeout(() => {
process.exit(code)
}, 1)
} }
const isMatchingPattern = (pattern, file) => { const isMatchingPattern = (pattern, file) => {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment