Unverified Commit 73c63ae5 authored by Niklas Mischkulnig's avatar Niklas Mischkulnig Committed by GitHub

[otel] Add more verbose-mode OTEL spans for App Router (#94894)

This adds two new spans:
- `AppRender.renderToNodeFizzStream`
- `AppRender.waitShellReady`


Using the example from https://github.com/switz/nextjs-tracing-repro




with NEXT_OTEL_VERBOSE:

<img width="1245" height="408" alt="Bildschirmfoto 2026-06-17 um 18 11
28"
src="https://github.com/user-attachments/assets/5bd92d99-fc25-4490-aa25-9f8d0caeaf75"
/>
parent 8b57e82a
...@@ -3833,12 +3833,16 @@ async function renderToStream( ...@@ -3833,12 +3833,16 @@ async function renderToStream(
formState, formState,
} }
const { stream: htmlStream, allReady } = await workUnitAsyncStorage.run( const { stream: htmlStream, allReady } = await getTracer().trace(
requestStore, AppRenderSpan.renderToNodeFizzStream,
renderToNodeFizzStream, () =>
appElement, workUnitAsyncStorage.run(
fizzOptions, requestStore,
{ waitForAllReady: generateStaticHTML } renderToNodeFizzStream,
appElement,
fizzOptions,
{ waitForAllReady: generateStaticHTML }
)
) )
// End the render span only after React completed rendering (including anything inside Suspense boundaries) // End the render span only after React completed rendering (including anything inside Suspense boundaries)
......
...@@ -589,7 +589,10 @@ export async function renderToNodeFizzStream( ...@@ -589,7 +589,10 @@ export async function renderToNodeFizzStream(
}) })
) )
await shellReady.promise await getTracer().trace(
AppRenderSpan.waitShellReady,
() => shellReady.promise
)
if (!deferPipe) { if (!deferPipe) {
await waitAtLeastOneReactRenderTask() await waitAtLeastOneReactRenderTask()
......
...@@ -87,6 +87,8 @@ enum AppRenderSpan { ...@@ -87,6 +87,8 @@ enum AppRenderSpan {
renderToReadableStream = 'AppRender.renderToReadableStream', renderToReadableStream = 'AppRender.renderToReadableStream',
getBodyResult = 'AppRender.getBodyResult', getBodyResult = 'AppRender.getBodyResult',
fetch = 'AppRender.fetch', fetch = 'AppRender.fetch',
waitShellReady = 'AppRender.waitShellReady',
renderToNodeFizzStream = 'AppRender.renderToNodeFizzStream',
} }
enum RouterSpan { enum RouterSpan {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment