Normalize pnpm store cache keys (#99957)
We didn't include OS and architecture in our pnpm cache keys, which could often cause us to have to redownload cached packages during install (e.g. cache populated on x86-64, but read on arm64). I asked codex about the naming disparity between these jobs: > this was historical drift, not two different store types. > > - [\#93508 (https://github.com/vercel/next.js/pull/93508)](<https://github.com/vercel/next.js/pull/93508>) introduced `pnpm-store-root-v1-*` on May 5. Jobs that skipped `pnpm install` had saved incomplete stores—about **14 MB instead of 440 MB**. The PR aligned the cache/install conditions and changed the key to invalidate those caches. “root” means a complete repository-root install. > - [\#93411 (https://github.com/vercel/next.js/pull/93411)](<https://github.com/vercel/next.js/pull/93411>) merged four days later, adding caching to `fetch-test-timings` with the old `pnpm-store-v2-*` key. Its comment intended to match the reusable workflow, but the key was already outdated. > > Both cache `pnpm store path` after a root install. Unifying them is appropriate; our branch now consistently uses `pnpm-store-root-v2-*`.
Showing
Please
register
or
sign in
to comment