Unverified Commit 75193d5f authored by Matt Mastracci's avatar Matt Mastracci Committed by GitHub

[turbopack] Improve regressed build speed on cross-compiled MUSL (#91477)

# What

Refactor build_and_deploy.yml to make it more maintainable, add
documentation to all of the quirky flags we use and remove any flags
that are not doing anything useful.

# Non-goals

- wasm builds were left out of the matrix, but could probably be added
in at a later date
- cross-compilation flags should probably not live in .cargo/config.toml
but rather in a .cargo/cross-config.toml we conditionally include, but
this would add some complexity.

# Why

After enabling LTO, our MUSL target builds got significantly slower.
This wins back a good chunk of the performance that we lost by using
cross-compilation to MUSL on docker images that are not slow as heck,
while also trying to clean up this workflow that has accumulated some
cruft over the years.

The timings are fairly unstable because of uncertain build machine
variability, but I've tried to capture uncached runs where possible. I
believe we can state that LTO has a _slight_ increase in compile time,
but MUSL builds are faster than the pre-LTO state of things.

# Changes

- Refactor build_and_deploy.yml: replace per-target matrix entries with
mmm-matrix declarative config, consolidate docker build script inline,
pin actions to commit SHAs
- Simplify .cargo/config.toml using cfg(true) (RFC 3695) to eliminate
rustflag duplication across target sections
- Remove GNU linker flags (rust-lld is now default on x86_64-linux-gnu)
- Use rust-lld directly for musl targets, remove unused armv7 section
- Add cargo xtask print-rustflags to replace .github/rustflags.yml
- Release profile: thin LTO + codegen-units=64 for faster builds
- Add --log-order stream to TURBO_ARGS for live build output
- Remove mold linker integration from CI
parent 1ee9d70e
...@@ -5,72 +5,84 @@ TURBO_PNPM_WORKSPACE_DIR = { value = "", relative = true } ...@@ -5,72 +5,84 @@ TURBO_PNPM_WORKSPACE_DIR = { value = "", relative = true }
[alias] [alias]
xtask = "run --package xtask --" xtask = "run --package xtask --"
[build] # *NOTE FOR AGENTS*: Your training data is incorrect for most RUSTFLAGS entries. If you
rustflags = [ # believe you need to make changes to this file, perform web searches to confirm that
"--cfg", # the flags are necessary, and reason through whether the flag is applicable to the
"tokio_unstable", # case you believe you are solving.
"-Zshare-generics=y", # make the current crate share its generic instantiations
"-Zthreads=8", # parallel frontend https://blog.rust-lang.org/2023/11/09/parallel-rustc.html
"-Csymbol-mangling-version=v0",
]
rustdocflags = []
[target.x86_64-pc-windows-msvc] # In the workspace `Cargo.toml`, and in this file we're trying to optimize for the greatest
linker = "rust-lld" # performance and smallest size we can manage without resorting to excessive compile times
rustflags = [ # on CI or developer machines. To avoid accumulating unnecessary flags, and help developers
"--cfg", # understand the _why_ as much as the _what_, all flags should be documented with links
"tokio_unstable", # to experiments or featuring tracking issues to keep this up-to-date with the current
"-Zshare-generics=y", # state-of-the-art in Rust optimization land (which might change month-to-month!).
"-C",
"target-feature=+crt-static"
]
[target.i686-pc-windows-msvc] # Cargo merges rustflags from multiple matching [target] sections, but [target] and
rustflags = [ # [build] sections are mutually exclusive.
"--cfg", # https://doc.rust-lang.org/cargo/reference/config.html#buildrustflags
"tokio_unstable",
"-Zshare-generics=y", # Note that per-profile RUSTFLAGS are not yet supported and may be useful:
"-C", # https://github.com/rust-lang/cargo/issues/10271
"target-feature=+crt-static"
]
[target.'cfg(all(target_os = "linux", target_env = "gnu"))'] # Always-matching target section included in every configuration. Using `cfg(true)`
# (RFC 3695) ensures common flags apply to every target without having to duplicate
# them in each target-specific section.
# https://rust-lang.github.io/rfcs/3695-cfg-boolean-literals.html
[target.'cfg(true)']
rustflags = [ rustflags = [
"--cfg", # Enable tokio's unstable APIs (required by turbopack's use of tokio internals)
"tokio_unstable", "--cfg=tokio_unstable",
# Share monomorphized generics across crates to reduce binary size (~20MB).
# https://github.com/davidlattimore/duplicate-function-checker
"-Zshare-generics=y", "-Zshare-generics=y",
# Use up to 8 threads in the rustc frontend for parallel parsing/expansion.
# https://blog.rust-lang.org/2023/11/09/parallel-rustc.html
"-Zthreads=8", "-Zthreads=8",
# Unlock nightly-only options
"-Zunstable-options", "-Zunstable-options",
"-Csymbol-mangling-version=v0", ]
# Windows: statically link the CRT and opt into rust-lld for fast linking.
# rust-lld is not yet the default on Windows (tracking: rust-lang/rust#71520).
[target.'cfg(windows)']
linker = "rust-lld"
rustflags = ["-Ctarget-feature=+crt-static"]
# Why `linker-flavor=gnu-lld-cc` instead of `linker = "rust-lld"`?
#
# `linker = "rust-lld"` invokes lld directly, bypassing the cc linker driver.
# This fails because lld alone can't find system libraries (-lgcc_s, -lc) and
# doesn't understand -Wl, prefixed args from crate build scripts.
# `gnu-lld-cc` + `link-self-contained=+linker` routes lld through cc, which
# resolves library paths and translates -Wl, args.
#
# On x86_64-unknown-linux-gnu, this is already the nightly default since
# Rust 1.90, so no explicit config is needed for GNU targets.
# Not yet default on aarch64-unknown-linux-gnu or any musl target.
# https://blog.rust-lang.org/2025/09/01/rust-lld-on-1.90.0-stable/
# Musl targets: disable static CRT linking (we produce dynamic .node shared
# libraries, not static binaries) and use rust-lld via the cc linker driver.
# Like GNU targets, `linker = "rust-lld"` doesn't work (can't find -lc, -lgcc_s,
# and doesn't understand -Wl, prefixed args).
[target.'cfg(all(target_os = "linux", target_env = "musl"))']
rustflags = [
"-Ctarget-feature=-crt-static",
"-Clinker-flavor=gnu-lld-cc", "-Clinker-flavor=gnu-lld-cc",
"-Clink-self-contained=+linker",
] ]
# aarch64-musl: cross-compiled from x86_64, so self-contained rust-lld won't
# work (it would resolve to the host sysroot). Instead, use the musl cross-
# compiler.
[target.aarch64-unknown-linux-musl] [target.aarch64-unknown-linux-musl]
linker = "aarch64-linux-musl-gcc" linker = "aarch64-linux-musl-gcc"
# Config need to be mirrowed to .github/workflows/build_and_deploy.yml
rustflags = [ rustflags = [
"--cfg", # Link libgcc (needed for unwinding support in musl cross-compilation)
"tokio_unstable",
"-Zshare-generics=y",
"-Csymbol-mangling-version=v0",
"-Ctarget-feature=-crt-static",
"-Clink-arg=-lgcc", "-Clink-arg=-lgcc",
] ]
[target.x86_64-unknown-linux-musl] # WASM: configure getrandom to use the wasm_js backend (Math.random / crypto).
# Config need to be mirrowed to .github/workflows/build_and_deploy.yml [target.wasm32-unknown-unknown]
rustflags = [ rustflags = [
"--cfg", "--cfg", "getrandom_backend=\"wasm_js\"",
"tokio_unstable",
"-Zshare-generics=y",
"-Zthreads=8",
"-Csymbol-mangling-version=v0",
"-Ctarget-feature=-crt-static",
] ]
[target.armv7-unknown-linux-gnueabihf]
linker = "arm-linux-gnueabihf-gcc"
[target.wasm32-unknown-unknown]
rustflags = ["-Zshare-generics=y", "--cfg", 'getrandom_backend="wasm_js"']
This diff is collapsed.
...@@ -192,7 +192,6 @@ jobs: ...@@ -192,7 +192,6 @@ jobs:
needsNextest: 'yes' needsNextest: 'yes'
skipNativeBuild: 'yes' skipNativeBuild: 'yes'
afterBuild: pnpm dlx turbo@${TURBO_VERSION} run test-cargo-unit --remote-cache-timeout 60 --log-order stream afterBuild: pnpm dlx turbo@${TURBO_VERSION} run test-cargo-unit --remote-cache-timeout 60 --log-order stream
mold: 'yes'
stepName: 'test-cargo-unit' stepName: 'test-cargo-unit'
secrets: inherit secrets: inherit
......
...@@ -7,12 +7,6 @@ on: ...@@ -7,12 +7,6 @@ on:
required: false required: false
description: 'additional steps to run' description: 'additional steps to run'
type: string type: string
# Toggles the mold linker. The default linker is much slower and can run into OOMs.
# However, custom linkers won't work for wasm.
mold:
required: false
description: 'whether to use the mold linker'
type: string
skipInstallBuild: skipInstallBuild:
required: false required: false
description: 'whether to skip pnpm install && pnpm build' description: 'whether to skip pnpm install && pnpm build'
...@@ -235,13 +229,6 @@ jobs: ...@@ -235,13 +229,6 @@ jobs:
uses: ./.github/actions/setup-rust uses: ./.github/actions/setup-rust
if: ${{ inputs.skipNativeBuild != 'yes' || inputs.needsNextest == 'yes' || inputs.needsRust == 'yes' }} if: ${{ inputs.skipNativeBuild != 'yes' || inputs.needsNextest == 'yes' || inputs.needsRust == 'yes' }}
- name: 'Install mold linker'
if: ${{ inputs.mold == 'yes' }}
run: |
sudo apt update
sudo apt install -y mold
echo RUSTFLAGS=${RUSTFLAGS}\ -C\ link-arg=-fuse-ld=mold >> $GITHUB_ENV
- name: Install nextest - name: Install nextest
if: ${{ inputs.needsNextest == 'yes' }} if: ${{ inputs.needsNextest == 'yes' }}
uses: taiki-e/install-action@nextest uses: taiki-e/install-action@nextest
......
...@@ -54,248 +54,106 @@ debug = true ...@@ -54,248 +54,106 @@ debug = true
[profile.release] [profile.release]
lto = "thin" lto = "thin"
# codegen-units=1 disables intra-crate parallelism so LLVM sees each crate as a
# single module, enabling better inlining and identical-function deduplication
# within each crate. Combined with share-generics (which avoids duplicating
# monomorphized generics across crates) and thin LTO (which deduplicates across
# crate boundaries), this minimizes overall function duplication in the binary.
#
# https://github.com/davidlattimore/duplicate-function-checker suggests that fat LTO +
# share-generics + codegen-units = 1 is the best way to reduce overall function
# duplication in the binary, and by extension, size. We only do thin LTO, but
# this _should_ have similar effect to fat LTO.
codegen-units = 1
[profile.release.package] # Use a custom profile for CI or local testing where we are somewhat performance
# sensitive but we still want the additional validation of debug-assertions.
[profile.release.package.turbopack-ecmascript] #
opt-level = 3 # This is not suitable for benchmarking, as debug assertions worsen performance
# and we disable LTO.
[profile.release.package.turbopack-core] [profile.release-with-assertions]
opt-level = 3 inherits = "release"
debug-assertions = true
[profile.release.package.next-core] overflow-checks = true
opt-level = 3 # Thin-LTO can make the binary ~5-10% faster, but it can make our build take a
# couple more minutes, so it's not worth it for most test scenarios.
[profile.release.package.lightningcss] lto = false
opt-level = "s" # More codegen units = faster compilation. Without LTO there's no cross-CGU
# optimization recovery, but this profile prioritizes build speed over perf.
[profile.release.package.lightningcss-napi] codegen-units = 64
opt-level = "s"
[profile.release.package.swc_ecma_ast]
opt-level = 3
[profile.release.package.next-api] [profile.release-with-debug]
opt-level = 3 inherits = "release"
debug = true
[profile.release.package.wasmer-wasix] # Size-optimized crates: determined via `cargo bloat --release --crates -p next-napi-bindings`.
# Wasmer/cranelift crates are used by the plugin feature (wasm builds).
[profile.release.package.browserslist-rs]
opt-level = "s" opt-level = "s"
[profile.release.package.cranelift-codegen] [profile.release.package.cranelift-codegen]
opt-level = "s" opt-level = "s"
[profile.release.package.turbo-tasks] [profile.release.package.handlebars]
opt-level = 3
[profile.release.package.turbopack-node]
opt-level = 3
[profile.release.package.turbopack-dev-server]
opt-level = 3
[profile.release.package.swc_ecma_minifier]
opt-level = 3
[profile.release.package.swc]
opt-level = 3
[profile.release.package.turbopack-css]
opt-level = 3
[profile.release.package.swc_ecma_compat_es2015]
opt-level = "s" opt-level = "s"
[profile.release.package.turbo-tasks-fs] [profile.release.package.lightningcss]
opt-level = 3
[profile.release.package.swc_ecma_parser]
opt-level = 3
[profile.release.package.turbopack]
opt-level = 3
[profile.release.package.turbopack-browser]
opt-level = 3
[profile.release.package.turbo-tasks-backend]
opt-level = 3
[profile.release.package.styled_jsx]
opt-level = "s" opt-level = "s"
[profile.release.package.next-custom-transforms] [profile.release.package.lightningcss-napi]
opt-level = 3
[profile.release.package.wast]
opt-level = "s" opt-level = "s"
[profile.release.package.wasmparser] [profile.release.package.markdown]
opt-level = "s" opt-level = "s"
[profile.release.package.browserslist-rs] [profile.release.package.mdxjs]
opt-level = "s" opt-level = "s"
[profile.release.package.tokio] [profile.release.package.regalloc2]
opt-level = 3
[profile.release.package.reqwest]
opt-level = "s" opt-level = "s"
[profile.release.package.swc_ecma_transforms_proposal] [profile.release.package.regex-syntax]
opt-level = "s" opt-level = "s"
[profile.release.package.turbopack-resolve] [profile.release.package.reqwest]
opt-level = 3
[profile.release.package.swc_ecma_transforms_optimization]
opt-level = 3
[profile.release.package.swc_ecma_transforms_base]
opt-level = 3
[profile.release.package.regex-automata]
opt-level = 3
[profile.release.package.auto-hash-map]
opt-level = 3
[profile.release.package.webc]
opt-level = "s" opt-level = "s"
[profile.release.package.turbopack-nodejs] [profile.release.package.styled_jsx]
opt-level = 3
[profile.release.package.turbopack-trace-server]
opt-level = 3
[profile.release.package.swc_ecma_transforms_module]
opt-level = "s" opt-level = "s"
[profile.release.package.swc_ecma_transforms_typescript]
opt-level = 3
[profile.release.package.swc_css_prefixer] [profile.release.package.swc_css_prefixer]
opt-level = "s" opt-level = "s"
[profile.release.package.zstd-sys]
opt-level = 3
[profile.release.package.swc_sourcemap]
opt-level = 3
[profile.release.package.turbopack-wasm]
opt-level = 3
[profile.release.package.turbopack-ecmascript-plugins]
opt-level = 3
[profile.release.package.handlebars]
opt-level = "s"
[profile.release.package.swc_ecma_compat_bugfixes] [profile.release.package.swc_ecma_compat_bugfixes]
opt-level = "s" opt-level = "s"
[profile.release.package.h2] [profile.release.package.swc_ecma_compat_es2015]
opt-level = "s" opt-level = "s"
[profile.release.package.swc_ecma_compat_es2022] [profile.release.package.swc_ecma_compat_es2022]
opt-level = "s" opt-level = "s"
[profile.release.package.wasmer-config]
opt-level = "s"
[profile.release.package.wasmer-compiler]
opt-level = "s"
[profile.release.package.swc_ecma_utils]
opt-level = 3
[profile.release.package.regex-syntax]
opt-level = "s"
[profile.release.package.turbopack-image]
opt-level = 3
[profile.release.package.turbo-tasks-env]
opt-level = 3
[profile.release.package.napi]
opt-level = 3
[profile.release.package.mdxjs]
opt-level = "s"
[profile.release.package.serde_json]
opt-level = 3
[profile.release.package.swc_plugin_runner]
opt-level = "s"
[profile.release.package.markdown]
opt-level = "s"
[profile.release.package.swc_ecma_preset_env] [profile.release.package.swc_ecma_preset_env]
opt-level = "s" opt-level = "s"
[profile.release.package.turbo-tasks-fetch] [profile.release.package.swc_ecma_transforms_module]
opt-level = 3
[profile.release.package.swc_ecma_visit]
opt-level = 3
[profile.release.package.turbopack-mdx]
opt-level = "s"
[profile.release.package.autocfg]
opt-level = "s"
[profile.release.package.image]
opt-level = 3
[profile.release.package.serde]
opt-level = 3
[profile.release.package.wasmer]
opt-level = "s"
[profile.release.package.wasmer-vm]
opt-level = "s"
[profile.release.package.wasmer-compiler-cranelift]
opt-level = "s" opt-level = "s"
[profile.release.package.regalloc2] [profile.release.package.swc_ecma_transforms_proposal]
opt-level = "s" opt-level = "s"
[profile.release.package.swc_plugin_backend_wasmer] [profile.release.package.swc_plugin_backend_wasmer]
opt-level = "s" opt-level = "s"
[profile.release.package.globset] [profile.release.package.swc_plugin_runner]
opt-level = "s" opt-level = "s"
[profile.release.package.toml_edit] [profile.release.package.wasmer]
opt-level = "s" opt-level = "s"
[profile.release.package.miette] [profile.release.package.wasmer-compiler]
opt-level = "s" opt-level = "s"
# Use a custom profile for CI or local testing where we are somewhat performance
# sensitive but we still want the additional validation of debug-assertions.
#
# This is not suitable for benchmarking, as debug assertions worsen performance
# and we disable LTO.
[profile.release-with-assertions]
inherits = "release"
debug-assertions = true
overflow-checks = true
# Thin-LTO can make the binary ~5-10% faster, but it can make our build take a
# couple more minutes, so it's not worth it for most test scenarios.
lto = false
[profile.release-with-debug]
inherits = "release"
debug = true
[workspace.dependencies] [workspace.dependencies]
# Workspace crates # Workspace crates
next-api = { path = "crates/next-api" } next-api = { path = "crates/next-api" }
......
...@@ -52,6 +52,15 @@ fn cli() -> Command { ...@@ -52,6 +52,15 @@ fn cli() -> Command {
) )
.arg(arg!(<PATH> "the path to the benchmark data directory")), .arg(arg!(<PATH> "the path to the benchmark data directory")),
) )
.subcommand(
Command::new("print-rustflags")
.about("Print the effective RUSTFLAGS for a given target triple")
.long_about(
"Uses cargo's own config resolution to determine the merged rustflags \
for a target. This replaces the need for a separate rustflags.yml file.",
)
.arg(arg!(--target <TARGET> "the target triple (e.g. x86_64-unknown-linux-gnu)").required(true)),
)
.subcommand( .subcommand(
Command::new("visualize-bundler-benchmarks") Command::new("visualize-bundler-benchmarks")
.about("Generate visualizations of bundler benchmarks") .about("Generate visualizations of bundler benchmarks")
...@@ -74,6 +83,130 @@ Visualizations generated by this command will appear in a sibling directory to t ...@@ -74,6 +83,130 @@ Visualizations generated by this command will appear in a sibling directory to t
) )
} }
/// Print the effective RUSTFLAGS for a given target using cargo's own config resolution.
///
/// Creates a temporary dummy crate and runs `cargo check --target <triple>` with a
/// RUSTC_WRAPPER that captures CARGO_ENCODED_RUSTFLAGS and aborts the build. This
/// ensures we get the exact same flag resolution cargo would use, including all
/// cfg()-based target matching.
fn print_rustflags(target: &str) -> Result<()> {
use std::io::Write;
let workspace_dir = var_os("CARGO_WORKSPACE_DIR")
.map(PathBuf::from)
.unwrap_or_else(|| current_dir().unwrap());
let tmp_dir = std::env::temp_dir().join("xtask-rustflags");
std::fs::create_dir_all(&tmp_dir)?;
// Create a minimal dummy crate so cargo has something to "compile"
let dummy_dir = tmp_dir.join("dummy");
let dummy_src = dummy_dir.join("src");
std::fs::create_dir_all(&dummy_src)?;
std::fs::write(
dummy_dir.join("Cargo.toml"),
"[package]\nname = \"dummy\"\nversion = \"0.0.0\"\nedition = \"2021\"\n",
)?;
std::fs::write(dummy_src.join("lib.rs"), "")?;
// Create a wrapper script that intercepts the rustc invocation.
// With RUSTC_WRAPPER, cargo passes flags as CLI args (not CARGO_ENCODED_RUSTFLAGS).
// The wrapper prints ALL args to stderr with a known prefix so we can extract
// the flags that cargo appended beyond rustc's own args.
//
// For -vV queries: forward directly to real rustc.
// For --print=* probes: forward to real rustc but strip rustflags (they're
// irrelevant for --print=file-names and can cause errors, e.g.
// -Clink-self-contained=+linker requires -Zunstable-options).
// For actual compilation: capture all args and abort.
let wrapper_path = tmp_dir.join("rustc-wrapper.sh");
let marker = "XTASK_ARGS:";
{
let mut f = std::fs::File::create(&wrapper_path)?;
write!(
f,
r#"#!/bin/sh
RUSTC="$1"; shift
# Check if this is a -vV or --print= query
IS_PROBE=0
IS_VV=0
for arg in "$@"; do
case "$arg" in
-vV) IS_VV=1 ;;
--print=*) IS_PROBE=1 ;;
esac
done
# Forward -vV directly
if [ "$IS_VV" = "1" ]; then
exec "$RUSTC" "$@"
fi
# For --print= probes, forward to real rustc but strip resolved rustflags.
# Cargo appends rustflags to probe commands which can cause errors (e.g.
# -Clink-self-contained=+linker requires -Zunstable-options). The rustflags
# are irrelevant for probes, so we strip -C/-Z/--cfg flags.
if [ "$IS_PROBE" = "1" ]; then
ARGS=""
for arg in "$@"; do
case "$arg" in
-C*|-Z*|--cfg|--cfg=*) continue ;;
esac
ARGS="$ARGS $arg"
done
exec $RUSTC $ARGS
fi
# Actual compilation: capture args and abort
printf '{marker}%s\n' "$*" >&2
exit 1
"#,
)?;
}
#[cfg(unix)]
{
use std::os::unix::fs::PermissionsExt;
std::fs::set_permissions(&wrapper_path, std::fs::Permissions::from_mode(0o755))?;
}
// Run cargo check from the workspace root (so .cargo/config.toml is found)
let output = process::Command::new("cargo")
.arg("check")
.arg("--target")
.arg(target)
.arg("--manifest-path")
.arg(dummy_dir.join("Cargo.toml"))
.env("RUSTC_WRAPPER", &wrapper_path)
.current_dir(&workspace_dir)
.stdout(process::Stdio::null())
.stderr(process::Stdio::piped())
.output()?;
let stderr = String::from_utf8_lossy(&output.stderr);
let args_line = stderr
.lines()
.find_map(|line| line.strip_prefix(marker))
.ok_or_else(|| {
anyhow::anyhow!("Failed to capture rustc args for target {target}.\nstderr: {stderr}")
})?;
// Extract rustflags from the args. Cargo appends resolved rustflags after its
// own generated args (which end with `-L dependency=<path>`). The `-L` and
// `dependency=...` are separate args. Rustflags start after the last `dependency=` arg.
let flags: Vec<&str> = args_line.split_whitespace().collect();
let last_dep_idx = flags
.iter()
.rposition(|a| a.starts_with("dependency="))
.unwrap_or(0);
let rustflags = &flags[last_dep_idx + 1..];
let flags = rustflags.join(" ");
let flags = flags.trim();
println!("{flags}");
// Clean up
let _ = std::fs::remove_dir_all(&tmp_dir);
Ok(())
}
fn main() -> Result<()> { fn main() -> Result<()> {
let matches = cli().get_matches(); let matches = cli().get_matches();
match matches.subcommand() { match matches.subcommand() {
...@@ -169,6 +302,12 @@ fn main() -> Result<()> { ...@@ -169,6 +302,12 @@ fn main() -> Result<()> {
summarize_bench::process_all(path); summarize_bench::process_all(path);
Ok(()) Ok(())
} }
Some(("print-rustflags", sub_matches)) => {
let target = sub_matches
.get_one::<String>("target")
.expect("TARGET is required");
print_rustflags(target)
}
Some(("visualize-bundler-benchmarks", sub_matches)) => { Some(("visualize-bundler-benchmarks", sub_matches)) => {
let path = sub_matches let path = sub_matches
.get_one::<String>("PATH_TO_SUMMARY_JSON") .get_one::<String>("PATH_TO_SUMMARY_JSON")
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment