Unverified Commit 7edc9548 authored by David Alexandru Ilie's avatar David Alexandru Ilie Committed by GitHub

Clarify Instant validation opt-outs

parent 7cb68c12
...@@ -218,12 +218,12 @@ const unrenderedSegmentCards: FixCard[] = [ ...@@ -218,12 +218,12 @@ const unrenderedSegmentCards: FixCard[] = [
}, },
{ {
id: 'skip-validation-on-the-segment', id: 'skip-validation-on-the-segment',
title: 'Skip validation on the segment', title: 'Skip only this validation',
group: 'ignore', group: 'ignore',
link: 'https://nextjs.org/docs/messages/instant-unrendered-segment#skip-validation-on-the-segment', link: 'https://nextjs.org/docs/messages/instant-unrendered-segment#skip-validation-on-the-segment',
snippets: [ snippets: [
{ text: '// page.tsx or layout.tsx' }, { text: '// Server page.tsx or layout.tsx' },
{ text: '' }, { text: '// Prerendering still runs' },
{ text: 'export const instant = false', highlight: true }, { text: 'export const instant = false', highlight: true },
], ],
copyable: true, copyable: true,
......
...@@ -423,9 +423,20 @@ describe('card sets for all error families', () => { ...@@ -423,9 +423,20 @@ describe('card sets for all error families', () => {
}) })
it('unrendered-segment', () => { it('unrendered-segment', () => {
expect( const cards = getCards('unrendered-segment', 'runtime')
getCards('unrendered-segment', 'runtime').map((card) => card.id)
).toEqual(['render-the-dropped-segment', 'skip-validation-on-the-segment']) expect(cards.map((card) => card.id)).toEqual([
'render-the-dropped-segment',
'skip-validation-on-the-segment',
])
expect(cards[1]).toMatchObject({
title: 'Skip only this validation',
snippets: [
{ text: '// Server page.tsx or layout.tsx' },
{ text: '// Prerendering still runs' },
{ text: 'export const instant = false', highlight: true },
],
})
}) })
it('link-prefetch-partial', () => { it('link-prefetch-partial', () => {
...@@ -517,7 +528,7 @@ describe('getUnrenderedSegmentErrorDetails', () => { ...@@ -517,7 +528,7 @@ describe('getUnrenderedSegmentErrorDetails', () => {
`\n\n${label}:\n${files.map((p) => ` ${p}`).join('\n')}` + `\n\n${label}:\n${files.map((p) => ` ${p}`).join('\n')}` +
`\n\nWays to fix this:` + `\n\nWays to fix this:` +
`\n - [render] Render the dropped segment` + `\n - [render] Render the dropped segment` +
`\n - [ignore] Set \`export const instant = false\` on the dropped segment to skip validation` + `\n - [ignore] Set \`export const instant = false\` in the dropped segment's Server Component to skip only this validation (prerendering still runs)` +
`\n\nLearn more: https://nextjs.org/docs/messages/instant-unrendered-segment` `\n\nLearn more: https://nextjs.org/docs/messages/instant-unrendered-segment`
} }
return new Error(message) return new Error(message)
......
...@@ -11,7 +11,7 @@ export function createUnrenderedSegmentError( ...@@ -11,7 +11,7 @@ export function createUnrenderedSegmentError(
`\n\n${label}:\n${missingFiles.map((p) => ` ${p}`).join('\n')}` + `\n\n${label}:\n${missingFiles.map((p) => ` ${p}`).join('\n')}` +
`\n\nWays to fix this:` + `\n\nWays to fix this:` +
`\n - [render] Render the dropped segment` + `\n - [render] Render the dropped segment` +
`\n - [ignore] Set \`export const instant = false\` to opt the dropped segment out of instant-navigation validation` + `\n - [ignore] Set \`export const instant = false\` in the dropped segment's Server Component to skip only this validation (prerendering still runs)` +
`\n\nLearn more: https://nextjs.org/docs/messages/instant-unrendered-segment` `\n\nLearn more: https://nextjs.org/docs/messages/instant-unrendered-segment`
} }
return new Error(message) return new Error(message)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment