Unverified Commit 84d5766f authored by Tobias Koppers's avatar Tobias Koppers Committed by GitHub

Disable suggesting incremental type checking (#25144)

It have performance characteristics that might not work for everyone.
You can still enable it manually.
parent 64a709db
import { promises as fs } from 'fs' import { promises as fs } from 'fs'
import chalk from 'chalk' import chalk from 'chalk'
import * as CommentJson from 'next/dist/compiled/comment-json' import * as CommentJson from 'next/dist/compiled/comment-json'
import semver from 'next/dist/compiled/semver'
import os from 'os' import os from 'os'
import { getTypeScriptConfiguration } from './getTypeScriptConfiguration' import { getTypeScriptConfiguration } from './getTypeScriptConfiguration'
...@@ -29,9 +28,6 @@ function getDesiredCompilerOptions( ...@@ -29,9 +28,6 @@ function getDesiredCompilerOptions(
strict: { suggested: false }, strict: { suggested: false },
forceConsistentCasingInFileNames: { suggested: true }, forceConsistentCasingInFileNames: { suggested: true },
noEmit: { suggested: true }, noEmit: { suggested: true },
...(semver.gte(ts.version, '4.3.0-beta')
? { incremental: { suggested: true } }
: undefined),
// These values are required and cannot be changed by the user // These values are required and cannot be changed by the user
// Keep this in sync with the webpack config // Keep this in sync with the webpack config
......
...@@ -39,7 +39,6 @@ describe('tsconfig.json verifier', () => { ...@@ -39,7 +39,6 @@ describe('tsconfig.json verifier', () => {
\\"strict\\": false, \\"strict\\": false,
\\"forceConsistentCasingInFileNames\\": true, \\"forceConsistentCasingInFileNames\\": true,
\\"noEmit\\": true, \\"noEmit\\": true,
\\"incremental\\": true,
\\"esModuleInterop\\": true, \\"esModuleInterop\\": true,
\\"module\\": \\"esnext\\", \\"module\\": \\"esnext\\",
\\"moduleResolution\\": \\"node\\", \\"moduleResolution\\": \\"node\\",
...@@ -84,7 +83,6 @@ describe('tsconfig.json verifier', () => { ...@@ -84,7 +83,6 @@ describe('tsconfig.json verifier', () => {
\\"strict\\": false, \\"strict\\": false,
\\"forceConsistentCasingInFileNames\\": true, \\"forceConsistentCasingInFileNames\\": true,
\\"noEmit\\": true, \\"noEmit\\": true,
\\"incremental\\": true,
\\"esModuleInterop\\": true, \\"esModuleInterop\\": true,
\\"module\\": \\"esnext\\", \\"module\\": \\"esnext\\",
\\"moduleResolution\\": \\"node\\", \\"moduleResolution\\": \\"node\\",
...@@ -152,7 +150,6 @@ describe('tsconfig.json verifier', () => { ...@@ -152,7 +150,6 @@ describe('tsconfig.json verifier', () => {
\\"strict\\": false, \\"strict\\": false,
\\"forceConsistentCasingInFileNames\\": true, \\"forceConsistentCasingInFileNames\\": true,
\\"noEmit\\": true, \\"noEmit\\": true,
\\"incremental\\": true,
\\"moduleResolution\\": \\"node\\", \\"moduleResolution\\": \\"node\\",
\\"resolveJsonModule\\": true, \\"resolveJsonModule\\": true,
\\"isolatedModules\\": true, \\"isolatedModules\\": true,
...@@ -201,7 +198,6 @@ describe('tsconfig.json verifier', () => { ...@@ -201,7 +198,6 @@ describe('tsconfig.json verifier', () => {
\\"strict\\": false, \\"strict\\": false,
\\"forceConsistentCasingInFileNames\\": true, \\"forceConsistentCasingInFileNames\\": true,
\\"noEmit\\": true, \\"noEmit\\": true,
\\"incremental\\": true,
\\"moduleResolution\\": \\"node\\", \\"moduleResolution\\": \\"node\\",
\\"resolveJsonModule\\": true, \\"resolveJsonModule\\": true,
\\"isolatedModules\\": true, \\"isolatedModules\\": true,
...@@ -247,7 +243,6 @@ describe('tsconfig.json verifier', () => { ...@@ -247,7 +243,6 @@ describe('tsconfig.json verifier', () => {
\\"strict\\": false, \\"strict\\": false,
\\"forceConsistentCasingInFileNames\\": true, \\"forceConsistentCasingInFileNames\\": true,
\\"noEmit\\": true, \\"noEmit\\": true,
\\"incremental\\": true,
\\"moduleResolution\\": \\"node\\", \\"moduleResolution\\": \\"node\\",
\\"resolveJsonModule\\": true, \\"resolveJsonModule\\": true,
\\"isolatedModules\\": true, \\"isolatedModules\\": true,
...@@ -286,7 +281,6 @@ describe('tsconfig.json verifier', () => { ...@@ -286,7 +281,6 @@ describe('tsconfig.json verifier', () => {
"strict": false, "strict": false,
"forceConsistentCasingInFileNames": true, "forceConsistentCasingInFileNames": true,
"noEmit": true, "noEmit": true,
"incremental": true,
"esModuleInterop": true, "esModuleInterop": true,
"module": "esnext", "module": "esnext",
"moduleResolution": "node", "moduleResolution": "node",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment