Unverified Commit 860c0742 authored by Benjamin Woodruff's avatar Benjamin Woodruff Committed by GitHub

[ci] Add optimize-ci, changes, and fetch-test-timings jobs to the needs list for…

[ci] Add optimize-ci, changes, and fetch-test-timings jobs to the needs list for the tests-pass job (#95339)

On #95332, the `fetch-test-timings` job failed. That caused downstream
jobs to get a "skip" state, instead of a failure state, which then
caused `tests-pass` to succeed. This is because if a dependency job
fails, GitHub's default behavior is for the downstream job to skip, and
to not cascade the failure.

Depending on all of these helper jobs seems like the simplest way to
prevent this from happening in the future.
parent 576d3a33
...@@ -1025,38 +1025,45 @@ jobs: ...@@ -1025,38 +1025,45 @@ jobs:
stepName: 'test-cache-components-prod-${{ matrix.group }}' stepName: 'test-cache-components-prod-${{ matrix.group }}'
secrets: inherit secrets: inherit
# We block merging unless this job passes. This is enforced by a "require
# status checks to pass" rule on the canary branch.
# <https://github.com/vercel/next.js/settings/rules/15507172>
tests-pass: tests-pass:
needs: needs:
[ # Note: Some of these jobs are dependencies of other test jobs. If they
'build-native', # fail, they'll cause the dependent test job to be skipped, which could
'build-next', # cause this aggregation job to incorrectly pass if the dependency job is
'lint', # not listed here.
'validate-docs-links', - optimize-ci
'check-types-precompiled', - changes
'test-unit', - build-native
'test-next-config-ts-native-ts-dev', - build-next
'test-next-config-ts-native-ts-prod', - fetch-test-timings
'test-dev', - lint
'test-prod', - validate-docs-links
'test-firefox-safari', - check-types-precompiled
'test-cache-components-dev', - test-unit
'test-cache-components-prod', - test-next-config-ts-native-ts-dev
'test-cargo-unit', - test-next-config-ts-native-ts-prod
'rust-check', - test-dev
'rustdoc-check', - test-prod
'test-next-swc-wasm', - test-firefox-safari
'test-turbopack-dev', - test-cache-components-dev
'test-new-tests-dev', - test-cache-components-prod
'test-new-tests-start', - test-cargo-unit
'test-new-tests-deploy', - rust-check
'test-new-tests-deploy-cache-components', - rustdoc-check
'test-turbopack-production', - test-next-swc-wasm
'test-unit-windows', - test-turbopack-dev
'test-dev-windows', - test-new-tests-dev
'test-integration-windows', - test-new-tests-start
'test-prod-windows', - test-new-tests-deploy
] - test-new-tests-deploy-cache-components
- test-turbopack-production
- test-unit-windows
- test-dev-windows
- test-integration-windows
- test-prod-windows
if: always() if: always()
runs-on: ubuntu-latest runs-on: ubuntu-latest
# Coupled with retry logic in retry_test.yml # Coupled with retry logic in retry_test.yml
......
...@@ -73,9 +73,12 @@ on: ...@@ -73,9 +73,12 @@ on:
required: false required: false
type: string type: string
default: '' default: ''
testTimingsArtifact: testTimingsArtifact:
description: 'Name of an uploaded artifact containing test-timings.json. When set, download it instead of fetching via turbo.' description: >
Name of an uploaded artifact containing test-timings.json. When set,
download it instead of fetching via turbo. This can be useful in
ensuring that when failed jobs are retried, they end up with exactly
the same set of timings, and therefore run the same set of tests.
required: false required: false
type: string type: string
default: '' default: ''
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment