Unverified Commit 887cbe43 authored by Jan Kaifer's avatar Jan Kaifer Committed by GitHub

Add types as a default dependency into tests (#44140)

parent ded93bf6
...@@ -5,13 +5,6 @@ createNextDescribe( ...@@ -5,13 +5,6 @@ createNextDescribe(
'app-dir alias handling', 'app-dir alias handling',
{ {
files: path.join(__dirname, 'app-alias'), files: path.join(__dirname, 'app-alias'),
dependencies: {
react: 'latest',
'react-dom': 'latest',
typescript: 'latest',
'@types/react': 'latest',
'@types/node': 'latest',
},
packageJson: { packageJson: {
type: 'module', type: 'module',
}, },
......
...@@ -5,13 +5,6 @@ createNextDescribe( ...@@ -5,13 +5,6 @@ createNextDescribe(
'app-dir global edge configuration', 'app-dir global edge configuration',
{ {
files: path.join(__dirname, 'app-edge-global'), files: path.join(__dirname, 'app-edge-global'),
dependencies: {
react: 'latest',
'react-dom': 'latest',
typescript: 'latest',
'@types/react': 'latest',
'@types/node': 'latest',
},
skipDeployment: true, skipDeployment: true,
}, },
({ next }) => { ({ next }) => {
......
...@@ -6,13 +6,6 @@ createNextDescribe( ...@@ -6,13 +6,6 @@ createNextDescribe(
'app-dir edge SSR', 'app-dir edge SSR',
{ {
files: path.join(__dirname, 'app-edge'), files: path.join(__dirname, 'app-edge'),
dependencies: {
react: 'latest',
'react-dom': 'latest',
typescript: 'latest',
'@types/react': 'latest',
'@types/node': 'latest',
},
skipDeployment: true, skipDeployment: true,
}, },
({ next }) => { ({ next }) => {
......
...@@ -218,13 +218,6 @@ describe('app-dir create root layout', () => { ...@@ -218,13 +218,6 @@ describe('app-dir create root layout', () => {
path.join(__dirname, 'create-root-layout/next.config.js') path.join(__dirname, 'create-root-layout/next.config.js')
), ),
}, },
dependencies: {
react: 'latest',
'react-dom': 'latest',
typescript: 'latest',
'@types/react': 'latest',
'@types/node': 'latest',
},
}) })
}) })
afterAll(() => next.destroy()) afterAll(() => next.destroy())
......
...@@ -5,13 +5,6 @@ createNextDescribe( ...@@ -5,13 +5,6 @@ createNextDescribe(
'app dir imports', 'app dir imports',
{ {
files: path.join(__dirname, 'import'), files: path.join(__dirname, 'import'),
dependencies: {
react: 'latest',
'react-dom': 'latest',
typescript: 'latest',
'@types/react': 'latest',
'@types/node': 'latest',
},
}, },
({ next }) => { ({ next }) => {
;['js', 'jsx', 'ts', 'tsx'].forEach((ext) => { ;['js', 'jsx', 'ts', 'tsx'].forEach((ext) => {
......
...@@ -5,13 +5,6 @@ createNextDescribe( ...@@ -5,13 +5,6 @@ createNextDescribe(
'app dir - layout params', 'app dir - layout params',
{ {
files: path.join(__dirname, './layout-params'), files: path.join(__dirname, './layout-params'),
dependencies: {
react: 'latest',
'react-dom': 'latest',
typescript: 'latest',
'@types/react': 'latest',
'@types/node': 'latest',
},
}, },
({ next }) => { ({ next }) => {
describe('basic params', () => { describe('basic params', () => {
......
...@@ -9,13 +9,6 @@ describe('app-dir navigation and querystring', () => { ...@@ -9,13 +9,6 @@ describe('app-dir navigation and querystring', () => {
beforeAll(async () => { beforeAll(async () => {
next = await createNext({ next = await createNext({
files: new FileRef(__dirname), files: new FileRef(__dirname),
dependencies: {
react: 'latest',
'react-dom': 'latest',
typescript: 'latest',
'@types/react': 'latest',
'@types/node': 'latest',
},
}) })
}) })
afterAll(() => next.destroy()) afterAll(() => next.destroy())
......
...@@ -9,13 +9,6 @@ describe('useSelectedLayoutSegment(s)', () => { ...@@ -9,13 +9,6 @@ describe('useSelectedLayoutSegment(s)', () => {
beforeAll(async () => { beforeAll(async () => {
next = await createNext({ next = await createNext({
files: new FileRef(__dirname), files: new FileRef(__dirname),
dependencies: {
react: 'latest',
'react-dom': 'latest',
typescript: 'latest',
'@types/react': 'latest',
'@types/node': 'latest',
},
}) })
}) })
afterAll(() => next.destroy()) afterAll(() => next.destroy())
......
...@@ -17,11 +17,6 @@ describe('New Link Behavior', () => { ...@@ -17,11 +17,6 @@ describe('New Link Behavior', () => {
'tsconfig.json': new FileRef(path.join(appDir, 'tsconfig.json')), 'tsconfig.json': new FileRef(path.join(appDir, 'tsconfig.json')),
'next.config.js': new FileRef(path.join(appDir, 'next.config.js')), 'next.config.js': new FileRef(path.join(appDir, 'next.config.js')),
}, },
dependencies: {
typescript: '*',
'@types/react': '*',
'@types/node': '*',
},
}) })
}) })
afterAll(() => next.destroy()) afterAll(() => next.destroy())
......
import { createNext, FileRef } from 'e2e-utils' import { createNext } from 'e2e-utils'
import { NextInstance } from 'test/lib/next-modes/base' import { NextInstance } from 'test/lib/next-modes/base'
import { fetchViaHTTP } from 'next-test-utils' import { fetchViaHTTP } from 'next-test-utils'
...@@ -7,12 +7,7 @@ describe('createNext', () => { ...@@ -7,12 +7,7 @@ describe('createNext', () => {
beforeAll(async () => { beforeAll(async () => {
next = await createNext({ next = await createNext({
files: new FileRef(__dirname), files: __dirname,
dependencies: {
typescript: 'latest',
'@types/react': 'latest',
'@types/node': 'latest',
},
}) })
}) })
afterAll(() => next.destroy()) afterAll(() => next.destroy())
......
...@@ -129,6 +129,9 @@ export class NextInstance { ...@@ -129,6 +129,9 @@ export class NextInstance {
const finalDependencies = { const finalDependencies = {
react: reactVersion, react: reactVersion,
'react-dom': reactVersion, 'react-dom': reactVersion,
'@types/react': reactVersion,
typescript: 'latest',
'@types/node': 'latest',
...this.dependencies, ...this.dependencies,
...this.packageJson?.dependencies, ...this.packageJson?.dependencies,
} }
......
...@@ -14,6 +14,9 @@ describe('ci-missing-typescript-deps', () => { ...@@ -14,6 +14,9 @@ describe('ci-missing-typescript-deps', () => {
CI: '1', CI: '1',
}, },
skipStart: true, skipStart: true,
dependencies: {
typescript: undefined,
},
}) })
try { try {
let error let error
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment