Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
8942d20b
Commit
8942d20b
authored
Feb 06, 2018
by
Bertrand Marron
Committed by
Arunoda Susiripala
Feb 06, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Move react{-dom,} to the common chunk in production too (#3690)
Without this, react-dom gets included in multiple pages.
parent
efed85e4
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
2 deletions
+2
-2
webpack.js
server/build/webpack.js
+2
-2
No files found.
server/build/webpack.js
View file @
8942d20b
...
@@ -250,11 +250,11 @@ export default async function getBaseWebpackConfig (dir, {dev = false, isServer
...
@@ -250,11 +250,11 @@ export default async function getBaseWebpackConfig (dir, {dev = false, isServer
// We need to move react-dom explicitly into common chunks.
// We need to move react-dom explicitly into common chunks.
// Otherwise, if some other page or module uses it, it might
// Otherwise, if some other page or module uses it, it might
// included in that bundle too.
// included in that bundle too.
if
(
dev
&&
module
.
context
&&
module
.
context
.
indexOf
(
`
${
sep
}
react
${
sep
}
`
)
>=
0
)
{
if
(
module
.
context
&&
module
.
context
.
indexOf
(
`
${
sep
}
react
${
sep
}
`
)
>=
0
)
{
return
true
return
true
}
}
if
(
dev
&&
module
.
context
&&
module
.
context
.
indexOf
(
`
${
sep
}
react-dom
${
sep
}
`
)
>=
0
)
{
if
(
module
.
context
&&
module
.
context
.
indexOf
(
`
${
sep
}
react-dom
${
sep
}
`
)
>=
0
)
{
return
true
return
true
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment