Unverified Commit 8952a10e authored by Donny/강동윤's avatar Donny/강동윤 Committed by GitHub

refactor(turbopack): Remove `ReadRawVcFuture.turbo_task` (#75217)

### Why?

`core::ptr::drop_in_place` of `ReadRawVcFuture.turbo_task` is consuming too much time.
parent 2f0c80fb
...@@ -594,8 +594,11 @@ impl<B: Backend + 'static> TurboTasks<B> { ...@@ -594,8 +594,11 @@ impl<B: Backend + 'static> TurboTasks<B> {
// track a dependency // track a dependency
let raw_result = let raw_result =
read_task_output_untracked(self, task_id, ReadConsistency::Eventual).await?; read_task_output_untracked(self, task_id, ReadConsistency::Eventual).await?;
ReadVcFuture::<Completion>::from(raw_result.into_read_untracked_with_turbo_tasks(self)) turbo_tasks_future_scope(
.await?; self.pin(),
ReadVcFuture::<Completion>::from(raw_result.into_read_untracked_with_turbo_tasks(self)),
)
.await?;
Ok(rx.await?) Ok(rx.await?)
} }
...@@ -1748,7 +1751,8 @@ pub async fn run_once<T: Send + 'static>( ...@@ -1748,7 +1751,8 @@ pub async fn run_once<T: Send + 'static>(
// INVALIDATION: A Once task will never invalidate, therefore we don't need to // INVALIDATION: A Once task will never invalidate, therefore we don't need to
// track a dependency // track a dependency
let raw_result = read_task_output_untracked(&*tt, task_id, ReadConsistency::Eventual).await?; let raw_result = read_task_output_untracked(&*tt, task_id, ReadConsistency::Eventual).await?;
ReadVcFuture::<Completion>::from(raw_result.into_read_untracked_with_turbo_tasks(&*tt)).await?; let raw_future = raw_result.into_read_untracked_with_turbo_tasks(&*tt);
turbo_tasks_future_scope(tt, ReadVcFuture::<Completion>::from(raw_future)).await?;
Ok(rx.await?) Ok(rx.await?)
} }
...@@ -1773,7 +1777,8 @@ pub async fn run_once_with_reason<T: Send + 'static>( ...@@ -1773,7 +1777,8 @@ pub async fn run_once_with_reason<T: Send + 'static>(
// INVALIDATION: A Once task will never invalidate, therefore we don't need to // INVALIDATION: A Once task will never invalidate, therefore we don't need to
// track a dependency // track a dependency
let raw_result = read_task_output_untracked(&*tt, task_id, ReadConsistency::Eventual).await?; let raw_result = read_task_output_untracked(&*tt, task_id, ReadConsistency::Eventual).await?;
ReadVcFuture::<Completion>::from(raw_result.into_read_untracked_with_turbo_tasks(&*tt)).await?; let raw_future = raw_result.into_read_untracked_with_turbo_tasks(&*tt);
turbo_tasks_future_scope(tt, ReadVcFuture::<Completion>::from(raw_future)).await?;
Ok(rx.await?) Ok(rx.await?)
} }
......
This diff is collapsed.
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment