Unverified Commit 89f0ca34 authored by vercel-fleet-prod[bot]'s avatar vercel-fleet-prod[bot] Committed by GitHub

ci: prioritize Next.js lint before stack gate checks

Co-authored-by: 's avatarTobias Koppers <1365881+sokra@users.noreply.github.com>
parent 25647f00
...@@ -553,7 +553,27 @@ test('workflow keeps expensive work gated, forks isolated and action pinned to t ...@@ -553,7 +553,27 @@ test('workflow keeps expensive work gated, forks isolated and action pinned to t
expect(block).not.toBeNull() expect(block).not.toBeNull()
expect(block[0]).toContain("needs: ['optimize-ci']") expect(block[0]).toContain("needs: ['optimize-ci']")
} }
expect(build).toContain('pnpm --dir .github/actions/pr-stack-ci-gate test') const lint = build.match(
/^ lint:\n([\s\S]*?)(?=^ validate-docs-links:)/m
)?.[1]
expect(lint).toBeDefined()
const commands = [
'pnpm lint-no-typescript',
'pnpm check-examples',
'pnpm validate-externals-doc',
'pnpm generate-browser-variant-aliases',
'pnpm --dir .github/actions/pr-stack-ci-gate install',
'pnpm --dir .github/actions/pr-stack-ci-gate types',
'pnpm --dir .github/actions/pr-stack-ci-gate build',
'pnpm --dir .github/actions/pr-stack-ci-gate test',
'git diff --exit-code',
]
let previous = -1
for (const command of commands) {
const position = lint.indexOf(` ${command}`)
expect(position).toBeGreaterThan(previous)
previous = position
}
expect(build).not.toContain('node --test .github/actions/pr-stack-ci-gate') expect(build).not.toContain('node --test .github/actions/pr-stack-ci-gate')
expect(build).toContain("needs: ['optimize-ci', 'changes', 'build-next'") expect(build).toContain("needs: ['optimize-ci', 'changes', 'build-next'")
}) })
...@@ -249,10 +249,6 @@ jobs: ...@@ -249,10 +249,6 @@ jobs:
skipNativeBuild: 'yes' skipNativeBuild: 'yes'
skipNativeInstall: 'yes' skipNativeInstall: 'yes'
afterBuild: | afterBuild: |
pnpm --dir .github/actions/pr-stack-ci-gate install --frozen-lockfile --ignore-scripts
pnpm --dir .github/actions/pr-stack-ci-gate types
pnpm --dir .github/actions/pr-stack-ci-gate build
pnpm --dir .github/actions/pr-stack-ci-gate test
pnpm lint-no-typescript pnpm lint-no-typescript
pnpm check-examples pnpm check-examples
pnpm validate-externals-doc pnpm validate-externals-doc
...@@ -260,6 +256,10 @@ jobs: ...@@ -260,6 +256,10 @@ jobs:
# `*.browser.{ts,tsx}` sibling was added/removed without running # `*.browser.{ts,tsx}` sibling was added/removed without running
# `pnpm generate-browser-variant-aliases` and committing the result. # `pnpm generate-browser-variant-aliases` and committing the result.
pnpm generate-browser-variant-aliases pnpm generate-browser-variant-aliases
pnpm --dir .github/actions/pr-stack-ci-gate install --frozen-lockfile --ignore-scripts
pnpm --dir .github/actions/pr-stack-ci-gate types
pnpm --dir .github/actions/pr-stack-ci-gate build
pnpm --dir .github/actions/pr-stack-ci-gate test
git diff --exit-code git diff --exit-code
stepName: 'lint' stepName: 'lint'
secrets: inherit secrets: inherit
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment