Unverified Commit 8b6a0ba7 authored by Benjamin Woodruff's avatar Benjamin Woodruff Committed by GitHub

chore(CI): Remove unused environment variables from `build_and_test.yml` (#78732)

See the comment added to the code.

IMO: Having these environment variables duplicated with `build_reusable.yml` is at best misleading, and at worst dangerous as you could modify the wrong file.
parent 40a51ed3
...@@ -6,26 +6,13 @@ on: ...@@ -6,26 +6,13 @@ on:
pull_request: pull_request:
types: [opened, synchronize] types: [opened, synchronize]
# NOTE: anything in `afterBuild` inherits environment variables defined in
# `build_reusable.yml` (not these!) because that job executes within the context
# of that workflow. Environment variables are not automatically passed to
# reusable workflows.
env: env:
NAPI_CLI_VERSION: 2.14.7
TURBO_VERSION: 2.3.3
NODE_MAINTENANCE_VERSION: 18 NODE_MAINTENANCE_VERSION: 18
NODE_LTS_VERSION: 20 NODE_LTS_VERSION: 20
# disable backtrace for test snapshots
RUST_BACKTRACE: 0
TURBO_TEAM: 'vercel'
TURBO_CACHE: 'remote:rw'
NEXT_TELEMETRY_DISABLED: 1
# we build a dev binary for use in CI so skip downloading
# canary next-swc binaries in the monorepo
NEXT_SKIP_NATIVE_POSTINSTALL: 1
DATADOG_API_KEY: ${{ secrets.DATA_DOG_API_KEY }}
NEXT_JUNIT_TEST_REPORT: 'true'
DD_ENV: 'ci'
TEST_TIMINGS_TOKEN: ${{ secrets.TEST_TIMINGS_TOKEN }}
NEXT_TEST_JOB: 1
NEXT_TEST_PREFER_OFFLINE: 1
jobs: jobs:
optimize-ci: optimize-ci:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment