Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
8b6fb043
Commit
8b6fb043
authored
Jul 15, 2025
by
RobPruzan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix: render indicator + panel with error overlay
parent
50202d5a
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
20 additions
and
7 deletions
+20
-7
next-logo.tsx
...s/dev-overlay/components/devtools-indicator/next-logo.tsx
+11
-6
dev-overlay-menu.tsx
...t/src/next-devtools/dev-overlay/menu/dev-overlay-menu.tsx
+1
-1
panel-router.tsx
.../next/src/next-devtools/dev-overlay/menu/panel-router.tsx
+8
-0
No files found.
packages/next/src/next-devtools/dev-overlay/components/devtools-indicator/next-logo.tsx
View file @
8b6fb043
...
@@ -7,7 +7,10 @@ import { Warning } from '../../icons/warning'
...
@@ -7,7 +7,10 @@ import { Warning } from '../../icons/warning'
import
{
css
}
from
'../../utils/css'
import
{
css
}
from
'../../utils/css'
import
{
useDevOverlayContext
}
from
'../../../dev-overlay.browser'
import
{
useDevOverlayContext
}
from
'../../../dev-overlay.browser'
import
{
useRenderErrorContext
}
from
'../../dev-overlay'
import
{
useRenderErrorContext
}
from
'../../dev-overlay'
import
{
ACTION_ERROR_OVERLAY_OPEN
}
from
'../../shared'
import
{
ACTION_ERROR_OVERLAY_CLOSE
,
ACTION_ERROR_OVERLAY_OPEN
,
}
from
'../../shared'
import
{
usePanelRouterContext
}
from
'../../menu/context'
import
{
usePanelRouterContext
}
from
'../../menu/context'
import
{
BASE_LOGO_SIZE
}
from
'../../utils/indicator-metrics'
import
{
BASE_LOGO_SIZE
}
from
'../../utils/indicator-metrics'
...
@@ -53,10 +56,7 @@ export function NextLogoNew({
...
@@ -53,10 +56,7 @@ export function NextLogoNew({
'--duration-short'
:
`${SHORT_DURATION_MS}ms`
,
'--duration-short'
:
`${SHORT_DURATION_MS}ms`
,
// if the indicator is disabled, hide the badge
// if the indicator is disabled, hide the badge
// also allow the "disabled" state be dismissed, as long as there are no build errors
// also allow the "disabled" state be dismissed, as long as there are no build errors
display
:
display
:
state
.
disableDevIndicator
&&
dismissed
?
'none'
:
'block'
,
state
.
disableDevIndicator
&&
(
!
hasError
||
dismissed
)
?
'none'
:
'block'
,
}
as
React
.
CSSProperties
}
as
React
.
CSSProperties
}
}
>
>
...
@@ -418,7 +418,12 @@ export function NextLogoNew({
...
@@ -418,7 +418,12 @@ export function NextLogoNew({
data
-
issues
-
open
data
-
issues
-
open
aria
-
label=
"Open issues overlay"
aria
-
label=
"Open issues overlay"
onClick=
{
()
=>
{
onClick=
{
()
=>
{
// wait this is wrong
if
(
state
.
isErrorOverlayOpen
)
{
dispatch
({
type
:
ACTION_ERROR_OVERLAY_CLOSE
,
})
return
}
dispatch
({
type
:
ACTION_ERROR_OVERLAY_OPEN
})
dispatch
({
type
:
ACTION_ERROR_OVERLAY_OPEN
})
setPanel
(
null
)
setPanel
(
null
)
}
}
}
}
...
...
packages/next/src/next-devtools/dev-overlay/menu/dev-overlay-menu.tsx
View file @
8b6fb043
...
@@ -160,7 +160,7 @@ export const DevtoolMenu = ({
...
@@ -160,7 +160,7 @@ export const DevtoolMenu = ({
borderRadius
:
'var(--rounded-xl)'
,
borderRadius
:
'var(--rounded-xl)'
,
position
:
'fixed'
,
position
:
'fixed'
,
fontFamily
:
'var(--font-stack-sans)'
,
fontFamily
:
'var(--font-stack-sans)'
,
zIndex
:
3
,
zIndex
:
'var(--top-z-index)'
,
overflow
:
'hidden'
,
overflow
:
'hidden'
,
opacity
:
1
,
opacity
:
1
,
minWidth
:
'248px'
,
minWidth
:
'248px'
,
...
...
packages/next/src/next-devtools/dev-overlay/menu/panel-router.tsx
View file @
8b6fb043
...
@@ -21,6 +21,7 @@ import {
...
@@ -21,6 +21,7 @@ import {
ACTION_DEV_INDICATOR_SET
,
ACTION_DEV_INDICATOR_SET
,
ACTION_DEVTOOLS_POSITION
,
ACTION_DEVTOOLS_POSITION
,
ACTION_DEVTOOLS_SCALE
,
ACTION_DEVTOOLS_SCALE
,
ACTION_ERROR_OVERLAY_CLOSE
,
ACTION_ERROR_OVERLAY_OPEN
,
ACTION_ERROR_OVERLAY_OPEN
,
}
from
'../shared'
}
from
'../shared'
import
GearIcon
from
'../icons/gear-icon'
import
GearIcon
from
'../icons/gear-icon'
...
@@ -41,6 +42,13 @@ const MenuPanel = () => {
...
@@ -41,6 +42,13 @@ const MenuPanel = () => {
label
:
'Issues'
,
label
:
'Issues'
,
value
:
<
IssueCount
>
{
totalErrorCount
}
</
IssueCount
>,
value
:
<
IssueCount
>
{
totalErrorCount
}
</
IssueCount
>,
onClick
:
()
=>
{
onClick
:
()
=>
{
if
(
state
.
isErrorOverlayOpen
)
{
dispatch
({
type
:
ACTION_ERROR_OVERLAY_CLOSE
,
})
setPanel
(
null
)
return
}
setPanel
(
null
)
setPanel
(
null
)
setSelectedIndex
(
-
1
)
setSelectedIndex
(
-
1
)
if
(
totalErrorCount
>
0
)
{
if
(
totalErrorCount
>
0
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment