Commit 8da5a338 authored by Matt Mastracci's avatar Matt Mastracci

perf(ecmascript): box RequireContextValue inside WellKnownFunctionKind

Shrinks WellKnownFunctionKind from 64 to 16 bytes and consequently JsValue from
64 to 48 bytes. RequireContextValue wraps an FxIndexMap and is only constructed
once per require.context() call site, so the added allocation is rare — but every
JsValue clone/move/drop (now 25% cheaper by size) is on the linker hot path.

Measured with link_profile on tests/benches/jsonwebtoken.js, hyperfine --runs 5:
  before: 1.893 s ± 0.014 s
   after: 1.758 s ± 0.012 s   (-7.1%)
parent 054aa46c
......@@ -3492,9 +3492,11 @@ pub enum WellKnownFunctionKind {
RequireFrom(Box<ConstantString>),
RequireResolve,
RequireContext,
RequireContextRequire(RequireContextValue),
RequireContextRequireKeys(RequireContextValue),
RequireContextRequireResolve(RequireContextValue),
// Boxed: `RequireContextValue` wraps a 56-byte `FxIndexMap`. Inlining it here dominates
// `WellKnownFunctionKind`'s size (64 bytes) and by extension `JsValue`.
RequireContextRequire(Box<RequireContextValue>),
RequireContextRequireKeys(Box<RequireContextValue>),
RequireContextRequireResolve(Box<RequireContextValue>),
Define,
FsReadMethod(Atom),
FsReadDir,
......@@ -3649,7 +3651,7 @@ pub mod test_utils {
);
JsValue::WellKnownFunction(WellKnownFunctionKind::RequireContextRequire(
RequireContextValue(map),
Box::new(RequireContextValue(map)),
))
}
Err(err) => v.into_unknown(true, PrettyPrintError(&err).to_string()),
......
......@@ -404,7 +404,7 @@ fn require(args: Vec<JsValue>) -> JsValue {
}
/// (try to) statically evaluate `require.context(...)()`
fn require_context_require(val: RequireContextValue, args: Vec<JsValue>) -> Result<JsValue> {
fn require_context_require(val: Box<RequireContextValue>, args: Vec<JsValue>) -> Result<JsValue> {
if args.is_empty() {
return Ok(JsValue::unknown(
JsValue::call(
......@@ -452,7 +452,10 @@ fn require_context_require(val: RequireContextValue, args: Vec<JsValue>) -> Resu
}
/// (try to) statically evaluate `require.context(...).keys()`
fn require_context_require_keys(val: RequireContextValue, args: Vec<JsValue>) -> Result<JsValue> {
fn require_context_require_keys(
val: Box<RequireContextValue>,
args: Vec<JsValue>,
) -> Result<JsValue> {
Ok(if args.is_empty() {
JsValue::array(val.0.keys().cloned().map(|k| k.into()).collect())
} else {
......@@ -471,7 +474,7 @@ fn require_context_require_keys(val: RequireContextValue, args: Vec<JsValue>) ->
/// (try to) statically evaluate `require.context(...).resolve()`
fn require_context_require_resolve(
val: RequireContextValue,
val: Box<RequireContextValue>,
args: Vec<JsValue>,
) -> Result<JsValue> {
if args.len() != 1 {
......
......@@ -3808,9 +3808,9 @@ async fn require_context_visitor(
);
Ok(JsValue::WellKnownFunction(
WellKnownFunctionKind::RequireContextRequire(
WellKnownFunctionKind::RequireContextRequire(Box::new(
RequireContextValue::from_context_map(map).await?,
),
)),
))
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment