[test] Fix the legacy image preload order assertion for React 18 (#99572)
PR #99528 removed the automatic individual-test retries introduced in #89929. This exposed a failure in the React 18.3.1 canary job: https://github.com/vercel/next.js/actions/runs/36976099741/job/110749496538 The test checked preload order in the hydrated DOM. React 18's client-side `next/head` updates can reorder those links, although the SSR HTML already places CSS preloads before image preloads. Jest deferred the failed test's retry until the end of the describe block. A later test had moved the shared browser to `/loader-prop` by then. That page has no preloads, so the retried assertion passed without checking the intended page's preload order. The assertion now checks the SSR HTML for `/` directly. It requires both CSS and image preloads and verifies that all CSS preloads precede the image preloads. Verified by adding the `run-react-18-tests` label to the PR on creation.
Showing
Please
register
or
sign in
to comment