Unverified Commit 8e4b6d8f authored by Zack Tanner's avatar Zack Tanner Committed by GitHub

[DevOverlay] close popover/overlay on Esc (#74889)

Closes the popover or overlay when pressing the escape key.


https://github.com/user-attachments/assets/20eb7bab-c753-40cf-8182-e655c6f31b35
parent 7363af07
...@@ -55,8 +55,8 @@ const DevToolsPopover = ({ ...@@ -55,8 +55,8 @@ const DevToolsPopover = ({
const buttonRef = useRef<HTMLDivElement>(null) const buttonRef = useRef<HTMLDivElement>(null)
const [isPopoverOpen, setIsPopoverOpen] = useState(false) const [isPopoverOpen, setIsPopoverOpen] = useState(false)
// Close popover when clicking outside of it or its button
useEffect(() => { useEffect(() => {
// Close popover when clicking outside of it or its button
const handleClickOutside = (event: MouseEvent) => { const handleClickOutside = (event: MouseEvent) => {
if ( if (
!(popoverRef.current?.getBoundingClientRect() !(popoverRef.current?.getBoundingClientRect()
...@@ -77,8 +77,19 @@ const DevToolsPopover = ({ ...@@ -77,8 +77,19 @@ const DevToolsPopover = ({
} }
} }
// Close popover when pressing escape
const handleKeyDown = (event: KeyboardEvent) => {
if (event.key === 'Escape') {
setIsPopoverOpen(false)
}
}
document.addEventListener('mousedown', handleClickOutside) document.addEventListener('mousedown', handleClickOutside)
return () => document.removeEventListener('mousedown', handleClickOutside) document.addEventListener('keydown', handleKeyDown)
return () => {
document.removeEventListener('mousedown', handleClickOutside)
document.removeEventListener('keydown', handleKeyDown)
}
}, []) }, [])
const togglePopover = () => setIsPopoverOpen((prev) => !prev) const togglePopover = () => setIsPopoverOpen((prev) => !prev)
......
...@@ -199,6 +199,18 @@ export function Errors({ ...@@ -199,6 +199,18 @@ export function Errors({
} }
}, [errors.length, minimize]) }, [errors.length, minimize])
useEffect(() => {
// Close the error overlay when pressing escape
function handleKeyDown(event: KeyboardEvent) {
if (event.key === 'Escape') {
setDisplayState('minimized')
}
}
document.addEventListener('keydown', handleKeyDown)
return () => document.removeEventListener('keydown', handleKeyDown)
}, [])
const hide = useCallback(() => setDisplayState('hidden'), []) const hide = useCallback(() => setDisplayState('hidden'), [])
const fullscreen = useCallback(() => setDisplayState('fullscreen'), []) const fullscreen = useCallback(() => setDisplayState('fullscreen'), [])
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment