Unverified Commit 8e7c45bf authored by JJ Kasper's avatar JJ Kasper Committed by GitHub

Fix app page check on windows (#43022)

Ensures we check for backslashes as well when matching `/page`. Will
investigate adding the app suite to windows CI in follow-up

x-ref: https://github.com/vercel/next.js/pull/42996
Fixes: https://github.com/vercel/next.js/issues/43019

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm build && pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
parent 3d4c038f
...@@ -66,7 +66,7 @@ export async function findPageFile( ...@@ -66,7 +66,7 @@ export async function findPageFile(
// Determine if the file is leaf node page file under layouts, // Determine if the file is leaf node page file under layouts,
// The filename should start with 'page' and end with one of the allowed extensions // The filename should start with 'page' and end with one of the allowed extensions
export function isLayoutsLeafPage(filePath: string, pageExtensions: string[]) { export function isLayoutsLeafPage(filePath: string, pageExtensions: string[]) {
return new RegExp(`(^page|/page)\\.(?:${pageExtensions.join('|')})$`).test( return new RegExp(
filePath `(^page|[\\/]page)\\.(?:${pageExtensions.join('|')})$`
) ).test(filePath)
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment