Unverified Commit 9014f046 authored by Jiwon Choi's avatar Jiwon Choi Committed by GitHub

Do not check Node version while agentic upgrade (#98852)

If upgrade handles the Node version check, upgrade from Next version
that allowed Node v18 -> Next version that require Node v20 can fail the
upgrade. Next handles compatible Node version so proceed upgrade and let
agent handle it afterwards.
parent 3bf71ee3
...@@ -37,7 +37,6 @@ export async function prepareUpgrade( ...@@ -37,7 +37,6 @@ export async function prepareUpgrade(
await readFile(requireFromApp.resolve('next/package.json'), 'utf8') await readFile(requireFromApp.resolve('next/package.json'), 'utf8')
) as { ) as {
version: string version: string
engines: { node: string | undefined } | undefined
} }
const installedVersion = installedNext.version const installedVersion = installedNext.version
...@@ -55,10 +54,7 @@ export async function prepareUpgrade( ...@@ -55,10 +54,7 @@ export async function prepareUpgrade(
if (targetRequest === 'latest' || targetRequest === 'future') { if (targetRequest === 'latest' || targetRequest === 'future') {
const url = `${NPM_REGISTRY}next/latest` const url = `${NPM_REGISTRY}next/latest`
const { value } = await fetchJSON(url) const { value } = await fetchJSON(url)
const release = value as { const release = value as { version: string } | null
version: string
engines: { node: string | undefined } | undefined
} | null
if ( if (
!release || !release ||
...@@ -72,10 +68,6 @@ export async function prepareUpgrade( ...@@ -72,10 +68,6 @@ export async function prepareUpgrade(
targetRequest === 'future' && semver.gt(installedVersion, release.version) targetRequest === 'future' && semver.gt(installedVersion, release.version)
? installedVersion ? installedVersion
: release.version : release.version
const nodeRange =
targetVersion === installedVersion
? (installedNext.engines?.node ?? null)
: (release.engines?.node ?? null)
if ( if (
targetRequest === 'latest' && targetRequest === 'latest' &&
...@@ -97,12 +89,6 @@ export async function prepareUpgrade( ...@@ -97,12 +89,6 @@ export async function prepareUpgrade(
} }
} }
if (!nodeRange || !semver.satisfies(process.versions.node, nodeRange)) {
throw new Error(
`Next.js ${targetVersion} requires Node.js ${nodeRange ?? '(version unavailable)'}. Update Node.js before continuing.`
)
}
let pendingFutureDefaults: FutureDefaultEntry[] = [] let pendingFutureDefaults: FutureDefaultEntry[] = []
if (targetRequest === 'future') { if (targetRequest === 'future') {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment