Unverified Commit 91136d23 authored by Shu Ding's avatar Shu Ding Committed by GitHub

Update comments for the web server (#35366)

The web server is used as minimal mode, whereas public file handling, envs and compression are both handled by the upper layer (edge runtime if deployed serverlessly, or node server if self-hosted).

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
parent 853442df
...@@ -31,7 +31,8 @@ export default class NextWebServer extends BaseServer { ...@@ -31,7 +31,8 @@ export default class NextWebServer extends BaseServer {
} }
} }
protected handleCompression() { protected handleCompression() {
// @TODO // For the web server layer, compression is automatically handled by the
// upstream proxy (edge runtime or node server) and we can simply skip here.
} }
protected getRoutesManifest() { protected getRoutesManifest() {
return { return {
...@@ -49,14 +50,15 @@ export default class NextWebServer extends BaseServer { ...@@ -49,14 +50,15 @@ export default class NextWebServer extends BaseServer {
return '' return ''
} }
protected getPublicDir() { protected getPublicDir() {
// @TODO // Public files are not handled by the web server.
return '' return ''
} }
protected getBuildId() { protected getBuildId() {
return (globalThis as any).__server_context.buildId return (globalThis as any).__server_context.buildId
} }
protected loadEnvConfig() { protected loadEnvConfig() {
// @TODO // The web server does not need to load the env config. This is done by the
// runtime already.
} }
protected getHasStaticDir() { protected getHasStaticDir() {
return false return false
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment