Unverified Commit 93d56b5d authored by Niklas Mischkulnig's avatar Niklas Mischkulnig Committed by GitHub

Turbopack: improve cell order lint rule for ReadRef::cell (#88500)

The "cell in async map" pattern
parent b645f4ce
...@@ -12,6 +12,7 @@ rule: ...@@ -12,6 +12,7 @@ rule:
- pattern: $_X.resolved_cell() - pattern: $_X.resolved_cell()
- pattern: ResolvedVc::cell($_X) - pattern: ResolvedVc::cell($_X)
- pattern: Vc::cell($_X) - pattern: Vc::cell($_X)
- pattern: ReadRef::cell($_X)
- inside: - inside:
stopBy: end stopBy: end
all: all:
......
...@@ -24,7 +24,8 @@ impl Version for EcmascriptBrowserMergedChunkVersion { ...@@ -24,7 +24,8 @@ impl Version for EcmascriptBrowserMergedChunkVersion {
let mut sorted_ids = self let mut sorted_ids = self
.versions .versions
.iter() .iter()
.map(|version| async move { ReadRef::cell(version.clone()).id().await }) // This ReadRef::cell call is important, as it means that `.id()` is cached.
.map(|version| ReadRef::cell(version.clone()).id())
.try_join() .try_join()
.await?; .await?;
sorted_ids.sort(); sorted_ids.sort();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment