Unverified Commit 958b9669 authored by Hendrik Liebau's avatar Hendrik Liebau Committed by GitHub

Add test fixtures demonstrating export statement validation bugs (#75277)

The issues with the current export statement validation for app router
pages are documented in the added fixtures, see also the inline comments
in the diff.
parent 3e7a510f
......@@ -89,36 +89,11 @@ fn next_ssg_errors(input: PathBuf) {
);
}
#[fixture("tests/errors/react-server-components/server-graph/**/input.js")]
fn react_server_components_server_graph_errors(input: PathBuf) {
use next_custom_transforms::transforms::react_server_components::{Config, Options};
let output = input.parent().unwrap().join("output.js");
test_fixture(
syntax(),
&|tr| {
server_components(
FileName::Real(PathBuf::from("/some-project/src/layout.js")).into(),
Config::WithOptions(Options {
is_react_server_layer: true,
dynamic_io_enabled: false,
}),
tr.comments.as_ref().clone(),
None,
)
},
&input,
&output,
FixtureTestConfig {
allow_error: true,
module: Some(true),
..Default::default()
},
);
}
#[fixture("tests/errors/react-server-components/client-graph/**/input.js")]
fn react_server_components_client_graph_errors(input: PathBuf) {
#[fixture("tests/errors/react-server-components/**/input.js")]
fn react_server_components_errors(input: PathBuf) {
use next_custom_transforms::transforms::react_server_components::{Config, Options};
let is_react_server_layer = input.iter().any(|s| s.to_str() == Some("server-graph"));
let dynamic_io_enabled = input.iter().any(|s| s.to_str() == Some("dynamic-io"));
let output = input.parent().unwrap().join("output.js");
test_fixture(
syntax(),
......@@ -126,8 +101,8 @@ fn react_server_components_client_graph_errors(input: PathBuf) {
server_components(
FileName::Real(PathBuf::from("/some-project/src/page.js")).into(),
Config::WithOptions(Options {
is_react_server_layer: false,
dynamic_io_enabled: false,
is_react_server_layer,
dynamic_io_enabled,
}),
tr.comments.as_ref().clone(),
None,
......@@ -164,50 +139,10 @@ fn next_font_loaders_errors(input: PathBuf) {
);
}
#[fixture("tests/errors/server-actions/server-graph/**/input.js")]
fn react_server_actions_server_errors(input: PathBuf) {
use next_custom_transforms::transforms::react_server_components::{Config, Options};
let output = input.parent().unwrap().join("output.js");
test_fixture(
syntax(),
&|tr| {
(
resolver(Mark::new(), Mark::new(), false),
server_components(
FileName::Real(PathBuf::from("/app/item.js")).into(),
Config::WithOptions(Options {
is_react_server_layer: true,
dynamic_io_enabled: true,
}),
tr.comments.as_ref().clone(),
None,
),
server_actions(
&FileName::Real("/app/item.js".into()),
server_actions::Config {
is_react_server_layer: true,
use_cache_enabled: true,
hash_salt: "".into(),
cache_kinds: FxHashSet::default(),
},
tr.comments.as_ref().clone(),
Default::default(),
),
)
},
&input,
&output,
FixtureTestConfig {
allow_error: true,
module: Some(true),
..Default::default()
},
);
}
#[fixture("tests/errors/server-actions/client-graph/**/input.js")]
fn react_server_actions_client_errors(input: PathBuf) {
#[fixture("tests/errors/server-actions/**/input.js")]
fn react_server_actions_errors(input: PathBuf) {
use next_custom_transforms::transforms::react_server_components::{Config, Options};
let is_react_server_layer = input.iter().any(|s| s.to_str() == Some("server-graph"));
let output = input.parent().unwrap().join("output.js");
test_fixture(
syntax(),
......@@ -217,7 +152,7 @@ fn react_server_actions_client_errors(input: PathBuf) {
server_components(
FileName::Real(PathBuf::from("/app/item.js")).into(),
Config::WithOptions(Options {
is_react_server_layer: false,
is_react_server_layer,
dynamic_io_enabled: true,
}),
tr.comments.as_ref().clone(),
......@@ -226,7 +161,7 @@ fn react_server_actions_client_errors(input: PathBuf) {
server_actions(
&FileName::Real("/app/item.js".into()),
server_actions::Config {
is_react_server_layer: false,
is_react_server_layer,
use_cache_enabled: true,
hash_salt: "".into(),
cache_kinds: FxHashSet::default(),
......
export function generateMetadata() {}
export default function () {
return null
}
export function generateMetadata() {}
export default function() {
return null;
}
x You are attempting to export "generateMetadata" from a component marked with "use client", which is disallowed. Either remove the export, or the "use client" directive. Read more: https://
| nextjs.org/docs/app/api-reference/directives/use-client
|
|
,-[input.js:1:1]
1 | export function generateMetadata() {}
: ^^^^^^^^^^^^^^^^
`----
export const metadata = {}
export default function () {
return null
}
export const metadata = {};
export default function() {
return null;
}
x You are attempting to export "metadata" from a component marked with "use client", which is disallowed. Either remove the export, or the "use client" directive. Read more: https://nextjs.org/
| docs/app/api-reference/directives/use-client
|
|
,-[input.js:1:1]
1 | export const metadata = {}
: ^^^^^^^^
`----
export const metadata = {}
export function generateMetadata() {}
export function getServerSideProps() {}
export default function () {
return null
}
export const metadata = {};
export function generateMetadata() {}
export function getServerSideProps() {}
export default function() {
return null;
}
x You are attempting to export "getServerSideProps" from a component marked with "use client", which is disallowed. Either remove the export, or the "use client" directive. Read more: https://
| nextjs.org/docs/app/api-reference/directives/use-client
|
|
,-[input.js:5:1]
4 |
5 | export function getServerSideProps() {}
: ^^^^^^^^^^^^^^^^^^
`----
x "getServerSideProps" is not supported in app/. Read more: https://nextjs.org/docs/app/building-your-application/data-fetching
|
|
,-[input.js:5:1]
4 |
5 | export function getServerSideProps() {}
: ^^^^^^^^^^^^^^^^^^
`----
export const runtime = 'edge'
export const dynamic = 'force-dynamic'
export const dynamicParams = false
export const fetchCache = 'force-no-store'
export const revalidate = 1
export const runtime = 'edge';
export const dynamic = 'force-dynamic';
export const dynamicParams = false;
export const fetchCache = 'force-no-store';
export const revalidate = 1;
x "dynamicParams" is not compatible with `nextConfig.experimental.dynamicIO`. Please remove it.
,-[input.js:5:1]
4 | export const fetchCache = 'force-no-store'
5 | export const revalidate = 1
: ^^^^^^^^^^
`----
x "dynamic" is not compatible with `nextConfig.experimental.dynamicIO`. Please remove it.
,-[input.js:5:1]
4 | export const fetchCache = 'force-no-store'
5 | export const revalidate = 1
: ^^^^^^^^^^
`----
x "fetchCache" is not compatible with `nextConfig.experimental.dynamicIO`. Please remove it.
,-[input.js:5:1]
4 | export const fetchCache = 'force-no-store'
5 | export const revalidate = 1
: ^^^^^^^^^^
`----
x "runtime" is not compatible with `nextConfig.experimental.dynamicIO`. Please remove it.
,-[input.js:5:1]
4 | export const fetchCache = 'force-no-store'
5 | export const revalidate = 1
: ^^^^^^^^^^
`----
x "revalidate" is not compatible with `nextConfig.experimental.dynamicIO`. Please remove it.
,-[input.js:5:1]
4 | export const fetchCache = 'force-no-store'
5 | export const revalidate = 1
: ^^^^^^^^^^
`----
// generateMetadata without metadata is ok.
export function generateMetadata() {}
export default function () {
return null
}
// generateMetadata without metadata is ok.
export function generateMetadata() {}
export default function() {
return null;
}
export const metadata = {}
export function generateMetadata() {}
export default function () {
return null
}
export const metadata = {};
export function generateMetadata() {}
export default function() {
return null;
}
x "metadata" and "generateMetadata" cannot be exported at the same time, please keep one of them. Read more: https://nextjs.org/docs/app/api-reference/file-conventions/metadata
|
|
,-[input.js:3:1]
2 |
3 | export function generateMetadata() {}
: ^^^^^^^^^^^^^^^^
`----
// metadata without generateMetadata is ok.
export const metadata = {}
export default function () {
return null
}
// metadata without generateMetadata is ok.
export const metadata = {};
export default function() {
return null;
}
......@@ -489,9 +489,10 @@ fn react_server_components_typescript(input: PathBuf) {
);
}
#[fixture("tests/fixture/react-server-components/server-graph/**/input.js")]
fn react_server_components_server_graph_fixture(input: PathBuf) {
#[fixture("tests/fixture/react-server-components/**/input.js")]
fn react_server_components_fixture(input: PathBuf) {
use next_custom_transforms::transforms::react_server_components::{Config, Options};
let is_react_server_layer = input.iter().any(|s| s.to_str() == Some("server-graph"));
let output = input.parent().unwrap().join("output.js");
test_fixture(
syntax(),
......@@ -499,7 +500,7 @@ fn react_server_components_server_graph_fixture(input: PathBuf) {
server_components(
FileName::Real(PathBuf::from("/some-project/src/some-file.js")).into(),
Config::WithOptions(Options {
is_react_server_layer: true,
is_react_server_layer,
dynamic_io_enabled: false,
}),
tr.comments.as_ref().clone(),
......@@ -515,29 +516,6 @@ fn react_server_components_server_graph_fixture(input: PathBuf) {
);
}
#[fixture("tests/fixture/react-server-components/client-graph/**/input.js")]
fn react_server_components_client_graph_fixture(input: PathBuf) {
use next_custom_transforms::transforms::react_server_components::{Config, Options};
let output = input.parent().unwrap().join("output.js");
test_fixture(
syntax(),
&|tr| {
server_components(
FileName::Real(PathBuf::from("/some-project/src/some-file.js")).into(),
Config::WithOptions(Options {
is_react_server_layer: false,
dynamic_io_enabled: false,
}),
tr.comments.as_ref().clone(),
None,
)
},
&input,
&output,
Default::default(),
);
}
#[fixture("tests/fixture/next-font-loaders/**/input.js")]
fn next_font_loaders_fixture(input: PathBuf) {
let output = input.parent().unwrap().join("output.js");
......@@ -555,9 +533,10 @@ fn next_font_loaders_fixture(input: PathBuf) {
);
}
#[fixture("tests/fixture/server-actions/server/**/input.js")]
fn server_actions_server_fixture(input: PathBuf) {
#[fixture("tests/fixture/server-actions/**/input.js")]
fn server_actions_fixture(input: PathBuf) {
let output = input.parent().unwrap().join("output.js");
let is_react_server_layer = input.iter().any(|s| s.to_str() == Some("server-graph"));
test_fixture(
syntax(),
&|_tr| {
......@@ -566,7 +545,7 @@ fn server_actions_server_fixture(input: PathBuf) {
server_actions(
&FileName::Real("/app/item.js".into()),
server_actions::Config {
is_react_server_layer: true,
is_react_server_layer,
use_cache_enabled: true,
hash_salt: "".into(),
cache_kinds: FxHashSet::from_iter(["x".into()]),
......@@ -616,36 +595,6 @@ fn next_font_with_directive_fixture(input: PathBuf) {
);
}
#[fixture("tests/fixture/server-actions/client/**/input.js")]
fn server_actions_client_fixture(input: PathBuf) {
let output = input.parent().unwrap().join("output.js");
test_fixture(
syntax(),
&|_tr| {
(
resolver(Mark::new(), Mark::new(), false),
server_actions(
&FileName::Real("/app/item.js".into()),
server_actions::Config {
is_react_server_layer: false,
use_cache_enabled: true,
hash_salt: "".into(),
cache_kinds: FxHashSet::default(),
},
_tr.comments.as_ref().clone(),
Default::default(),
),
)
},
&input,
&output,
FixtureTestConfig {
module: Some(true),
..Default::default()
},
);
}
#[fixture("tests/fixture/cjs-optimize/**/input.js")]
fn cjs_optimize_fixture(input: PathBuf) {
let output = input.parent().unwrap().join("output.js");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment