Unverified Commit 95d1bb2c authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Split webpack specific test into separate test suite (#66328)

## What?

Ensures `next build` does not fail with Turbopack on
`test/e2e/app-dir/rsc-basic/rsc-basic.test.ts`. Gets 36 extra tests
passing for Turbopack build.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
parent 92443b6f
......@@ -606,20 +606,6 @@ describe('app dir - rsc basics', () => {
)
})
// Skip as Turbopack doesn't support webpack loaders.
;(process.env.TURBOPACK ? it.skip : it)(
'should support webpack loader rules',
async () => {
const browser = await next.browser('/loader-rule')
expect(
await browser.eval(
`window.getComputedStyle(document.querySelector('#red')).color`
)
).toBe('rgb(255, 0, 0)')
}
)
if (isNextStart) {
it('should generate edge SSR manifests for Node.js', async () => {
const requiredServerFiles = JSON.parse(
......
import React from 'react'
export default function AppLayout({ children }) {
return (
<html>
<head>
<title>RSC</title>
</head>
<body>{children}</body>
</html>
)
}
module.exports = {
reactStrictMode: true,
onDemandEntries: {
maxInactiveAge: 1000 * 60 * 60,
},
serverExternalPackages: ['conditional-exports-optout'],
rewrites: async () => {
return {
afterFiles: [
{
source: '/rewritten-to-edge-dynamic',
destination: '/edge/dynamic',
},
],
}
},
}
import { nextTestSetup } from 'e2e-utils'
;(process.env.TURBOPACK ? describe.skip : describe)(
'app dir - rsc webpack loader',
() => {
const { next } = nextTestSetup({
files: __dirname,
dependencies: {
'styled-components': 'latest',
'server-only': 'latest',
},
resolutions: {
'@babel/core': '7.22.18',
'@babel/parser': '7.22.16',
'@babel/types': '7.22.17',
'@babel/traverse': '7.22.18',
},
})
// Skip as Turbopack doesn't support webpack loaders.
it('should support webpack loader rules', async () => {
const browser = await next.browser('/loader-rule')
expect(
await browser.eval(
`window.getComputedStyle(document.querySelector('#red')).color`
)
).toBe('rgb(255, 0, 0)')
})
}
)
......@@ -2979,8 +2979,7 @@
"runtimeError": false
},
"test/e2e/app-dir/rsc-basic/rsc-basic.test.ts": {
"passed": [],
"failed": [
"passed": [
"app dir - rsc basics next internal shared context should not error if just load next/navigation module in pages/api",
"app dir - rsc basics next internal shared context should not error if just load next/router module in app page",
"app dir - rsc basics react@experimental should opt into the react@experimental when enabling ppr",
......@@ -3018,10 +3017,10 @@
"app dir - rsc basics should track client components in dynamic imports",
"app dir - rsc basics should use canary react for app"
],
"failed": [],
"pending": [
"app dir - rsc basics should not use bundled react for pages with app",
"app dir - rsc basics should support partial hydration with inlined server data in browser",
"app dir - rsc basics should support webpack loader rules"
"app dir - rsc basics should support partial hydration with inlined server data in browser"
],
"flakey": [],
"runtimeError": false
......@@ -5144,8 +5144,7 @@
"failed": [],
"pending": [
"app dir - rsc basics should not use bundled react for pages with app",
"app dir - rsc basics should support partial hydration with inlined server data in browser",
"app dir - rsc basics should support webpack loader rules"
"app dir - rsc basics should support partial hydration with inlined server data in browser"
],
"flakey": [],
"runtimeError": false
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment