Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
97dd708e
Unverified
Commit
97dd708e
authored
Nov 17, 2025
by
Tobias Koppers
Committed by
GitHub
Nov 17, 2025
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Turbopack: mark more modules as side effect free (#86136)
### What? These modules can be always side effect free.
parent
b3b97bc4
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
54 additions
and
1 deletion
+54
-1
module.rs
...ack/crates/turbopack-ecmascript/src/async_chunk/module.rs
+9
-0
chunk_asset.rs
...k/crates/turbopack-ecmascript/src/manifest/chunk_asset.rs
+9
-0
require_context.rs
...es/turbopack-ecmascript/src/references/require_context.rs
+9
-1
module.rs
...ck/crates/turbopack-ecmascript/src/worker_chunk/module.rs
+9
-0
css.rs
turbopack/crates/turbopack-static/src/css.rs
+9
-0
ecma.rs
turbopack/crates/turbopack-static/src/ecma.rs
+9
-0
No files found.
turbopack/crates/turbopack-ecmascript/src/async_chunk/module.rs
View file @
97dd708e
use
anyhow
::
Result
;
use
anyhow
::
Result
;
use
turbo_rcstr
::
rcstr
;
use
turbo_rcstr
::
rcstr
;
use
turbo_tasks
::{
ResolvedVc
,
Vc
};
use
turbo_tasks
::{
ResolvedVc
,
Vc
};
use
turbo_tasks_fs
::
glob
::
Glob
;
use
turbopack_core
::{
use
turbopack_core
::{
asset
::{
Asset
,
AssetContent
},
asset
::{
Asset
,
AssetContent
},
chunk
::{
ChunkableModule
,
ChunkingContext
,
availability_info
::
AvailabilityInfo
},
chunk
::{
ChunkableModule
,
ChunkingContext
,
availability_info
::
AvailabilityInfo
},
...
@@ -60,6 +61,14 @@ impl Module for AsyncLoaderModule {
...
@@ -60,6 +61,14 @@ impl Module for AsyncLoaderModule {
.await
?
,
.await
?
,
)]))
)]))
}
}
#[turbo_tasks
::
function]
fn
is_marked_as_side_effect_free
(
self
:
Vc
<
Self
>
,
_side_effect_free_packages
:
Vc
<
Glob
>
,
)
->
Vc
<
bool
>
{
Vc
::
cell
(
true
)
}
}
}
#[turbo_tasks
::
value_impl]
#[turbo_tasks
::
value_impl]
...
...
turbopack/crates/turbopack-ecmascript/src/manifest/chunk_asset.rs
View file @
97dd708e
use
anyhow
::
Result
;
use
anyhow
::
Result
;
use
turbo_rcstr
::{
RcStr
,
rcstr
};
use
turbo_rcstr
::{
RcStr
,
rcstr
};
use
turbo_tasks
::{
ResolvedVc
,
TryJoinIterExt
,
Vc
};
use
turbo_tasks
::{
ResolvedVc
,
TryJoinIterExt
,
Vc
};
use
turbo_tasks_fs
::
glob
::
Glob
;
use
turbopack_core
::{
use
turbopack_core
::{
asset
::{
Asset
,
AssetContent
},
asset
::{
Asset
,
AssetContent
},
chunk
::{
chunk
::{
...
@@ -146,6 +147,14 @@ impl Module for ManifestAsyncModule {
...
@@ -146,6 +147,14 @@ impl Module for ManifestAsyncModule {
.await
?
,
.await
?
,
))
))
}
}
#[turbo_tasks
::
function]
fn
is_marked_as_side_effect_free
(
self
:
Vc
<
Self
>
,
_side_effect_free_packages
:
Vc
<
Glob
>
,
)
->
Vc
<
bool
>
{
Vc
::
cell
(
true
)
}
}
}
#[turbo_tasks
::
value_impl]
#[turbo_tasks
::
value_impl]
...
...
turbopack/crates/turbopack-ecmascript/src/references/require_context.rs
View file @
97dd708e
...
@@ -19,7 +19,7 @@ use turbo_tasks::{
...
@@ -19,7 +19,7 @@ use turbo_tasks::{
FxIndexMap
,
NonLocalValue
,
ResolvedVc
,
ValueToString
,
Vc
,
debug
::
ValueDebugFormat
,
FxIndexMap
,
NonLocalValue
,
ResolvedVc
,
ValueToString
,
Vc
,
debug
::
ValueDebugFormat
,
trace
::
TraceRawVcs
,
trace
::
TraceRawVcs
,
};
};
use
turbo_tasks_fs
::{
DirectoryContent
,
DirectoryEntry
,
FileSystemPath
};
use
turbo_tasks_fs
::{
DirectoryContent
,
DirectoryEntry
,
FileSystemPath
,
glob
::
Glob
};
use
turbopack_core
::{
use
turbopack_core
::{
asset
::{
Asset
,
AssetContent
},
asset
::{
Asset
,
AssetContent
},
chunk
::{
chunk
::{
...
@@ -421,6 +421,14 @@ impl Module for RequireContextAsset {
...
@@ -421,6 +421,14 @@ impl Module for RequireContextAsset {
.collect
(),
.collect
(),
))
))
}
}
#[turbo_tasks
::
function]
fn
is_marked_as_side_effect_free
(
self
:
Vc
<
Self
>
,
_side_effect_free_packages
:
Vc
<
Glob
>
,
)
->
Vc
<
bool
>
{
Vc
::
cell
(
true
)
}
}
}
#[turbo_tasks
::
value_impl]
#[turbo_tasks
::
value_impl]
...
...
turbopack/crates/turbopack-ecmascript/src/worker_chunk/module.rs
View file @
97dd708e
use
anyhow
::
Result
;
use
anyhow
::
Result
;
use
turbo_rcstr
::{
RcStr
,
rcstr
};
use
turbo_rcstr
::{
RcStr
,
rcstr
};
use
turbo_tasks
::{
ResolvedVc
,
ValueToString
,
Vc
};
use
turbo_tasks
::{
ResolvedVc
,
ValueToString
,
Vc
};
use
turbo_tasks_fs
::
glob
::
Glob
;
use
turbopack_core
::{
use
turbopack_core
::{
asset
::{
Asset
,
AssetContent
},
asset
::{
Asset
,
AssetContent
},
chunk
::{
chunk
::{
...
@@ -51,6 +52,14 @@ impl Module for WorkerLoaderModule {
...
@@ -51,6 +52,14 @@ impl Module for WorkerLoaderModule {
.await
?
,
.await
?
,
)]))
)]))
}
}
#[turbo_tasks
::
function]
fn
is_marked_as_side_effect_free
(
self
:
Vc
<
Self
>
,
_side_effect_free_packages
:
Vc
<
Glob
>
,
)
->
Vc
<
bool
>
{
Vc
::
cell
(
true
)
}
}
}
#[turbo_tasks
::
value_impl]
#[turbo_tasks
::
value_impl]
...
...
turbopack/crates/turbopack-static/src/css.rs
View file @
97dd708e
use
turbo_rcstr
::{
RcStr
,
rcstr
};
use
turbo_rcstr
::{
RcStr
,
rcstr
};
use
turbo_tasks
::{
ResolvedVc
,
Vc
};
use
turbo_tasks
::{
ResolvedVc
,
Vc
};
use
turbo_tasks_fs
::
glob
::
Glob
;
use
turbopack_core
::{
use
turbopack_core
::{
asset
::{
Asset
,
AssetContent
},
asset
::{
Asset
,
AssetContent
},
chunk
::
ChunkingContext
,
chunk
::
ChunkingContext
,
...
@@ -45,6 +46,14 @@ impl Module for StaticUrlCssModule {
...
@@ -45,6 +46,14 @@ impl Module for StaticUrlCssModule {
}
}
ident
ident
}
}
#[turbo_tasks
::
function]
fn
is_marked_as_side_effect_free
(
self
:
Vc
<
Self
>
,
_side_effect_free_packages
:
Vc
<
Glob
>
,
)
->
Vc
<
bool
>
{
Vc
::
cell
(
true
)
}
}
}
#[turbo_tasks
::
value_impl]
#[turbo_tasks
::
value_impl]
...
...
turbopack/crates/turbopack-static/src/ecma.rs
View file @
97dd708e
use
anyhow
::
Result
;
use
anyhow
::
Result
;
use
turbo_rcstr
::{
RcStr
,
rcstr
};
use
turbo_rcstr
::{
RcStr
,
rcstr
};
use
turbo_tasks
::{
ResolvedVc
,
Vc
};
use
turbo_tasks
::{
ResolvedVc
,
Vc
};
use
turbo_tasks_fs
::
glob
::
Glob
;
use
turbopack_core
::{
use
turbopack_core
::{
asset
::{
Asset
,
AssetContent
},
asset
::{
Asset
,
AssetContent
},
chunk
::{
ChunkItem
,
ChunkType
,
ChunkableModule
,
ChunkingContext
},
chunk
::{
ChunkItem
,
ChunkType
,
ChunkableModule
,
ChunkingContext
},
...
@@ -57,6 +58,14 @@ impl Module for StaticUrlJsModule {
...
@@ -57,6 +58,14 @@ impl Module for StaticUrlJsModule {
}
}
ident
ident
}
}
#[turbo_tasks
::
function]
fn
is_marked_as_side_effect_free
(
self
:
Vc
<
Self
>
,
_side_effect_free_packages
:
Vc
<
Glob
>
,
)
->
Vc
<
bool
>
{
Vc
::
cell
(
true
)
}
}
}
#[turbo_tasks
::
value_impl]
#[turbo_tasks
::
value_impl]
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment