Unverified Commit 9ab6d3bf authored by Francis Li's avatar Francis Li Committed by GitHub

Fix cookie parsing removing extra `=` (#44218)

When parsing a cookie, extra `=` characters are removed, when only the
first should be removed.

e.g. with the cookie
`csrf_token_ae6261a96213c493a37ea69489ee39c8bc33a53cda7d95f84efa53146145d09c=lnQptRUO/gpU26e8ZKpGIFHKqtP54vVfR7RBiph8Uc0=`

You would expect:
key:
`csrf_token_ae6261a96213c493a37ea69489ee39c8bc33a53cda7d95f84efa53146145d09c`
value: `lnQptRUO/gpU26e8ZKpGIFHKqtP54vVfR7RBiph8Uc0=`

If you use `split`, it will remove the last `=` in value, so you get:
key:
`csrf_token_ae6261a96213c493a37ea69489ee39c8bc33a53cda7d95f84efa53146145d09c`
value: `lnQptRUO/gpU26e8ZKpGIFHKqtP54vVfR7RBiph8Uc0`

This is because `split` still removes all `=` characters, even if you
use the `limit` parameter to limit it to the first 2 elements (as in the
existing code).

Solution is to not use `split` (I've used `slice` instead)

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [x] Errors have a helpful link attached, see
[`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)
parent c2229a3a
...@@ -40,7 +40,9 @@ export function parseCookieString(cookie: string): Map<string, string> { ...@@ -40,7 +40,9 @@ export function parseCookieString(cookie: string): Map<string, string> {
for (const pair of cookie.split(/; */)) { for (const pair of cookie.split(/; */)) {
if (!pair) continue if (!pair) continue
const [key, value] = pair.split('=', 2) const splitIndex = pair.indexOf('=')
const key = pair.slice(0, splitIndex)
const value = pair.slice(splitIndex + 1)
map.set(key, decodeURIComponent(value ?? 'true')) map.set(key, decodeURIComponent(value ?? 'true'))
} }
......
/* eslint-env jest */
import { parseCookieString } from 'next/dist/server/web/spec-extension/cookies/serialize'
function mapToCookieString(map: Map<string, string>) {
let s = ''
for (const [k, v] of map.entries()) {
s += `${k}=${v};`
}
return s
}
describe('parse cookie string', () => {
it('with a plain value', async () => {
const input = new Map([['foo', 'bar']])
const result = parseCookieString(mapToCookieString(input))
expect(result).toEqual(input)
})
it('with multiple `=`', async () => {
const input = new Map([['foo', 'bar=']])
const result = parseCookieString(mapToCookieString(input))
expect(result).toEqual(input)
})
it('with multiple plain values', async () => {
const input = new Map([
['foo', 'bar'],
['baz', 'qux'],
])
const result = parseCookieString(mapToCookieString(input))
expect(result).toEqual(input)
})
it('with multiple values with `=`', async () => {
const input = new Map([
['foo', 'bar=='],
['baz', '=qux'],
])
const result = parseCookieString(mapToCookieString(input))
expect(result).toEqual(input)
})
})
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment