Unverified Commit 9dae7a89 authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Enable ReactRefreshLogBox-builtins.test.ts, remove loader from import trace (#41645)

parent b6cfeebf
...@@ -85,7 +85,7 @@ export async function getNotFoundError( ...@@ -85,7 +85,7 @@ export async function getNotFoundError(
.filter( .filter(
(name) => (name) =>
name && name &&
!/next-(middleware|client-pages|flight-(client|server))-loader\.js/.test( !/next-(middleware|client-pages|flight-(client|server|client-entry))-loader\.js/.test(
name name
) )
) )
......
...@@ -15,6 +15,10 @@ describe('ReactRefresh app', () => { ...@@ -15,6 +15,10 @@ describe('ReactRefresh app', () => {
beforeAll(async () => { beforeAll(async () => {
next = await createNext({ next = await createNext({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')), files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
},
skipStart: true, skipStart: true,
}) })
}) })
......
...@@ -4,7 +4,7 @@ import { NextInstance } from 'test/lib/next-modes/base' ...@@ -4,7 +4,7 @@ import { NextInstance } from 'test/lib/next-modes/base'
import path from 'path' import path from 'path'
// TODO-APP: Investigate snapshot mismatch // TODO-APP: Investigate snapshot mismatch
describe.skip('ReactRefreshLogBox app', () => { describe('ReactRefreshLogBox app', () => {
if (process.env.NEXT_TEST_REACT_VERSION === '^17') { if (process.env.NEXT_TEST_REACT_VERSION === '^17') {
it('should skip for react v17', () => {}) it('should skip for react v17', () => {})
return return
...@@ -15,6 +15,10 @@ describe.skip('ReactRefreshLogBox app', () => { ...@@ -15,6 +15,10 @@ describe.skip('ReactRefreshLogBox app', () => {
beforeAll(async () => { beforeAll(async () => {
next = await createNext({ next = await createNext({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')), files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
},
skipStart: true, skipStart: true,
}) })
}) })
...@@ -109,7 +113,7 @@ describe.skip('ReactRefreshLogBox app', () => { ...@@ -109,7 +113,7 @@ describe.skip('ReactRefreshLogBox app', () => {
await cleanup() await cleanup()
}) })
test('Module not found (missing global CSS)', async () => { test('Module not found missing global CSS', async () => {
const { session, cleanup } = await sandbox( const { session, cleanup } = await sandbox(
next, next,
new Map([ new Map([
......
...@@ -20,6 +20,8 @@ describe.skip('ReactRefreshLogBox app', () => { ...@@ -20,6 +20,8 @@ describe.skip('ReactRefreshLogBox app', () => {
skipStart: true, skipStart: true,
dependencies: { dependencies: {
sass: 'latest', sass: 'latest',
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
}, },
}) })
}) })
......
...@@ -16,6 +16,10 @@ describe('ReactRefreshLogBox app', () => { ...@@ -16,6 +16,10 @@ describe('ReactRefreshLogBox app', () => {
beforeAll(async () => { beforeAll(async () => {
next = await createNext({ next = await createNext({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')), files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
},
skipStart: true, skipStart: true,
}) })
}) })
......
...@@ -16,6 +16,10 @@ describe.skip('ReactRefreshLogBox app', () => { ...@@ -16,6 +16,10 @@ describe.skip('ReactRefreshLogBox app', () => {
beforeAll(async () => { beforeAll(async () => {
next = await createNext({ next = await createNext({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')), files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
},
skipStart: true, skipStart: true,
}) })
}) })
......
...@@ -14,6 +14,10 @@ describe('ReactRefreshModule app', () => { ...@@ -14,6 +14,10 @@ describe('ReactRefreshModule app', () => {
beforeAll(async () => { beforeAll(async () => {
next = await createNext({ next = await createNext({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')), files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
},
skipStart: true, skipStart: true,
}) })
}) })
......
...@@ -20,6 +20,8 @@ describe('ReactRefreshRegression app', () => { ...@@ -20,6 +20,8 @@ describe('ReactRefreshRegression app', () => {
'styled-components': '5.1.0', 'styled-components': '5.1.0',
'@next/mdx': 'canary', '@next/mdx': 'canary',
'@mdx-js/loader': '0.18.0', '@mdx-js/loader': '0.18.0',
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
}, },
}) })
}) })
......
...@@ -10,6 +10,10 @@ describe('ReactRefreshRequire app', () => { ...@@ -10,6 +10,10 @@ describe('ReactRefreshRequire app', () => {
beforeAll(async () => { beforeAll(async () => {
next = await createNext({ next = await createNext({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')), files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
},
skipStart: true, skipStart: true,
}) })
}) })
......
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`ReactRefreshLogBox app Module not found 1`] = `
"./index.js:1:0
Module not found: Can't resolve 'b'
> 1 | import Comp from 'b'
2 | export default function Oops() {
3 | return (
4 | <div>
Import trace for requested module:
./app/page.js
https://nextjs.org/docs/messages/module-not-found"
`;
exports[`ReactRefreshLogBox app Module not found empty import trace 1`] = `
"./app/page.js:2:6
Module not found: Can't resolve 'b'
1 | 'use client'
> 2 | import Comp from 'b'
| ^
3 | export default function Oops() {
4 | return (
5 | <div>
https://nextjs.org/docs/messages/module-not-found"
`;
exports[`ReactRefreshLogBox app Module not found missing global CSS 1`] = `
"./app/page.js:2:10
Module not found: Can't resolve './non-existent.css'
1 | 'use client'
> 2 | import './non-existent.css'
| ^
3 | export default function Page(props) {
4 | return <p>index page</p>
5 | }
https://nextjs.org/docs/messages/module-not-found"
`;
exports[`ReactRefreshLogBox app Node.js builtins 1`] = `
"./node_modules/my-package/index.js:2:0
Module not found: Can't resolve 'dns'
Import trace for requested module:
./index.js
./app/page.js
https://nextjs.org/docs/messages/module-not-found"
`;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment