Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
N
next.js
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Alex
next.js
Commits
9dae7a89
Unverified
Commit
9dae7a89
authored
Oct 22, 2022
by
Tim Neutkens
Committed by
GitHub
Oct 22, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable ReactRefreshLogBox-builtins.test.ts, remove loader from import trace (#41645)
parent
b6cfeebf
Show whitespace changes
Inline
Side-by-side
Showing
10 changed files
with
83 additions
and
3 deletions
+83
-3
parseNotFoundError.ts
...ack/plugins/wellknown-errors-plugin/parseNotFoundError.ts
+1
-1
ReactRefresh.test.ts
test/development/acceptance-app/ReactRefresh.test.ts
+4
-0
ReactRefreshLogBox-builtins.test.ts
...opment/acceptance-app/ReactRefreshLogBox-builtins.test.ts
+6
-2
ReactRefreshLogBox-scss.test.ts
...evelopment/acceptance-app/ReactRefreshLogBox-scss.test.ts
+2
-0
ReactRefreshLogBox.test.ts
test/development/acceptance-app/ReactRefreshLogBox.test.ts
+4
-0
ReactRefreshLogBoxMisc.test.ts
...development/acceptance-app/ReactRefreshLogBoxMisc.test.ts
+4
-0
ReactRefreshModule.test.ts
test/development/acceptance-app/ReactRefreshModule.test.ts
+4
-0
ReactRefreshRegression.test.ts
...development/acceptance-app/ReactRefreshRegression.test.ts
+2
-0
ReactRefreshRequire.test.ts
test/development/acceptance-app/ReactRefreshRequire.test.ts
+4
-0
ReactRefreshLogBox-builtins.test.ts.snap
...pp/__snapshots__/ReactRefreshLogBox-builtins.test.ts.snap
+52
-0
No files found.
packages/next/build/webpack/plugins/wellknown-errors-plugin/parseNotFoundError.ts
View file @
9dae7a89
...
@@ -85,7 +85,7 @@ export async function getNotFoundError(
...
@@ -85,7 +85,7 @@ export async function getNotFoundError(
.
filter
(
.
filter
(
(
name
)
=>
(
name
)
=>
name
&&
name
&&
!
/next-
(
middleware|client-pages|flight-
(
client|server
))
-loader
\.
js/
.
test
(
!
/next-
(
middleware|client-pages|flight-
(
client|server
|client-entry
))
-loader
\.
js/
.
test
(
name
name
)
)
)
)
...
...
test/development/acceptance-app/ReactRefresh.test.ts
View file @
9dae7a89
...
@@ -15,6 +15,10 @@ describe('ReactRefresh app', () => {
...
@@ -15,6 +15,10 @@ describe('ReactRefresh app', () => {
beforeAll
(
async
()
=>
{
beforeAll
(
async
()
=>
{
next
=
await
createNext
({
next
=
await
createNext
({
files
:
new
FileRef
(
path
.
join
(
__dirname
,
'fixtures'
,
'default-template'
)),
files
:
new
FileRef
(
path
.
join
(
__dirname
,
'fixtures'
,
'default-template'
)),
dependencies
:
{
react
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
'react-dom'
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
},
skipStart
:
true
,
skipStart
:
true
,
})
})
})
})
...
...
test/development/acceptance-app/ReactRefreshLogBox-builtins.test.ts
View file @
9dae7a89
...
@@ -4,7 +4,7 @@ import { NextInstance } from 'test/lib/next-modes/base'
...
@@ -4,7 +4,7 @@ import { NextInstance } from 'test/lib/next-modes/base'
import
path
from
'path'
import
path
from
'path'
// TODO-APP: Investigate snapshot mismatch
// TODO-APP: Investigate snapshot mismatch
describe
.
skip
(
'ReactRefreshLogBox app'
,
()
=>
{
describe
(
'ReactRefreshLogBox app'
,
()
=>
{
if
(
process
.
env
.
NEXT_TEST_REACT_VERSION
===
'^17'
)
{
if
(
process
.
env
.
NEXT_TEST_REACT_VERSION
===
'^17'
)
{
it
(
'should skip for react v17'
,
()
=>
{})
it
(
'should skip for react v17'
,
()
=>
{})
return
return
...
@@ -15,6 +15,10 @@ describe.skip('ReactRefreshLogBox app', () => {
...
@@ -15,6 +15,10 @@ describe.skip('ReactRefreshLogBox app', () => {
beforeAll
(
async
()
=>
{
beforeAll
(
async
()
=>
{
next
=
await
createNext
({
next
=
await
createNext
({
files
:
new
FileRef
(
path
.
join
(
__dirname
,
'fixtures'
,
'default-template'
)),
files
:
new
FileRef
(
path
.
join
(
__dirname
,
'fixtures'
,
'default-template'
)),
dependencies
:
{
react
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
'react-dom'
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
},
skipStart
:
true
,
skipStart
:
true
,
})
})
})
})
...
@@ -109,7 +113,7 @@ describe.skip('ReactRefreshLogBox app', () => {
...
@@ -109,7 +113,7 @@ describe.skip('ReactRefreshLogBox app', () => {
await
cleanup
()
await
cleanup
()
})
})
test
(
'Module not found
(missing global CSS)
'
,
async
()
=>
{
test
(
'Module not found
missing global CSS
'
,
async
()
=>
{
const
{
session
,
cleanup
}
=
await
sandbox
(
const
{
session
,
cleanup
}
=
await
sandbox
(
next
,
next
,
new
Map
([
new
Map
([
...
...
test/development/acceptance-app/ReactRefreshLogBox-scss.test.ts
View file @
9dae7a89
...
@@ -20,6 +20,8 @@ describe.skip('ReactRefreshLogBox app', () => {
...
@@ -20,6 +20,8 @@ describe.skip('ReactRefreshLogBox app', () => {
skipStart
:
true
,
skipStart
:
true
,
dependencies
:
{
dependencies
:
{
sass
:
'latest'
,
sass
:
'latest'
,
react
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
'react-dom'
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
},
},
})
})
})
})
...
...
test/development/acceptance-app/ReactRefreshLogBox.test.ts
View file @
9dae7a89
...
@@ -16,6 +16,10 @@ describe('ReactRefreshLogBox app', () => {
...
@@ -16,6 +16,10 @@ describe('ReactRefreshLogBox app', () => {
beforeAll
(
async
()
=>
{
beforeAll
(
async
()
=>
{
next
=
await
createNext
({
next
=
await
createNext
({
files
:
new
FileRef
(
path
.
join
(
__dirname
,
'fixtures'
,
'default-template'
)),
files
:
new
FileRef
(
path
.
join
(
__dirname
,
'fixtures'
,
'default-template'
)),
dependencies
:
{
react
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
'react-dom'
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
},
skipStart
:
true
,
skipStart
:
true
,
})
})
})
})
...
...
test/development/acceptance-app/ReactRefreshLogBoxMisc.test.ts
View file @
9dae7a89
...
@@ -16,6 +16,10 @@ describe.skip('ReactRefreshLogBox app', () => {
...
@@ -16,6 +16,10 @@ describe.skip('ReactRefreshLogBox app', () => {
beforeAll
(
async
()
=>
{
beforeAll
(
async
()
=>
{
next
=
await
createNext
({
next
=
await
createNext
({
files
:
new
FileRef
(
path
.
join
(
__dirname
,
'fixtures'
,
'default-template'
)),
files
:
new
FileRef
(
path
.
join
(
__dirname
,
'fixtures'
,
'default-template'
)),
dependencies
:
{
react
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
'react-dom'
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
},
skipStart
:
true
,
skipStart
:
true
,
})
})
})
})
...
...
test/development/acceptance-app/ReactRefreshModule.test.ts
View file @
9dae7a89
...
@@ -14,6 +14,10 @@ describe('ReactRefreshModule app', () => {
...
@@ -14,6 +14,10 @@ describe('ReactRefreshModule app', () => {
beforeAll
(
async
()
=>
{
beforeAll
(
async
()
=>
{
next
=
await
createNext
({
next
=
await
createNext
({
files
:
new
FileRef
(
path
.
join
(
__dirname
,
'fixtures'
,
'default-template'
)),
files
:
new
FileRef
(
path
.
join
(
__dirname
,
'fixtures'
,
'default-template'
)),
dependencies
:
{
react
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
'react-dom'
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
},
skipStart
:
true
,
skipStart
:
true
,
})
})
})
})
...
...
test/development/acceptance-app/ReactRefreshRegression.test.ts
View file @
9dae7a89
...
@@ -20,6 +20,8 @@ describe('ReactRefreshRegression app', () => {
...
@@ -20,6 +20,8 @@ describe('ReactRefreshRegression app', () => {
'styled-components'
:
'5.1.0'
,
'styled-components'
:
'5.1.0'
,
'@next/mdx'
:
'canary'
,
'@next/mdx'
:
'canary'
,
'@mdx-js/loader'
:
'0.18.0'
,
'@mdx-js/loader'
:
'0.18.0'
,
react
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
'react-dom'
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
},
},
})
})
})
})
...
...
test/development/acceptance-app/ReactRefreshRequire.test.ts
View file @
9dae7a89
...
@@ -10,6 +10,10 @@ describe('ReactRefreshRequire app', () => {
...
@@ -10,6 +10,10 @@ describe('ReactRefreshRequire app', () => {
beforeAll
(
async
()
=>
{
beforeAll
(
async
()
=>
{
next
=
await
createNext
({
next
=
await
createNext
({
files
:
new
FileRef
(
path
.
join
(
__dirname
,
'fixtures'
,
'default-template'
)),
files
:
new
FileRef
(
path
.
join
(
__dirname
,
'fixtures'
,
'default-template'
)),
dependencies
:
{
react
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
'react-dom'
:
'0.0.0-experimental-9cdf8a99e-20221018'
,
},
skipStart
:
true
,
skipStart
:
true
,
})
})
})
})
...
...
test/development/acceptance-app/__snapshots__/ReactRefreshLogBox-builtins.test.ts.snap
0 → 100644
View file @
9dae7a89
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`ReactRefreshLogBox app Module not found 1`] = `
"./index.js:1:0
Module not found: Can't resolve 'b'
> 1 | import Comp from 'b'
2 | export default function Oops() {
3 | return (
4 | <div>
Import trace for requested module:
./app/page.js
https://nextjs.org/docs/messages/module-not-found"
`;
exports[`ReactRefreshLogBox app Module not found empty import trace 1`] = `
"./app/page.js:2:6
Module not found: Can't resolve 'b'
1 | 'use client'
> 2 | import Comp from 'b'
| ^
3 | export default function Oops() {
4 | return (
5 | <div>
https://nextjs.org/docs/messages/module-not-found"
`;
exports[`ReactRefreshLogBox app Module not found missing global CSS 1`] = `
"./app/page.js:2:10
Module not found: Can't resolve './non-existent.css'
1 | 'use client'
> 2 | import './non-existent.css'
| ^
3 | export default function Page(props) {
4 | return <p>index page</p>
5 | }
https://nextjs.org/docs/messages/module-not-found"
`;
exports[`ReactRefreshLogBox app Node.js builtins 1`] = `
"./node_modules/my-package/index.js:2:0
Module not found: Can't resolve 'dns'
Import trace for requested module:
./index.js
./app/page.js
https://nextjs.org/docs/messages/module-not-found"
`;
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment