Unverified Commit 9e1cc736 authored by Niklas Mischkulnig's avatar Niklas Mischkulnig Committed by GitHub

test: extend production-browser-sourcemaps test (#89945)

To test the change in  https://github.com/vercel/next.js/pull/89915
parent 0a2bdd7f
export default function Root({ children }) {
return (
<html>
<head></head>
<body>{children}</body>
</html>
)
}
export default function page() {
return <div>hello</div>
}
...@@ -4,24 +4,51 @@ import { getBuildManifest } from 'next-test-utils' ...@@ -4,24 +4,51 @@ import { getBuildManifest } from 'next-test-utils'
import { recursiveReadDir } from 'next/dist/lib/recursive-readdir' import { recursiveReadDir } from 'next/dist/lib/recursive-readdir'
import { nextTestSetup } from 'e2e-utils' import { nextTestSetup } from 'e2e-utils'
function extractSourceMappingURL(jsContent): string | null { function extractSourceMappingURL(jsContent: string): string | null {
// Matches both //# and //@ sourceMappingURL=... // Matches both //# and //@ sourceMappingURL=...
const match = jsContent.match(/\/\/[#@] sourceMappingURL=([^\s]+)/) const match = jsContent.match(/\/\/[#@] sourceMappingURL=([^\s]+)/)
return match ? match[1] : null return match ? match[1] : null
} }
async function sourceMapExistsForFile(jsFilePath) { async function validateSourceMapForChunk(
dir: string,
file: string,
{
polyfillFiles,
productionBrowserSourceMaps,
}: { polyfillFiles: Set<string>; productionBrowserSourceMaps: boolean }
) {
const jsFilePath = path.join(dir, file)
const jsContent = await fs.readFile(jsFilePath, 'utf8') const jsContent = await fs.readFile(jsFilePath, 'utf8')
const sourceMappingURL = extractSourceMappingURL(jsContent) const sourceMappingURL = extractSourceMappingURL(jsContent)
if (!sourceMappingURL) { if (!sourceMappingURL) {
if (/^__turbopack_load_page_chunks__\(["']/.test(jsContent)) { if (
/^__turbopack_load_page_chunks__\(["']/.test(jsContent) ||
(!process.env.IS_TURBOPACK_TEST && jsContent.length < 300)
) {
// There is no sourcemap in these loader chunks, ignore // There is no sourcemap in these loader chunks, ignore
return undefined return
} }
return false if (await fs.pathExists(jsFilePath + '.map')) {
// sourcemap file exists, but without sourceMappingURL comment
// currently the case for polyfills chunk
if (!productionBrowserSourceMaps) {
throw new Error(`Source map file exists for ${jsFilePath}.`)
}
}
if (polyfillFiles.has(file)) {
// polyfill files might not have sourcemaps, ignore
return
}
if (productionBrowserSourceMaps) {
throw new Error(`Source map missing for ${jsFilePath}.`)
}
return
} }
const mapPath = path.join(path.dirname(jsFilePath), sourceMappingURL) const mapPath = path.join(path.dirname(jsFilePath), sourceMappingURL)
return await fs.pathExists(mapPath) if ((await fs.pathExists(mapPath)) !== productionBrowserSourceMaps) {
throw new Error(`Source map presence mismatch for ${jsFilePath}.`)
}
} }
describe('Production browser sourcemaps', () => { describe('Production browser sourcemaps', () => {
...@@ -43,32 +70,34 @@ describe('Production browser sourcemaps', () => { ...@@ -43,32 +70,34 @@ describe('Production browser sourcemaps', () => {
it('check sourcemaps for all browser files', async () => { it('check sourcemaps for all browser files', async () => {
const buildManifest = getBuildManifest(next.testDir) const buildManifest = getBuildManifest(next.testDir)
// These currently don't have sourcemaps let polyfillFiles = new Set<string>(
let polyfillFiles = new Set( buildManifest.polyfillFiles.map(
buildManifest.polyfillFiles.map((f) => '/' + path.basename(f)) (f: string) => '/' + path.relative(path.join('static', 'chunks'), f)
)
) )
const staticDir = path.join(next.testDir, '.next', 'static', 'chunks') const staticDir = path.join(next.testDir, '.next', 'static', 'chunks')
const browserFiles = await recursiveReadDir(staticDir) const browserFiles = await recursiveReadDir(staticDir)
const jsFiles = browserFiles.filter( const jsFiles = browserFiles.filter((file) => file.endsWith('.js'))
(file) => file.endsWith('.js') && !polyfillFiles.has(file)
)
expect(jsFiles).not.toBeEmpty() expect(jsFiles).not.toBeEmpty()
for (const file of jsFiles) { for (const file of jsFiles) {
const jsPath = path.join(staticDir, file) await validateSourceMapForChunk(staticDir, file, {
expect(await sourceMapExistsForFile(jsPath)).toBeOneOf([ polyfillFiles,
productionBrowserSourceMaps, productionBrowserSourceMaps,
undefined, })
])
} }
for (let page of ['/ssr', '/static']) { for (let page of ['/ssr', '/static']) {
const jsFiles = buildManifest.pages[page] const jsFiles = buildManifest.pages[page]
for (const file of jsFiles) { for (const file of jsFiles) {
const jsPath = path.join(next.testDir, '.next', file) await validateSourceMapForChunk(
expect(await sourceMapExistsForFile(jsPath)).toBe( path.join(next.testDir, '.next'),
productionBrowserSourceMaps file,
{
polyfillFiles,
productionBrowserSourceMaps,
}
) )
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment