Unverified Commit a0aaa933 authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Apply sideEffect at DidMount on the client side (#5068)

Fixes #5038

The problem with `constructor` is that it doesn't have `context` yet when being called. It's also considered unsafe to add a side-effect on constructor except when server-rendering
parent 33067a58
...@@ -58,10 +58,15 @@ export default function withSideEffect (reduceComponentsToState, handleStateChan ...@@ -58,10 +58,15 @@ export default function withSideEffect (reduceComponentsToState, handleStateChan
constructor (props) { constructor (props) {
super(props) super(props)
if (!SideEffect.canUseDOM) {
mountedInstances.add(this)
emitChange(this)
}
}
componentDidMount () {
mountedInstances.add(this) mountedInstances.add(this)
emitChange(this) emitChange(this)
} }
componentDidUpdate () { componentDidUpdate () {
emitChange(this) emitChange(this)
} }
......
import dynamic from 'next/dynamic'
import Head from 'next/head'
const Test = dynamic({
loader: async () => {
// component
return () => {
return <div className='dynamic-style'>
<Head>
<style dangerouslySetInnerHTML={{ __html: `
.dynamic-style {
background-color: green;
height: 200px;
}
`}} />
</Head>
test
</div>
}
},
ssr: false
})
export default Test
...@@ -27,6 +27,22 @@ export default (context, render) => { ...@@ -27,6 +27,22 @@ export default (context, render) => {
} }
} }
}) })
it('should render the component Head content', async () => {
let browser
try {
browser = await webdriver(context.appPort, '/dynamic/head')
await check(() => browser.elementByCss('body').text(), /test/)
const backgroundColor = await browser.elementByCss('.dynamic-style').getComputedCss('background-color')
const height = await browser.elementByCss('.dynamic-style').getComputedCss('height')
expect(height).toBe('200px')
expect(backgroundColor).toBe('rgba(0, 128, 0, 1)')
} finally {
if (browser) {
browser.close()
}
}
})
}) })
describe('ssr:false option', () => { describe('ssr:false option', () => {
it('Should render loading on the server side', async () => { it('Should render loading on the server side', async () => {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment