Unverified Commit a0edc92b authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Optimize trace span relationships (#49697)

## What?

- Ensures `add-entry` falls under `make`
- Ensures the rootmost module falls under `add-entry`, which is the
entry that caused the module to be compiled
- Ensures `seal` related spans have the `seal` span as parent
- Adds some additional spans under `seal`.

### Before

<img width="455" alt="CleanShot 2023-05-12 at 12 30 43@2x"
src="https://github.com/vercel/next.js/assets/6324199/2c79fa0c-e22f-43bf-a2fe-dae67629b712">

### After

<img width="304" alt="CleanShot 2023-05-12 at 12 30 06@2x"
src="https://github.com/vercel/next.js/assets/6324199/3918dc89-2bc0-4f11-a646-553fe1f0fbf4">


<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation or adding/fixing Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md



## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
parent 684abdc5
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
"version": "0.2.0", "version": "0.2.0",
"configurations": [ "configurations": [
{ {
"name": "Launch app-dir development", "name": "Launch test/e2e/app-dir/app development",
"type": "node", "type": "node",
"request": "launch", "request": "launch",
"cwd": "${workspaceFolder}", "cwd": "${workspaceFolder}",
...@@ -17,7 +17,7 @@ ...@@ -17,7 +17,7 @@
} }
}, },
{ {
"name": "Launch app-dir build", "name": "Launch test/e2e/app-dir/app build",
"type": "node", "type": "node",
"request": "launch", "request": "launch",
"cwd": "${workspaceFolder}", "cwd": "${workspaceFolder}",
...@@ -29,7 +29,7 @@ ...@@ -29,7 +29,7 @@
} }
}, },
{ {
"name": "Launch app development", "name": "Launch examples/hello-world development",
"type": "node", "type": "node",
"request": "launch", "request": "launch",
"cwd": "${workspaceFolder}", "cwd": "${workspaceFolder}",
...@@ -41,7 +41,7 @@ ...@@ -41,7 +41,7 @@
} }
}, },
{ {
"name": "Launch app build", "name": "Launch examples/hello-world build",
"type": "node", "type": "node",
"request": "launch", "request": "launch",
"cwd": "${workspaceFolder}", "cwd": "${workspaceFolder}",
...@@ -53,7 +53,7 @@ ...@@ -53,7 +53,7 @@
} }
}, },
{ {
"name": "Launch app production", "name": "Launch examples/hello-world production",
"type": "node", "type": "node",
"request": "launch", "request": "launch",
"cwd": "${workspaceFolder}", "cwd": "${workspaceFolder}",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment