Unverified Commit a45bf8c9 authored by Alexis Rico's avatar Alexis Rico Committed by GitHub

Fix deploy button in with-xata example (#43608)

The deploy button of the `with-xata` example is not working properly
because we were lacking the integration to configure the env variables.

[![Deploy with
Vercel](https://vercel.com/button)](https://vercel.com/new/git/external?repository-url=https://github.com/SferaDev/nextjs-demo/tree/fix-with-xata-deploy/examples/with-xata&project-name=with-xata&repository-name=with-xata&integration-ids=oac_IDpMECDuYqBvAtu3wXXMQe0J)

Taking advantage of the PR, some other changes:

- Adding `alt` to `next/image` to fix build with latest version
- Update readme to add more information in the Xata CLI section
- Use a new command to initialize the database schema on first
deployment
- Remove hardcoded URL in `xata.codegen.ts`
- Remove deprecated `formatVersion` in `schema.template.json`
- Update dependencies

Note: The integration is still work in progress, it works for the
`Deploy to Vercel` button but we want to improve the UI/UX before
submitting it to the Marketplace, keeping it unlisted for a while.
parent 07d52ce7
...@@ -14,7 +14,7 @@ With this template you get out-of-the-box: ...@@ -14,7 +14,7 @@ With this template you get out-of-the-box:
Deploy the example using [Vercel](https://vercel.com?utm_source=github&utm_medium=readme&utm_campaign=next-example) or preview live with [StackBlitz](https://stackblitz.com/github/vercel/next.js/tree/canary/examples/with-xata) Deploy the example using [Vercel](https://vercel.com?utm_source=github&utm_medium=readme&utm_campaign=next-example) or preview live with [StackBlitz](https://stackblitz.com/github/vercel/next.js/tree/canary/examples/with-xata)
[![Deploy with Vercel](https://vercel.com/button)](https://vercel.com/new/git/external?repository-url=https://github.com/vercel/next.js/tree/canary/examples/with-xata&project-name=with-xata&repository-name=with-xata) [![Deploy with Vercel](https://vercel.com/button)](https://vercel.com/new/git/external?repository-url=https://github.com/vercel/next.js/tree/canary/examples/with-xata&project-name=with-xata&repository-name=with-xata&integration-ids=oac_IDpMECDuYqBvAtu3wXXMQe0J)
## Demo ## Demo
...@@ -36,15 +36,21 @@ yarn create next-app --example with-xata with-xata-app ...@@ -36,15 +36,21 @@ yarn create next-app --example with-xata with-xata-app
pnpm create next-app --example with-xata with-xata-app pnpm create next-app --example with-xata with-xata-app
``` ```
### Link Your Xata Workspace and Run Codegen ### Link With Your Xata Workspace And Update Types
> 💡 consider [installing the Xata CLI globally](https://xata.io/docs/cli/getting-started), it will likely improve your experience managing your databases > 💡 We recommend installing the [Xata CLI](https://xata.io/docs/cli/getting-started) globally, but you can also use `npx @xata.io/cli` instead of `xata` in the commands below.
You can link your project with a Xata workspace by running the following command:
```sh ```sh
npm run start:xata xata init
``` ```
> ⚠️ once linked, you can just run `xata` to re-generate types. To update your types, run the following command:
```sh
xata codegen
```
### Start Coding ### Start Coding
......
...@@ -4,21 +4,19 @@ ...@@ -4,21 +4,19 @@
"dev": "next dev", "dev": "next dev",
"build": "next build", "build": "next build",
"start": "next start", "start": "next start",
"start:xata": "xata init --schema=schema.template.json --codegen=utils/xata.codegen.ts", "xata": "xata codegen",
"poststart:xata": "xata codegen", "postinstall": "npx @xata.io/cli@latest schema upload schema.template.json --branch main --create-only --yes"
"xata": "xata codegen"
}, },
"devDependencies": { "devDependencies": {
"@types/node": "18.6.5", "@types/node": "18.11.10",
"@types/react": "18.0.17", "@types/react": "18.0.25",
"@types/react-dom": "18.0.6", "@types/react-dom": "18.0.9",
"@xata.io/cli": "0.8.1", "eslint": "8.28.0",
"eslint": "8.21.0",
"eslint-config-next": "latest", "eslint-config-next": "latest",
"typescript": "4.7.4" "typescript": "4.9.3"
}, },
"dependencies": { "dependencies": {
"@xata.io/client": "^0.16.1", "@xata.io/client": "^0.21.3",
"next": "latest", "next": "latest",
"react": "^18.2.0", "react": "^18.2.0",
"react-dom": "^18.2.0" "react-dom": "^18.2.0"
......
...@@ -31,7 +31,7 @@ export default function IndexPage({ ...@@ -31,7 +31,7 @@ export default function IndexPage({
return ( return (
<main> <main>
<header> <header>
<Image src={xatafly} priority /> <Image src={xatafly} alt={'Xata'} priority />
<h1> <h1>
Next.js with<span aria-hidden>&#8209;</span>xata Next.js with<span aria-hidden>&#8209;</span>xata
</h1> </h1>
......
{ {
"formatVersion": "",
"tables": [ "tables": [
{ {
"name": "nextjs_with_xata_example", "name": "nextjs_with_xata_example",
......
...@@ -24,9 +24,7 @@ export type NextjsWithXataExampleRecord = NextjsWithXataExample & XataRecord ...@@ -24,9 +24,7 @@ export type NextjsWithXataExampleRecord = NextjsWithXataExample & XataRecord
const DatabaseClient = buildClient() const DatabaseClient = buildClient()
const defaultOptions = { const defaultOptions = {}
databaseURL: 'https://xata-uq2d57.xata.sh/db/examples',
}
export class XataClient extends DatabaseClient<SchemaTables> { export class XataClient extends DatabaseClient<SchemaTables> {
constructor(options?: BaseClientOptions) { constructor(options?: BaseClientOptions) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment