Unverified Commit a7793c7a authored by Stoyan Delev's avatar Stoyan Delev Committed by GitHub

fix eslint link-passhref rule (#33857)

parent 3e60c232
...@@ -23,7 +23,7 @@ module.exports = { ...@@ -23,7 +23,7 @@ module.exports = {
}, },
JSXOpeningElement(node) { JSXOpeningElement(node) {
if (node.name.name !== 'Link' || node.name.name !== linkImport) { if (node.name.name !== linkImport) {
return return
} }
......
...@@ -14,17 +14,23 @@ const ruleTester = new RuleTester() ...@@ -14,17 +14,23 @@ const ruleTester = new RuleTester()
ruleTester.run('link-passhref', rule, { ruleTester.run('link-passhref', rule, {
valid: [ valid: [
`export const Home = () => ( `
import Link from 'next/link'
export const Home = () => (
<Link href="/test"></Link> <Link href="/test"></Link>
)`, )`,
`export const Home = () => ( `
import Link from 'next/link'
export const Home = () => (
<Link href="/test"> <Link href="/test">
<a>Test</a> <a>Test</a>
</Link> </Link>
)`, )`,
`export const Home = () => ( `
import Link from 'next/link'
export const Home = () => (
<Link href="/test" passHref> <Link href="/test" passHref>
<StyledLink>Test</StyledLink> <StyledLink>Test</StyledLink>
</Link> </Link>
...@@ -37,6 +43,14 @@ ruleTester.run('link-passhref', rule, { ...@@ -37,6 +43,14 @@ ruleTester.run('link-passhref', rule, {
<MyButton /> <MyButton />
</Link> </Link>
)`, )`,
`
import NextLink from 'next/link'
export const Home = () => (
<NextLink href="/test" passHref>
<StyledLink>Test</StyledLink>
</NextLink>
)`,
], ],
invalid: [ invalid: [
...@@ -57,6 +71,23 @@ ruleTester.run('link-passhref', rule, { ...@@ -57,6 +71,23 @@ ruleTester.run('link-passhref', rule, {
}, },
], ],
}, },
{
code: `
import NextLink from 'next/link'
export const Home = () => (
<NextLink href="/test">
<StyledLink>Test</StyledLink>
</NextLink>
)`,
errors: [
{
message:
'passHref is missing. See: https://nextjs.org/docs/messages/link-passhref',
type: 'JSXOpeningElement',
},
],
},
{ {
code: ` code: `
import Link from 'next/link' import Link from 'next/link'
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment