Unverified Commit a7932cbb authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Add trace span for module readFile (#29759)

parent 2e2c558a
...@@ -10,11 +10,6 @@ const moduleSpansByCompilation = new WeakMap< ...@@ -10,11 +10,6 @@ const moduleSpansByCompilation = new WeakMap<
>() >()
export const webpackInvalidSpans = new WeakMap<any, Span>() export const webpackInvalidSpans = new WeakMap<any, Span>()
function getNormalModuleLoaderHook(compilation: any) {
// @ts-ignore TODO: Remove ignore when webpack 5 is stable
return NormalModule.getCompilationHooks(compilation).loader
}
export class ProfilingPlugin { export class ProfilingPlugin {
compiler: any compiler: any
runWebpackSpan: Span runWebpackSpan: Span
...@@ -146,15 +141,29 @@ export class ProfilingPlugin { ...@@ -146,15 +141,29 @@ export class ProfilingPlugin {
moduleSpans!.set(module, span) moduleSpans!.set(module, span)
}) })
getNormalModuleLoaderHook(compilation).tap( const moduleHooks = NormalModule.getCompilationHooks(compilation)
pluginName, // @ts-ignore TODO: remove ignore when using webpack 5 types
(loaderContext: any, module: any) => { moduleHooks.readResource.for(undefined).intercept({
const moduleSpan = moduleSpansByCompilation register(tapInfo: any) {
.get(compilation) const fn = tapInfo.fn
?.get(module) tapInfo.fn = (loaderContext: any, callback: any) => {
loaderContext.currentTraceSpan = moduleSpan const moduleSpan =
} loaderContext.currentTraceSpan.traceChild(`read-resource`)
) fn(loaderContext, (err: any, result: any) => {
moduleSpan.stop()
callback(err, result)
})
}
return tapInfo
},
})
moduleHooks.loader.tap(pluginName, (loaderContext: any, module: any) => {
const moduleSpan = moduleSpansByCompilation
.get(compilation)
?.get(module)
loaderContext.currentTraceSpan = moduleSpan
})
compilation.hooks.succeedModule.tap(pluginName, (module: any) => { compilation.hooks.succeedModule.tap(pluginName, (module: any) => {
moduleSpansByCompilation?.get(compilation)?.get(module)?.stop() moduleSpansByCompilation?.get(compilation)?.get(module)?.stop()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment