Unverified Commit a79bcfb7 authored by Henrik Wenz's avatar Henrik Wenz Committed by GitHub

Fix with-apollo example (#17686)

# Issue

The cache updates are performed in a wrong way, resulting in a duplicate collection:

**Error:**

```log
webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:88 Warning: Encountered two children with the same key, `6f3f7265-0d97-4708-a3ea-7dee76dc0a0a`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
```

**Video:**

![broken](https://user-images.githubusercontent.com/1265681/95336501-0c170180-08b1-11eb-9273-6ac9e37ceb41.gif)

# Fix

**Video:**

![fixed](https://user-images.githubusercontent.com/1265681/95336538-15a06980-08b1-11eb-8d5e-6acc07e16138.gif)
parent b2d1d87e
import { gql, useMutation } from '@apollo/client' import { gql, useMutation } from '@apollo/client'
import { ALL_POSTS_QUERY, allPostsQueryVars } from './PostList'
const CREATE_POST_MUTATION = gql` const CREATE_POST_MUTATION = gql`
mutation createPost($title: String!, $url: String!) { mutation createPost($title: String!, $url: String!) {
...@@ -26,19 +25,22 @@ export default function Submit() { ...@@ -26,19 +25,22 @@ export default function Submit() {
createPost({ createPost({
variables: { title, url }, variables: { title, url },
update: (proxy, { data: { createPost } }) => { update: (cache, { data: { createPost } }) => {
const data = proxy.readQuery({ cache.modify({
query: ALL_POSTS_QUERY, fields: {
variables: allPostsQueryVars, allPosts(existingPosts = []) {
}) const newPostRef = cache.writeFragment({
// Update the cache with the new post at the top of the list data: createPost,
proxy.writeQuery({ fragment: gql`
query: ALL_POSTS_QUERY, fragment NewPost on allPosts {
data: { id
...data, type
allPosts: [createPost, ...data.allPosts], }
`,
})
return [newPostRef, ...existingPosts]
},
}, },
variables: allPostsQueryVars,
}) })
}, },
}) })
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment