Unverified Commit ad27ddab authored by Janka Uryga's avatar Janka Uryga Committed by GitHub

fix: respond with 404 for unrecognized action ids (#77012)

> [!IMPORTANT]  
> view this diff with "hide whitespace changes", it's unreadable
otherwise.

This is an alternative approach to #80613. We touch a lot of same areas
but do different changes there, and i also have a bunch more changes
stacked on top, so the plan is to just revert that and do this instead.

---

server action calls with an unrecognized action id (i.e. one not found
in `serverModuleMap`) have been returning a 200 instead of a 404 for
quite some time. and also rendering the page they were called on.

### The problem

this happened due to an unfortunate mistake. `handleAction` has a
section like this:
```ts
await actionAsyncStorage.run(
  { isAction: true },
  // "the callback"
  async () => {
    ...
  }
);

return {
  type: 'done',
  result: actionResult,
  formState,
}
```

inside that callback, we have many places that validate the action id
and try to bail out if it's not recognized:

```ts
try {
  actionModId = getActionModIdOrError(actionId);
} catch (err) {
  console.error(err);
  return { type: 'not-found '}
}
```

this was clearly intended to be an early return from `handleAction`. but
it didn't work, because outside the callback we're doing
```ts
await actionAsyncStorage.run(...)
```
i.e. **discarding the callback's return value**. So instead of returning
`'not-found'` as intended, we end up falling through to the `'done'`
return right after, and returning `{ type: 'done', result: undefined,
formState: undefined }`.

then, our caller,`renderToHTMLToFlightImpl` looks at that what we
returned, and sees a 'done'

https://github.com/vercel/next.js/blob/768183c5ddbaa94c1f6004816a1fae282fa0ab04/packages/next/src/server/app-render/app-render.tsx#L1522-L1547
but because if there's no `result` or `formState`, it'll fall through
the conditionals and do the same thing it'd do if we returned
`null/undefined` (i.e. if `!actionRequestResult`). so we end up on the
rendering path, render a page, and finally respond with a 200.

### The fix, part 1

This PR fixes this. we're now directly returning the value from the
callback (`return await actionAsyncStorage.run(...)`) . i got rid of all
the weird fallthroughs and made each of the branches return something
explicitly. I've also changed `handleAction`'s return type to have a
`... | null` instead of `... | undefined` (which is interpreted as "this
was not an action request") so that it's not possible to fall off the
end of the function without an explicit return.

### The fix, part 2

To make this more complicated, returning `'not-found'` for fetch actions
was actually also incorrect! that value makes `renderToHTMLToFlightImpl`
render an HTML 404 page, which is pretty useless as a (fetch) action
response -- it's got the wrong content type! (#80613 relied on this to
make the action fail on the client-side, which isn't ideal, because the
error message doesn't indicate what the problem is).

To solve this, `handleAction` now returns a custom 404 response tagged
with a `x-nextjs-action-not-found` header (and uses `{ type: 'done' }`
instead of `{ type: 'not-found' }` to bypass the aformentioned 404
handling). Then, on the client, `fetchServerAction` checks for this
header, and throw a corresponding error. Other 404s will still throw a
`An unexpected response was received from the server.` error instead,
because they had to come from something else, like a bad proxy rewrite.
parent 91130782
...@@ -712,5 +712,6 @@ ...@@ -712,5 +712,6 @@
"711": "Can't resolve %s", "711": "Can't resolve %s",
"712": "`rspack.warnForEdgeRuntime` is not supported by the wasm bindings.", "712": "`rspack.warnForEdgeRuntime` is not supported by the wasm bindings.",
"713": "Unexpected error during process lookup", "713": "Unexpected error during process lookup",
"714": "cannot run loadNative when `NEXT_TEST_WASM` is set" "714": "cannot run loadNative when `NEXT_TEST_WASM` is set",
"715": "Server Action \"%s\" was not found on the server. \\nRead more: https://nextjs.org/docs/messages/failed-to-find-server-action"
} }
...@@ -31,3 +31,4 @@ export const NEXT_DID_POSTPONE_HEADER = 'x-nextjs-postponed' as const ...@@ -31,3 +31,4 @@ export const NEXT_DID_POSTPONE_HEADER = 'x-nextjs-postponed' as const
export const NEXT_REWRITTEN_PATH_HEADER = 'x-nextjs-rewritten-path' as const export const NEXT_REWRITTEN_PATH_HEADER = 'x-nextjs-rewritten-path' as const
export const NEXT_REWRITTEN_QUERY_HEADER = 'x-nextjs-rewritten-query' as const export const NEXT_REWRITTEN_QUERY_HEADER = 'x-nextjs-rewritten-query' as const
export const NEXT_IS_PRERENDER_HEADER = 'x-nextjs-prerender' as const export const NEXT_IS_PRERENDER_HEADER = 'x-nextjs-prerender' as const
export const NEXT_ACTION_NOT_FOUND_HEADER = 'x-nextjs-action-not-found' as const
...@@ -6,6 +6,7 @@ import { callServer } from '../../../app-call-server' ...@@ -6,6 +6,7 @@ import { callServer } from '../../../app-call-server'
import { findSourceMapURL } from '../../../app-find-source-map-url' import { findSourceMapURL } from '../../../app-find-source-map-url'
import { import {
ACTION_HEADER, ACTION_HEADER,
NEXT_ACTION_NOT_FOUND_HEADER,
NEXT_IS_PRERENDER_HEADER, NEXT_IS_PRERENDER_HEADER,
NEXT_ROUTER_STATE_TREE_HEADER, NEXT_ROUTER_STATE_TREE_HEADER,
NEXT_URL, NEXT_URL,
...@@ -62,8 +63,8 @@ import { revalidateEntireCache } from '../../segment-cache' ...@@ -62,8 +63,8 @@ import { revalidateEntireCache } from '../../segment-cache'
type FetchServerActionResult = { type FetchServerActionResult = {
redirectLocation: URL | undefined redirectLocation: URL | undefined
redirectType: RedirectType | undefined redirectType: RedirectType | undefined
actionResult?: ActionResult actionResult: ActionResult | undefined
actionFlightData?: NormalizedFlightData[] | string actionFlightData: NormalizedFlightData[] | string | undefined
isPrerender: boolean isPrerender: boolean
revalidatedParts: { revalidatedParts: {
tag: boolean tag: boolean
...@@ -110,6 +111,14 @@ async function fetchServerAction( ...@@ -110,6 +111,14 @@ async function fetchServerAction(
body, body,
}) })
// Handle server actions that the server didn't recognize.
const unrecognizedActionHeader = res.headers.get(NEXT_ACTION_NOT_FOUND_HEADER)
if (unrecognizedActionHeader === '1') {
throw new Error(
`Server Action "${actionId}" was not found on the server. \nRead more: https://nextjs.org/docs/messages/failed-to-find-server-action`
)
}
const redirectHeader = res.headers.get('x-action-redirect') const redirectHeader = res.headers.get('x-action-redirect')
const [location, _redirectType] = redirectHeader?.split(';') || [] const [location, _redirectType] = redirectHeader?.split(';') || []
let redirectType: RedirectType | undefined let redirectType: RedirectType | undefined
...@@ -136,11 +145,7 @@ async function fetchServerAction( ...@@ -136,11 +145,7 @@ async function fetchServerAction(
cookie: revalidatedHeader[2], cookie: revalidatedHeader[2],
} }
} catch (e) { } catch (e) {
revalidatedParts = { revalidatedParts = NO_REVALIDATED_PARTS
paths: [],
tag: false,
cookie: false,
}
} }
const redirectLocation = location const redirectLocation = location
...@@ -151,47 +156,43 @@ async function fetchServerAction( ...@@ -151,47 +156,43 @@ async function fetchServerAction(
: undefined : undefined
const contentType = res.headers.get('content-type') const contentType = res.headers.get('content-type')
const isRscResponse = !!(
contentType && contentType.startsWith(RSC_CONTENT_TYPE_HEADER)
)
if (contentType?.startsWith(RSC_CONTENT_TYPE_HEADER)) { // Handle invalid server action responses.
const response: ActionFlightResponse = await createFromFetch( // A valid response must have `content-type: text/x-component`, unless it's an external redirect.
Promise.resolve(res), // (external redirects have an 'x-action-redirect' header, but the body is an empty 'text/plain')
{ callServer, findSourceMapURL, temporaryReferences } if (!isRscResponse && !redirectLocation) {
)
if (location) {
// if it was a redirection, then result is just a regular RSC payload
return {
actionFlightData: normalizeFlightData(response.f),
redirectLocation,
redirectType,
revalidatedParts,
isPrerender,
}
}
return {
actionResult: response.a,
actionFlightData: normalizeFlightData(response.f),
redirectLocation,
redirectType,
revalidatedParts,
isPrerender,
}
}
// Handle invalid server action responses
if (res.status >= 400) {
// The server can respond with a text/plain error message, but we'll fallback to something generic // The server can respond with a text/plain error message, but we'll fallback to something generic
// if there isn't one. // if there isn't one.
const error = const message =
contentType === 'text/plain' res.status >= 400 && contentType === 'text/plain'
? await res.text() ? await res.text()
: 'An unexpected response was received from the server.' : 'An unexpected response was received from the server.'
throw new Error(error) throw new Error(message)
}
let actionResult: FetchServerActionResult['actionResult']
let actionFlightData: FetchServerActionResult['actionFlightData']
if (isRscResponse) {
const response: ActionFlightResponse = await createFromFetch(
Promise.resolve(res),
{ callServer, findSourceMapURL, temporaryReferences }
)
// An internal redirect can send an RSC response, but does not have a useful `actionResult`.
actionResult = redirectLocation ? undefined : response.a
actionFlightData = normalizeFlightData(response.f)
} else {
// An external redirect doesn't contain RSC data.
actionResult = undefined
actionFlightData = undefined
} }
return { return {
actionResult,
actionFlightData,
redirectLocation, redirectLocation,
redirectType, redirectType,
revalidatedParts, revalidatedParts,
...@@ -199,6 +200,12 @@ async function fetchServerAction( ...@@ -199,6 +200,12 @@ async function fetchServerAction(
} }
} }
const NO_REVALIDATED_PARTS = {
paths: [],
tag: false,
cookie: false,
}
/* /*
* This reducer is responsible for calling the server action and processing any side-effects from the server action. * This reducer is responsible for calling the server action and processing any side-effects from the server action.
* It does not mutate the state by itself but rather delegates to other reducers to do the actual mutation. * It does not mutate the state by itself but rather delegates to other reducers to do the actual mutation.
......
/* eslint-disable jest/no-standalone-expect */
import { nextTestSetup } from 'e2e-utils'
import { createRequestTracker } from 'e2e-utils/request-tracker'
import { retry } from 'next-test-utils'
import { outdent } from 'outdent'
describe('unrecognized server actions', () => {
const { next, isNextDeploy, isNextDev } = nextTestSetup({
files: __dirname,
})
let cliOutputPosition: number = 0
beforeEach(() => {
cliOutputPosition = next.cliOutput.length
})
const getLogs = () => {
return next.cliOutput.slice(cliOutputPosition)
}
// This is disabled when deployed because the 404 page will be served as a static route
// which will not support POST requests, and will return a 405 instead.
if (!isNextDeploy) {
it('should 404 when POSTing a non-server-action request to a nonexistent page', async () => {
const res = await next.fetch('/non-existent-route', {
method: 'POST',
headers: {
'content-type': 'application/x-www-form-urlencoded',
},
body: 'foo=bar',
})
const cliOutput = getLogs()
expect(cliOutput).not.toContain('TypeError')
expect(cliOutput).not.toContain(
'Missing `origin` header from a forwarded Server Actions request'
)
expect(res.status).toBe(404)
})
it.each([
{
// encodeReply encodes simple args as plaintext.
name: 'plaintext',
request: {
contentType: 'text/plain;charset=UTF-8',
body: '{}',
},
},
{
// encodeReply encodes complex args as FormData.
// this body is empty and wouldn't match how react encodes an action, but it should be rejected
// before we even get to parsing the FormData, so it doesn't really matter.
name: 'form-data/multipart',
request: {
body: new FormData(),
},
},
{
// we never use urlencoded actions, but we currently have codepaths for it in `handleAction`,
// so might as well test them.
name: 'urlencoded',
request: {
contentType: 'application/x-www-form-urlencoded',
body: 'foo=bar',
},
},
])(
'should 404 when POSTing a server action with an unrecognized id to a nonexistent page: $name',
async ({ request: { contentType, body } }) => {
const res = await next.fetch('/non-existent-route', {
method: 'POST',
headers: {
'next-action': '123',
...(contentType ? { 'content-type': contentType } : undefined),
},
// @ts-expect-error: node-fetch types don't seem to like FormData
body,
})
expect(res.status).toBe(404)
const cliOutput = getLogs()
expect(cliOutput).not.toContain('TypeError')
expect(cliOutput).not.toContain(
'Missing `origin` header from a forwarded Server Actions request'
)
expect(cliOutput).toInclude(outdent`
Failed to find Server Action "123". This request might be from an older or newer deployment.
Read more: https://nextjs.org/docs/messages/failed-to-find-server-action
`)
}
)
}
describe.each(['nodejs', 'edge'])(
'should error and log a warning when submitting a server action with an unrecognized ID - %s',
(runtime) => {
const testUnrecognizedActionSubmission = async ({
formId,
disableJavaScript,
}: {
formId: string
disableJavaScript: boolean
}) => {
const browser = await next.browser(`/${runtime}/unrecognized-action`, {
disableJavaScript,
})
const requestTracker = createRequestTracker(browser)
const [_, response] = await requestTracker.captureResponse(
async () =>
await browser
.elementByCss(`form#${formId} button[type="submit"]`)
.click(),
{
request: {
method: 'POST',
pathname: `/${runtime}/unrecognized-action`,
},
}
)
if (!disableJavaScript) {
// A fetch action, sent via the router.
expect(response.status()).toBe(404)
// NOTE: we cannot validate the response text, because playwright hangs on `response.text()` for some reason.
expect(response.headers()['content-type']).toStartWith('text/plain')
// The submission should throw and trigger our error boundary.
expect(await browser.elementByCss(`#error-boundary`).text()).toMatch(
/Error boundary: Server Action ".+?" was not found on the server\./
)
// We responded with a 404, but we shouldn't trigger a not-found (either a custom or a default one)
expect(await browser.elementByCss('body').text()).not.toContain(
'Not found'
)
expect(await browser.elementByCss('body').text()).not.toContain(
'my-not-found'
)
if (!isNextDeploy) {
await retry(async () =>
expect(getLogs()).toInclude(outdent`
Failed to find Server Action "decafc0ffeebad01". This request might be from an older or newer deployment.
Read more: https://nextjs.org/docs/messages/failed-to-find-server-action
`)
)
}
} else {
// An MPA action, sent without JS.
if (isNextDeploy) {
// FIXME: When deployed to vercel, the request is logged as a 500, but returns a 405.
// We also don't seem to display the error page correctly,
// and the response is inconsistent between nodejs and edge.
expect(response.status()).toBe(runtime === 'nodejs' ? 405 : 500)
expect(response.headers()['content-type']).toStartWith('text/html')
} else {
// FIXME: Currently, an unrecognized id in an MPA action results in a 500.
// This is not ideal, and ignores all nested `error.js` files, only showing the topmost one.
expect(response.status()).toBe(500)
expect(response.headers()['content-type']).toStartWith('text/html')
// In dev, the 500 page doesn't have any SSR'd html, so it won't show anything without JS.
if (!isNextDev) {
expect(await browser.elementByCss('body').text()).toContain(
'Internal Server Error'
)
}
if (!isNextDeploy) {
// FIXME: For an MPA action, the logs currently show the error thrown by React instead of our custom message with a link to a docs page.
await retry(async () =>
expect(getLogs()).toInclude(
`Error: Could not find the module "decafc0ffeebad01" in the React Server Manifest. This is probably a bug in the React Server Components bundler`
)
)
}
}
}
}
it.each([
{
description: 'js enabled',
disableJavaScript: false,
},
{
description: 'js disabled',
disableJavaScript: true,
},
])(
'server action invoked via form - $description',
async ({ disableJavaScript }) => {
await testUnrecognizedActionSubmission({
formId: 'form-direct',
disableJavaScript,
})
}
)
// these forms rely on client-side JS, so we can't test them with JS disabled
it.each([
{
description: 'with simple argument',
formId: 'form-simple-argument',
},
{
description: 'with complex argument',
formId: 'form-complex-argument',
},
])('server action invoked from JS - $description', async ({ formId }) => {
await testUnrecognizedActionSubmission({
formId,
disableJavaScript: false,
})
})
}
)
})
export const runtime = 'edge'
export { default } from '../../nodejs/unrecognized-action/page'
export default function RootLayout({ children }) {
return (
<html>
<head />
<body>{children}</body>
</html>
)
}
'use client'
import * as React from 'react'
import { useActionState } from 'react'
export function FormWithArg<T>({
action,
argument,
id,
children,
}: {
action: (state: string, argument: T) => Promise<string>
argument: T
id: string
children?: React.ReactNode
}) {
const [state, dispatch] = useActionState(
// don't use `bind()`, we want to explicitly avoid getting a FormData argument
// because that always results in a FormData request
(state) => action(state, argument),
'initial-state'
)
return (
<form id={id} action={dispatch}>
<button type="submit">{children}</button>
<span className="form-state">{`${state}`}</span>
</form>
)
}
export function Form({
action,
}: {
action: (state: string, formData: FormData) => Promise<string>
}) {
const [state, dispatch] = useActionState(action, 'initial-state')
return (
<form action={dispatch} id="form-direct">
<button type="submit">Submit server form</button>
<span className="form-state">{`${state}`}</span>
</form>
)
}
export class ErrorBoundary extends React.Component<{
children: React.ReactNode
}> {
state = { error: null }
static getDerivedStateFromError(error) {
return { error }
}
render() {
if (this.state.error) {
return (
<div id="error-boundary">
Error boundary: {this.state.error.message}
</div>
)
}
return this.props.children
}
}
import * as React from 'react'
import { FormWithArg, Form, ErrorBoundary } from './client'
const action = async (...args: any[]) => {
'use server'
console.log('hello from server', ...args)
return 'state-from-server'
}
// simulate client-side version skew by changing the action ID to something the server won't recognize
setServerActionId(action, 'decafc0ffeebad01')
export default function Page() {
return (
<div>
<div>
<ErrorBoundary>
<Form action={action} />
</ErrorBoundary>
</div>
<div>
<ErrorBoundary>
<FormWithArg
action={action}
id="form-simple-argument"
argument={{ foo: 'bar' }}
>
Submit client form with simple argument
</FormWithArg>
</ErrorBoundary>
</div>
<div>
<ErrorBoundary>
<FormWithArg
action={action}
id="form-complex-argument"
argument={new Map([['foo', Promise.resolve('bar')]])}
>
Submit client form with complex argument
</FormWithArg>
</ErrorBoundary>
</div>
</div>
)
}
function setServerActionId(action: (...args: any[]) => any, id: string) {
// React implementation detail: `registerServerReference(func, id)` sets `func.$$id = id`.
const actionWithMetadata = action as typeof action & { $$id?: string }
if (!actionWithMetadata.$$id) {
throw new Error(
`Expected to find server action metadata properties on ${action}`
)
}
Object.defineProperty(actionWithMetadata, '$$id', {
value: id,
configurable: true,
})
}
export default function NotFound() {
return <h1>my-not-found</h1>
}
import type { NextConfig } from 'next'
const nextConfig: NextConfig = {
productionBrowserSourceMaps: true,
experimental: {
serverSourceMaps: true,
},
}
export default nextConfig
...@@ -10,7 +10,6 @@ import { ...@@ -10,7 +10,6 @@ import {
import type { Request, Response } from 'playwright' import type { Request, Response } from 'playwright'
import fs from 'node:fs/promises' import fs from 'node:fs/promises'
import { join } from 'node:path' import { join } from 'node:path'
import { outdent } from 'outdent'
import { setTimeout } from 'node:timers/promises' import { setTimeout } from 'node:timers/promises'
const GENERIC_RSC_ERROR = const GENERIC_RSC_ERROR =
...@@ -778,51 +777,6 @@ describe('app-dir action handling', () => { ...@@ -778,51 +777,6 @@ describe('app-dir action handling', () => {
} }
}) })
// This is disabled when deployed because the 404 page will be served as a static route
// which will not support POST requests, and will return a 405 instead.
if (!isNextDeploy) {
it('should 404 when POSTing an invalid server action', async () => {
const cliOutputPosition = next.cliOutput.length
const res = await next.fetch('/non-existent-route', {
method: 'POST',
headers: {
'content-type': 'application/x-www-form-urlencoded',
},
body: 'foo=bar',
})
const cliOutput = next.cliOutput.slice(cliOutputPosition)
expect(cliOutput).not.toContain('TypeError')
expect(cliOutput).not.toContain(
'Missing `origin` header from a forwarded Server Actions request'
)
expect(res.status).toBe(404)
})
}
// This is disabled when deployed because it relies on checking runtime logs,
// and only build time logs will be available.
if (!isNextDeploy) {
it('should log a warning when a server action is not found but an id is provided', async () => {
await next.fetch('/server', {
method: 'POST',
headers: {
'content-type': 'application/x-www-form-urlencoded',
'next-action': 'abc123',
},
body: 'foo=bar',
})
await retry(async () =>
expect(next.cliOutput).toInclude(outdent`
Failed to find Server Action "abc123". This request might be from an older or newer deployment.
Read more: https://nextjs.org/docs/messages/failed-to-find-server-action
`)
)
})
}
it('should be possible to catch network errors', async () => { it('should be possible to catch network errors', async () => {
const browser = await next.browser('/catching-error', { const browser = await next.browser('/catching-error', {
beforePageLoad(page) { beforePageLoad(page) {
...@@ -1656,7 +1610,7 @@ describe('app-dir action handling', () => { ...@@ -1656,7 +1610,7 @@ describe('app-dir action handling', () => {
}) })
describe('redirects', () => { describe('redirects', () => {
it('redirects properly when server action handler uses `redirect`', async () => { it('redirects properly when route handler uses `redirect`', async () => {
const postRequests = [] const postRequests = []
const responseCodes = [] const responseCodes = []
...@@ -1685,12 +1639,12 @@ describe('app-dir action handling', () => { ...@@ -1685,12 +1639,12 @@ describe('app-dir action handling', () => {
expect(await browser.url()).toContain('success=true') expect(await browser.url()).toContain('success=true')
}) })
// verify that the POST request was only made to the action handler // verify that the POST request was only made to the route handler
expect(postRequests).toEqual(['/redirects/api-redirect']) expect(postRequests).toEqual(['/redirects/api-redirect'])
expect(responseCodes).toEqual([303]) expect(responseCodes).toEqual([303])
}) })
it('redirects properly when server action handler uses `permanentRedirect`', async () => { it('redirects properly when route handler uses `permanentRedirect`', async () => {
const postRequests = [] const postRequests = []
const responseCodes = [] const responseCodes = []
...@@ -1718,7 +1672,7 @@ describe('app-dir action handling', () => { ...@@ -1718,7 +1672,7 @@ describe('app-dir action handling', () => {
await retry(async () => { await retry(async () => {
expect(await browser.url()).toContain('success=true') expect(await browser.url()).toContain('success=true')
}) })
// verify that the POST request was only made to the action handler // verify that the POST request was only made to the route handler
expect(postRequests).toEqual(['/redirects/api-redirect-permanent']) expect(postRequests).toEqual(['/redirects/api-redirect-permanent'])
expect(responseCodes).toEqual([303]) expect(responseCodes).toEqual([303])
}) })
...@@ -1783,7 +1737,7 @@ describe('app-dir action handling', () => { ...@@ -1783,7 +1737,7 @@ describe('app-dir action handling', () => {
}) })
it.each(['307', '308'])( it.each(['307', '308'])(
`redirects properly when server action handler redirects with a %s status code`, `redirects properly when route handler redirects with a %s status code`,
async (statusCode) => { async (statusCode) => {
const postRequests = [] const postRequests = []
const responseCodes = [] const responseCodes = []
...@@ -1814,7 +1768,7 @@ describe('app-dir action handling', () => { ...@@ -1814,7 +1768,7 @@ describe('app-dir action handling', () => {
}) })
expect(await browser.elementById('redirect-page')).toBeTruthy() expect(await browser.elementById('redirect-page')).toBeTruthy()
// since a 307/308 status code follows the redirect, the POST request should be made to both the action handler and the redirect target // since a 307/308 status code follows the redirect, the POST request should be made to both the route handler and the redirect target
expect(postRequests).toEqual([ expect(postRequests).toEqual([
`/redirects/api-redirect-${statusCode}`, `/redirects/api-redirect-${statusCode}`,
`/redirects?success=true`, `/redirects?success=true`,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment