Unverified Commit ad90a674 authored by Sebastian "Sebbie" Silbermann's avatar Sebastian "Sebbie" Silbermann Committed by GitHub

[test] Assert on stable error codes (#84671)

Fixes
```
DevErrorOverlay › sends feedback when clicking not helpful button

    expect(received).toEqual(expected) // deep equality

    - Expected  - 1
    + Received  + 1

      Array [
    -   "/__nextjs_error_feedback?errorCode=E794&wasHelpful=false",
    +   "/__nextjs_error_feedback?errorCode=E209&wasHelpful=false",
      ]
```

--
https://github.com/vercel/next.js/actions/runs/18360913450/job/52306369449#step:34:793
parent e2eee896
'use client' 'use client'
import Link from 'next/link'
import React from 'react' import React from 'react'
export default function Page() { export default function Page() {
const broken = (
<>
<Link href="/invalid" as="mailto:john@example.com">
<a>Invalid link</a>
</Link>
</>
)
const [shouldShow, setShouldShow] = React.useState(false) const [shouldShow, setShouldShow] = React.useState(false)
if (shouldShow) {
const error = new Error('Client error!')
;(error as any).__NEXT_ERROR_CODE = 'E40'
throw error
}
return ( return (
<div> <div>
<button onClick={() => setShouldShow(true)}>break on client</button> <button onClick={() => setShouldShow(true)}>break on client</button>
{shouldShow && broken}
</div> </div>
) )
} }
import { unstable_cache } from 'next/cache'
import { headers } from 'next/headers'
import React from 'react'
export default async function Page() { export default async function Page() {
const getData = unstable_cache(async () => { const error = new Error('Client error!')
const h = await headers() ;(error as any).__NEXT_ERROR_CODE = 'E40'
return h.get('x-test-header') throw error
}, ['test-header-key'])
return <div>{await getData()}</div> return null
} }
...@@ -14,7 +14,7 @@ describe('DevErrorOverlay', () => { ...@@ -14,7 +14,7 @@ describe('DevErrorOverlay', () => {
const errorCode = await browser.elementByCss('[data-nextjs-error-code]') const errorCode = await browser.elementByCss('[data-nextjs-error-code]')
const code = await errorCode.getAttribute('data-nextjs-error-code') const code = await errorCode.getAttribute('data-nextjs-error-code')
expect(code).toBe('E838') expect(code).toBe('E40')
}) })
it('sends feedback when clicking helpful button', async () => { it('sends feedback when clicking helpful button', async () => {
...@@ -41,7 +41,7 @@ describe('DevErrorOverlay', () => { ...@@ -41,7 +41,7 @@ describe('DevErrorOverlay', () => {
.textContent() .textContent()
).toEqual('Thanks for your feedback!') ).toEqual('Thanks for your feedback!')
expect(feedbackRequests).toEqual([ expect(feedbackRequests).toEqual([
'/__nextjs_error_feedback?errorCode=E794&wasHelpful=true', '/__nextjs_error_feedback?errorCode=E40&wasHelpful=true',
]) ])
}) })
}) })
...@@ -70,7 +70,7 @@ describe('DevErrorOverlay', () => { ...@@ -70,7 +70,7 @@ describe('DevErrorOverlay', () => {
.textContent() .textContent()
).toEqual('Thanks for your feedback!') ).toEqual('Thanks for your feedback!')
expect(feedbackRequests).toEqual([ expect(feedbackRequests).toEqual([
'/__nextjs_error_feedback?errorCode=E794&wasHelpful=false', '/__nextjs_error_feedback?errorCode=E40&wasHelpful=false',
]) ])
}) })
}) })
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment