Unverified Commit af04ef35 authored by JJ Kasper's avatar JJ Kasper Committed by GitHub

Ensure loader generated export default has name (#56388)

When the function name is omitted webpack generates a name from the loader config which can be really long un-necessarily. Providing a name for the default function alleviates this. cc @shuding who found this
parent a46c5afa
...@@ -47,7 +47,7 @@ const nextEdgeFunctionLoader: webpack.LoaderDefinitionFunction<EdgeFunctionLoade ...@@ -47,7 +47,7 @@ const nextEdgeFunctionLoader: webpack.LoaderDefinitionFunction<EdgeFunctionLoade
throw new Error('The Edge Function "pages${page}" must export a \`default\` function'); throw new Error('The Edge Function "pages${page}" must export a \`default\` function');
} }
export default function (opts) { export default function nHandler (opts) {
return adapter({ return adapter({
...opts, ...opts,
IncrementalCache, IncrementalCache,
......
...@@ -257,7 +257,7 @@ const edgeSSRLoader: webpack.LoaderDefinitionFunction<EdgeSSRLoaderQuery> = ...@@ -257,7 +257,7 @@ const edgeSSRLoader: webpack.LoaderDefinitionFunction<EdgeSSRLoaderQuery> =
export const ComponentMod = pageMod export const ComponentMod = pageMod
export default async function(opts, event) { export default async function nHandler (opts, event) {
const res = await adapter({ const res = await adapter({
...opts, ...opts,
IncrementalCache, IncrementalCache,
......
...@@ -67,7 +67,7 @@ export default function middlewareLoader(this: any) { ...@@ -67,7 +67,7 @@ export default function middlewareLoader(this: any) {
throw new Error('The Middleware "pages${page}" must export a \`middleware\` or a \`default\` function'); throw new Error('The Middleware "pages${page}" must export a \`middleware\` or a \`default\` function');
} }
export default function (opts) { export default function nHandler(opts) {
return adapter({ return adapter({
...opts, ...opts,
page: ${JSON.stringify(page)}, page: ${JSON.stringify(page)},
......
...@@ -15,6 +15,15 @@ createNextDescribe( ...@@ -15,6 +15,15 @@ createNextDescribe(
}, },
({ next, isNextDev: isDev, isNextStart, isNextDeploy }) => { ({ next, isNextDev: isDev, isNextStart, isNextDeploy }) => {
if (isNextStart && !process.env.NEXT_EXPERIMENTAL_COMPILE) { if (isNextStart && !process.env.NEXT_EXPERIMENTAL_COMPILE) {
it('should not have loader generated function for edge runtime', async () => {
expect(
await next.readFile('.next/server/app/dashboard/page.js')
).not.toContain('_stringifiedConfig')
expect(await next.readFile('.next/server/middleware.js')).not.toContain(
'_middlewareConfig'
)
})
it('should use RSC prefetch data from build', async () => { it('should use RSC prefetch data from build', async () => {
expect( expect(
await next.readFile('.next/server/app/linking.prefetch.rsc') await next.readFile('.next/server/app/linking.prefetch.rsc')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment