Commit affe356a authored by Michele Salvini's avatar Michele Salvini Committed by Tim Neutkens

Pass mapDispatchToProps as an object (#6786)

wrapping `startClock` in `bindActionsCreator` there's no need to pass `dispatch` in:
```
this.props.startClock(dispatch)
```
Furthermore `bindActionsCreator` is not needed because following already bind actions:
```
const mapDispatchToProps = {
  startClock
};
```
parent 16048628
import React from 'react' import React from 'react'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { bindActionCreators } from 'redux'
import { startClock, serverRenderClock } from '../store' import { startClock, serverRenderClock } from '../store'
import Examples from '../components/examples' import Examples from '../components/examples'
class Index extends React.Component { class Index extends React.Component {
static getInitialProps ({ reduxStore, req }) { static getInitialProps ({ reduxStore, req }) {
const isServer = !!req const isServer = !!req
// DISPATCH ACTIONS HERE ONLY WITH `reduxStore.dispatch`
reduxStore.dispatch(serverRenderClock(isServer)) reduxStore.dispatch(serverRenderClock(isServer))
return {} return {}
} }
componentDidMount () { componentDidMount () {
const { dispatch } = this.props // DISPATCH ACTIONS HERE FROM `mapDispatchToProps`
// TO TICK THE CLOCK // TO TICK THE CLOCK
this.timer = setInterval(() => this.props.startClock(dispatch), 1000) this.timer = setInterval(() => this.props.startClock(), 1000)
} }
componentWillUnmount () { componentWillUnmount () {
...@@ -26,5 +26,5 @@ class Index extends React.Component { ...@@ -26,5 +26,5 @@ class Index extends React.Component {
return <Examples /> return <Examples />
} }
} }
const mapDispatchToProps = dispatch => bindActionCreators({ startClock }, dispatch) const mapDispatchToProps = { startClock }
export default connect(null, mapDispatchToProps)(Index) export default connect(null, mapDispatchToProps)(Index)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment