Unverified Commit b02df3f4 authored by Tobias Koppers's avatar Tobias Koppers Committed by GitHub

improve splitChunks config for webpack 5 (#21208)

parent 9c4d3684
......@@ -434,17 +434,11 @@ export default async function getBaseWebpackConfig(
cacheGroups: {
default: false,
vendors: false,
// In webpack 5 vendors was renamed to defaultVendors
defaultVendors: false,
},
},
prodGranular: {
chunks: 'all',
cacheGroups: {
default: false,
vendors: false,
// In webpack 5 vendors was renamed to defaultVendors
defaultVendors: false,
framework: {
chunks: 'all',
name: 'framework',
......@@ -458,10 +452,13 @@ export default async function getBaseWebpackConfig(
enforce: true,
},
lib: {
test(module: { size: Function; identifier: Function }): boolean {
test(module: {
size: Function
nameForCondition: Function
}): boolean {
return (
module.size() > 160000 &&
/node_modules[/\\]/.test(module.identifier())
/node_modules[/\\]/.test(module.nameForCondition() || '')
)
},
name(module: {
......@@ -493,26 +490,32 @@ export default async function getBaseWebpackConfig(
minChunks: totalPages,
priority: 20,
},
shared: {
name(module, chunks) {
return (
crypto
.createHash('sha1')
.update(
chunks.reduce(
(acc: string, chunk: webpack.compilation.Chunk) => {
return acc + chunk.name
},
''
...(isWebpack5
? undefined
: {
default: false,
vendors: false,
shared: {
name(module, chunks) {
return (
crypto
.createHash('sha1')
.update(
chunks.reduce(
(acc: string, chunk: webpack.compilation.Chunk) => {
return acc + chunk.name
},
''
)
)
.digest('hex') + (isModuleCSS(module) ? '_CSS' : '')
)
)
.digest('hex') + (isModuleCSS(module) ? '_CSS' : '')
)
},
priority: 10,
minChunks: 2,
reuseExistingChunk: true,
},
},
priority: 10,
minChunks: 2,
reuseExistingChunk: true,
},
}),
},
maxInitialRequests: 25,
minSize: 20000,
......
......@@ -135,5 +135,39 @@ module.exports = {
},
],
},
{
title: 'Webpack 5 Mode',
diff: 'onOutputChange',
renames,
configFiles: [
{
path: 'next.config.js',
content: `
module.exports = {
generateBuildId: () => 'BUILD_ID',
future: {
webpack5: true
}
}
`,
},
],
filesToTrack: clientGlobs,
// will be output to fetched-pages/${pathname}.html
pagesToFetch: [
'http://localhost:$PORT/',
'http://localhost:$PORT/link',
'http://localhost:$PORT/withRouter',
],
pagesToBench: [
'http://localhost:$PORT/',
'http://localhost:$PORT/error-in-render',
],
benchOptions: {
reqTimeout: 60,
concurrency: 50,
numRequests: 2500,
},
},
],
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment