Commit b30a8b2e authored by Henrik Wenz's avatar Henrik Wenz Committed by Tim Neutkens

WIP: Fix devtoolModuleFilenames for react-error-overlay (#5055)

## Issue

Currently react-error-overlays launch-editor functionality doesn’t work because the module paths are in the wrong format.

## Todo

- [x] Keep source-maps enabled

## Related

https://github.com/zeit/next.js/pull/4979
parent 4ef37886
...@@ -55,9 +55,11 @@ let customHmrEventHandler ...@@ -55,9 +55,11 @@ let customHmrEventHandler
export default function connect (options) { export default function connect (options) {
// Open stack traces in an editor. // Open stack traces in an editor.
ErrorOverlay.setEditorHandler(function editorHandler ({ fileName, lineNumber, colNumber }) { ErrorOverlay.setEditorHandler(function editorHandler ({ fileName, lineNumber, colNumber }) {
// Resolve invalid paths coming from react-error-overlay
const resolvedFilename = fileName.replace(/^webpack:\/\//, '')
fetch( fetch(
'/_next/development/open-stack-frame-in-editor' + '/_next/development/open-stack-frame-in-editor' +
`?fileName=${window.encodeURIComponent(fileName)}` + `?fileName=${window.encodeURIComponent(resolvedFilename)}` +
`&lineNumber=${lineNumber || 1}` + `&lineNumber=${lineNumber || 1}` +
`&colNumber=${colNumber || 1}` `&colNumber=${colNumber || 1}`
) )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment