Commit b39958e7 authored by Jonathan James's avatar Jonathan James Committed by Tim Neutkens

Fix serve command (#3989)

* Fix serve command

From the Firebase docs, you must use --only in order to run the local function emulator.
See https://firebase.google.com/docs/functions/local-emulator

* Add production env for firebase serve

Doesn't work without this

* Update text as suggested by @jthegedus
parent bd50a7c7
...@@ -43,13 +43,9 @@ npm run dev ...@@ -43,13 +43,9 @@ npm run dev
#### Run Firebase locally for testing: #### Run Firebase locally for testing:
Unfortunately I have been unable to get any combination of
```bash
firebase serve --only functions,hosting
``` ```
npm run serve
to locally host the built Next.js app as expected. [This issue is where solutions are being explored](https://github.com/firebase/firebase-tools/issues/535) and they will be shared here and on the [Next.js repo's similar issue](https://github.com/zeit/next.js/issues/3167) when discovered. ```
#### Deploy it to the cloud with Firebase: #### Deploy it to the cloud with Firebase:
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
"description": "Host Next.js SSR app on Firebase Cloud Functions with Firebase Hosting redirects.", "description": "Host Next.js SSR app on Firebase Cloud Functions with Firebase Hosting redirects.",
"scripts": { "scripts": {
"dev": "next src/app", "dev": "next src/app",
"serve": "echo \"for details see:\n\thttps://github.com/firebase/firebase-tools/issues/535 \n\thttps://github.com/zeit/next.js/issues/3167\";", "serve": "NODE_ENV=production firebase serve --only functions,hosting",
"deploy": "firebase deploy", "deploy": "firebase deploy",
"clean": "rimraf \"dist/functions\" && rimraf \"dist/public\"", "clean": "rimraf \"dist/functions\" && rimraf \"dist/public\"",
"build-public": "cpx \"src/public/**/*.*\" \"dist/public\" -C", "build-public": "cpx \"src/public/**/*.*\" \"dist/public\" -C",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment