Unverified Commit b421cade authored by Tobias Koppers's avatar Tobias Koppers Committed by GitHub

test: migrate package CSS side-effects coverage (#98635)

### What?

Migrates the package CSS side-effects coverage from #70087 into the
current `css-order` end-to-end suite. The matrix covers `sideEffects`
values of `true`, `false`, broad CSS arrays, and global-CSS-only arrays
across App Router, Pages Router, client components, and server
components with client children.

### Why?

The older coverage never reached `canary`, and most of its Turbopack
cases were skipped as inconsistent. Keeping the scenarios in the current
suite verifies that package CSS ordering remains deterministic in both
Turbopack's default chunking mode and the graph chunker.

### How?

The test uses explicit synthetic package fixtures and reuses the suite's
existing Turbopack mode matrix, including the graph string and object
configurations. The packages are transpiled so Pages Router exercises
bundler CSS behavior rather than externalizing CSS imports to Node.
Invalid entrypoints, selectors, routes, and CSS module references from
the old fixtures were corrected during migration.

This does not include the webpack loader implementation change proposed
by #70087.

### Verification

- `HEADLESS=true pnpm test-dev-turbo
test/e2e/app-dir/css-order/css-order.test.ts` (189 passed, 114 existing
todos)
- `HEADLESS=true pnpm test-start-turbo
test/e2e/app-dir/css-order/css-order.test.ts` (291 passed, 12 existing
todos)
- `HEADLESS=true pnpm test-start-webpack
test/e2e/app-dir/css-order/css-order.test.ts` (192 passed, 8 existing
todos)

<!-- NEXT_JS_LLM -->

<!-- fleet 10f9743e-de76-437c-8fdc-76b7be42a9b9 -->

---------
Co-authored-by: 's avatarvercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com>
Co-authored-by: 's avatarTobias Koppers <1365881+sokra@users.noreply.github.com>
parent 3dc93da2
import { SideEffectsArrayComponent } from 'side-effects-array-dep'
import Nav from '../../nav'
export default function Page() {
return (
<div>
<SideEffectsArrayComponent id="vendor-side-effects-array">
side effects: array
</SideEffectsArrayComponent>
<Nav />
</div>
)
}
import { SideEffectsComponent } from 'side-effects-dep'
import Nav from '../../nav'
export default function Page() {
return (
<div>
<SideEffectsComponent id="vendor-side-effects-true">
side effects: true
</SideEffectsComponent>
<Nav />
</div>
)
}
import { SideEffectsFalseComponent } from 'side-effects-false-dep'
import Nav from '../../nav'
export default function Page() {
return (
<div>
<SideEffectsFalseComponent id="vendor-side-effects-false">
side effects: false
</SideEffectsFalseComponent>
<Nav />
</div>
)
}
import { SideEffectsArrayGlobalComponent } from 'side-effects-array-global-only-dep'
import Nav from '../../nav'
export default function Page() {
return (
<div>
<SideEffectsArrayGlobalComponent id="vendor-side-effects-global-array">
side effects: global css array
</SideEffectsArrayGlobalComponent>
<Nav />
</div>
)
}
import { SideEffectsArrayComponentClient } from 'side-effects-array-dep/index-client'
import Nav from '../../nav'
export default function Page() {
return (
<div>
<SideEffectsArrayComponentClient id="vendor-side-effects-array-client">
side effects: array - client components
</SideEffectsArrayComponentClient>
<Nav />
</div>
)
}
import { SideEffectsArrayComponentWithClientSubcomponent } from 'side-effects-array-dep/index-server-client'
import Nav from '../../nav'
export default function Page() {
return (
<div>
<SideEffectsArrayComponentWithClientSubcomponent id="vendor-side-effects-array-server-client-subcomponent">
side effects: array - server component with client subcomponent
</SideEffectsArrayComponentWithClientSubcomponent>
<Nav />
</div>
)
}
import { SideEffectsComponentClient } from 'side-effects-dep/index-client'
import Nav from '../../nav'
export default function Page() {
return (
<div>
<SideEffectsComponentClient id="vendor-side-effects-true-client">
side effects: true - client
</SideEffectsComponentClient>
<Nav />
</div>
)
}
import { SideEffectsComponentWithClientSubcomponent } from 'side-effects-dep/index-server-client'
import Nav from '../../nav'
export default function Page() {
return (
<div>
<SideEffectsComponentWithClientSubcomponent id="vendor-side-effects-true-server-client-subcomponent">
side effects: true - server component with client subcomponent
</SideEffectsComponentWithClientSubcomponent>
<Nav />
</div>
)
}
import { SideEffectsFalseComponentClient } from 'side-effects-false-dep/index-client'
import Nav from '../../nav'
export default function Page() {
return (
<div>
<SideEffectsFalseComponentClient id="vendor-side-effects-false-client">
side effects: false - client
</SideEffectsFalseComponentClient>
<Nav />
</div>
)
}
import { SideEffectsFalseComponentWithClientSubcomponent } from 'side-effects-false-dep/index-server-client'
import Nav from '../../nav'
export default function Page() {
return (
<div>
<SideEffectsFalseComponentWithClientSubcomponent id="vendor-side-effects-false-server-client-subcomponent">
side effects: false - server component with client subcomponent
</SideEffectsFalseComponentWithClientSubcomponent>
<Nav />
</div>
)
}
import { SideEffectsArrayGlobalComponentClient } from 'side-effects-array-global-only-dep/index-client'
import Nav from '../../nav'
export default function Page() {
return (
<div>
<SideEffectsArrayGlobalComponentClient id="vendor-side-effects-global-array-client">
side effects: global css array
</SideEffectsArrayGlobalComponentClient>
<Nav />
</div>
)
}
import { SideEffectsArrayGlobalComponentWithClientSubcomponent } from 'side-effects-array-global-only-dep/index-server-client'
import Nav from '../../nav'
export default function Page() {
return (
<div>
<SideEffectsArrayGlobalComponentWithClientSubcomponent id="vendor-side-effects-global-array-server-client">
side effects: global css array - server component with client
subcomponent
</SideEffectsArrayGlobalComponentWithClientSubcomponent>
<Nav />
</div>
)
}
.side-effects-array-client {
background-color: rgb(254, 254, 0);
color: rgb(0, 255, 255);
}
'use client'
import { jsx as _jsx } from 'react/jsx-runtime'
import { ArraySubcomponentClient } from './subcomponent-client.js'
import './index-client.css'
import styles from './index-client.module.css'
export function SideEffectsArrayComponentClient({
children,
className,
...props
}) {
return /*#__PURE__*/ _jsx(ArraySubcomponentClient, {
...props,
className: `${styles.array_dep_client} side-effects-array-client ${className ?? ''}`,
children: children,
})
}
import { jsx as _jsx } from 'react/jsx-runtime'
import { ArraySubcomponentClient } from './subcomponent-client.js'
import './index.css'
import styles from './index.module.css'
export function SideEffectsArrayComponentWithClientSubcomponent({
children,
className,
...props
}) {
return /*#__PURE__*/ _jsx(ArraySubcomponentClient, {
...props,
className: `${styles.array_dep} side-effects-array ${className ?? ''}`,
children: children,
})
}
.side-effects-array {
background-color: rgb(0, 254, 0);
color: rgb(0, 255, 255);
}
import { jsx as _jsx } from 'react/jsx-runtime'
import { ArraySubcomponent } from './subcomponent.js'
import './index.css'
import styles from './index.module.css'
export function SideEffectsArrayComponent({ children, className, ...props }) {
return /*#__PURE__*/ _jsx(ArraySubcomponent, {
...props,
className: `${styles.array_dep} side-effects-array ${className ?? ''}`,
children: children,
})
}
{
"name": "side-effects-array-dep",
"sideEffects": [
"*.css"
],
"version": "1.0.0"
}
.side-effects-array-client {
background-color: teal;
color: teal;
}
'use client'
import { jsx as _jsx } from 'react/jsx-runtime'
import './subcomponent-client.css'
import styles from './subcomponent-client.module.css'
export function ArraySubcomponentClient({ children, className, ...props }) {
return /*#__PURE__*/ _jsx('a', {
...props,
className: `${styles.array_dep_subcomponent_client} ${className ?? ''}`,
children: children,
})
}
import { jsx as _jsx } from 'react/jsx-runtime'
import './subcomponent.css'
import styles from './subcomponent.module.css'
export function ArraySubcomponent({ children, className, ...props }) {
return /*#__PURE__*/ _jsx('a', {
...props,
className: `${styles.array_dep_subcomponent} ${className ?? ''}`,
children: children,
})
}
.side-effects-array-global-only-client {
background-color: rgb(250, 250, 0);
color: rgb(0, 255, 255);
}
'use client'
import { jsx as _jsx } from 'react/jsx-runtime'
import { ArraySubcomponentClient } from './subcomponent-client.js'
import './index-client.css'
import styles from './index-client.module.css'
export function SideEffectsArrayGlobalComponentClient({
children,
className,
...props
}) {
return /*#__PURE__*/ _jsx(ArraySubcomponentClient, {
...props,
className: `${styles.array_global_dep_client} side-effects-array-global-only-client ${className ?? ''}`,
children: children,
})
}
import { jsx as _jsx } from 'react/jsx-runtime'
import { ArraySubcomponentClient } from './subcomponent-client.js'
import './index.css'
import styles from './index.module.css'
export function SideEffectsArrayGlobalComponentWithClientSubcomponent({
children,
className,
...props
}) {
return /*#__PURE__*/ _jsx(ArraySubcomponentClient, {
...props,
className: `${styles.array_global_dep} side-effects-array-global-only ${className ?? ''}`,
children: children,
})
}
.side-effects-array-global-only {
background-color: rgb(0, 250, 0);
color: rgb(0, 255, 255);
}
import { jsx as _jsx } from 'react/jsx-runtime'
import { ArraySubcomponent } from './subcomponent.js'
import './index.css'
import styles from './index.module.css'
export function SideEffectsArrayGlobalComponent({
children,
className,
...props
}) {
return /*#__PURE__*/ _jsx(ArraySubcomponent, {
...props,
className: `${styles.array_global_dep} side-effects-array-global-only ${className ?? ''}`,
children: children,
})
}
{
"name": "side-effects-array-global-only-dep",
"sideEffects": [
"index.css",
"subcomponent.css"
],
"version": "1.0.0"
}
.side-effects-array-global-only-client {
background-color: teal;
color: teal;
}
'use client'
import { jsx as _jsx } from 'react/jsx-runtime'
import './subcomponent-client.css'
import styles from './subcomponent-client.module.css'
export function ArraySubcomponentClient({ children, className, ...props }) {
return /*#__PURE__*/ _jsx('a', {
...props,
className: `${styles.array_global_dep_subcomponent_client} ${className ?? ''}`,
children: children,
})
}
.side-effects-array-global-only {
background-color: teal;
color: teal;
}
import { jsx as _jsx } from 'react/jsx-runtime'
import './subcomponent.css'
import styles from './subcomponent.module.css'
export function ArraySubcomponent({ children, className, ...props }) {
return /*#__PURE__*/ _jsx('a', {
...props,
className: `${styles.array_global_dep_subcomponent} ${className ?? ''}`,
children: children,
})
}
.side-effects-true-client {
background-color: rgb(253, 253, 0);
color: rgb(0, 255, 255);
}
'use client'
import { jsx as _jsx } from 'react/jsx-runtime'
import { SideEffectsSubcomponentClient } from './subcomponent-client.js'
import './index-client.css'
import styles from './index-client.module.css'
export function SideEffectsComponentClient({ children, className, ...props }) {
return /*#__PURE__*/ _jsx(SideEffectsSubcomponentClient, {
...props,
className: `${styles.side_effects_dep_client} side-effects-true-client ${className ?? ''}`,
children: children,
})
}
import { jsx as _jsx } from 'react/jsx-runtime'
import { SideEffectsSubcomponentClient } from './subcomponent-client.js'
import './index.css'
import styles from './index.module.css'
export function SideEffectsComponentWithClientSubcomponent({
children,
className,
...props
}) {
return /*#__PURE__*/ _jsx(SideEffectsSubcomponentClient, {
...props,
className: `${styles.side_effects_dep} side-effects-true ${className ?? ''}`,
children: children,
})
}
.side-effects-true {
background-color: rgb(0, 253, 0);
color: rgb(0, 255, 255);
}
import { jsx as _jsx } from 'react/jsx-runtime'
import { SideEffectsSubcomponent } from './subcomponent'
import './index.css'
import styles from './index.module.css'
export function SideEffectsComponent({ children, className, ...props }) {
return /*#__PURE__*/ _jsx(SideEffectsSubcomponent, {
...props,
className: `${styles.side_effects_dep} side-effects-true ${className ?? ''}`,
children: children,
})
}
{
"name": "side-effects-dep",
"sideEffects": true,
"version": "1.0.0"
}
.side-effects-true-client {
background-color: teal;
color: teal;
}
'use client'
import { jsx as _jsx } from 'react/jsx-runtime'
import './subcomponent-client.css'
import styles from './subcomponent-client.module.css'
export function SideEffectsSubcomponentClient({
children,
className,
...props
}) {
return /*#__PURE__*/ _jsx('a', {
...props,
className: `${styles.side_effects_dep_subcomponent_client} ${className ?? ''}`,
children: children,
})
}
.side-effects-true {
background-color: teal;
color: teal;
}
import { jsx as _jsx } from 'react/jsx-runtime'
import './subcomponent.css'
import styles from './subcomponent.module.css'
export function SideEffectsSubcomponent({ children, className, ...props }) {
return /*#__PURE__*/ _jsx('a', {
...props,
className: `${styles.side_effects_dep_subcomponent} ${className ?? ''}`,
children: children,
})
}
.side-effects-false-client {
background-color: rgb(252, 252, 0);
color: rgb(0, 255, 255);
}
'use client'
import { jsx as _jsx } from 'react/jsx-runtime'
import { SideEffectsFalseSubcomponentClient } from './subcomponent-client.js'
import './index-client.css'
import styles from './index-client.module.css'
export function SideEffectsFalseComponentClient({
children,
className,
...props
}) {
return /*#__PURE__*/ _jsx(SideEffectsFalseSubcomponentClient, {
...props,
className: `${styles.side_effects_false_dep_client} side-effects-false-client ${className ?? ''}`,
children: children,
})
}
import { jsx as _jsx } from 'react/jsx-runtime'
import { SideEffectsFalseSubcomponentClient } from './subcomponent-client.js'
import './index.css'
import styles from './index.module.css'
export function SideEffectsFalseComponentWithClientSubcomponent({
children,
className,
...props
}) {
return /*#__PURE__*/ _jsx(SideEffectsFalseSubcomponentClient, {
...props,
className: `${styles.side_effects_false_dep} side-effects-false ${className ?? ''}`,
children: children,
})
}
.side-effects-false {
background-color: rgb(0, 252, 0);
color: rgb(0, 255, 255);
}
import { jsx as _jsx } from 'react/jsx-runtime'
import { SideEffectsFalseSubcomponent } from './subcomponent'
import './index.css'
import styles from './index.module.css'
export function SideEffectsFalseComponent({ children, className, ...props }) {
return /*#__PURE__*/ _jsx(SideEffectsFalseSubcomponent, {
...props,
className: `${styles.side_effects_false_dep} side-effects-false ${className ?? ''}`,
children: children,
})
}
{
"name": "side-effects-false-dep",
"sideEffects": false,
"version": "1.0.0"
}
.side-effects-false-client {
background-color: teal;
color: teal;
}
'use client'
import { jsx as _jsx } from 'react/jsx-runtime'
import './subcomponent-client.css'
import styles from './subcomponent-client.module.css'
export function SideEffectsFalseSubcomponentClient({
children,
className,
...props
}) {
return /*#__PURE__*/ _jsx('a', {
...props,
className: `${styles.side_effects_false_dep_subcomponent_client} ${className ?? ''}`,
children: children,
})
}
import { jsx as _jsx } from 'react/jsx-runtime'
import './subcomponent.css'
import styles from './subcomponent.module.css'
export function SideEffectsFalseSubcomponent({
children,
className,
...props
}) {
return /*#__PURE__*/ _jsx('a', {
...props,
className: `${styles.side_effects_false_dep_subcomponent} ${className ?? ''}`,
children: children,
})
}
...@@ -277,6 +277,134 @@ const PAGES: Record< ...@@ -277,6 +277,134 @@ const PAGES: Record<
}, },
} }
type SideEffectsPage = {
name: string
url: string
selector: string
color: string
background: string
turbopackOnly?: boolean
}
const SIDE_EFFECTS_PAGES: SideEffectsPage[] = [
{
name: 'app router, CSS array',
url: '/vendor/a',
selector: '#vendor-side-effects-array',
color: 'rgb(254, 0, 0)',
background: 'rgb(0, 254, 0)',
},
{
name: 'app router, sideEffects true',
url: '/vendor/b',
selector: '#vendor-side-effects-true',
color: 'rgb(253, 0, 0)',
background: 'rgb(0, 253, 0)',
},
{
name: 'app router, sideEffects false',
url: '/vendor/c',
selector: '#vendor-side-effects-false',
color: 'rgb(252, 0, 0)',
background: 'rgb(0, 252, 0)',
},
{
name: 'app router, global CSS array',
url: '/vendor/d',
selector: '#vendor-side-effects-global-array',
color: 'rgb(250, 0, 0)',
background: 'rgb(0, 250, 0)',
},
{
name: 'app router client component, CSS array',
url: '/vendor/e',
selector: '#vendor-side-effects-array-client',
color: 'rgb(254, 254, 0)',
background: 'rgb(254, 254, 0)',
},
{
name: 'app router server component with client child, CSS array',
url: '/vendor/f',
selector: '#vendor-side-effects-array-server-client-subcomponent',
color: 'rgb(254, 0, 0)',
background: 'rgb(0, 254, 0)',
turbopackOnly: true,
},
{
name: 'app router client component, sideEffects true',
url: '/vendor/g',
selector: '#vendor-side-effects-true-client',
color: 'rgb(253, 253, 0)',
background: 'rgb(253, 253, 0)',
},
{
name: 'app router server component with client child, sideEffects true',
url: '/vendor/h',
selector: '#vendor-side-effects-true-server-client-subcomponent',
color: 'rgb(253, 0, 0)',
background: 'rgb(0, 253, 0)',
turbopackOnly: true,
},
{
name: 'app router client component, sideEffects false',
url: '/vendor/i',
selector: '#vendor-side-effects-false-client',
color: 'rgb(252, 252, 0)',
background: 'rgb(252, 252, 0)',
},
{
name: 'app router server component with client child, sideEffects false',
url: '/vendor/j',
selector: '#vendor-side-effects-false-server-client-subcomponent',
color: 'rgb(252, 0, 0)',
background: 'rgb(0, 252, 0)',
turbopackOnly: true,
},
{
name: 'app router client component, global CSS array',
url: '/vendor/k',
selector: '#vendor-side-effects-global-array-client',
color: 'rgb(250, 250, 0)',
background: 'rgb(250, 250, 0)',
},
{
name: 'app router server component with client child, global CSS array',
url: '/vendor/l',
selector: '#vendor-side-effects-global-array-server-client',
color: 'rgb(250, 0, 0)',
background: 'rgb(0, 250, 0)',
turbopackOnly: true,
},
{
name: 'pages router, CSS array',
url: '/pages/vendor/a',
selector: '#vendor-side-effects-array',
color: 'rgb(254, 0, 0)',
background: 'rgb(0, 254, 0)',
},
{
name: 'pages router, sideEffects true',
url: '/pages/vendor/b',
selector: '#vendor-side-effects-true',
color: 'rgb(253, 0, 0)',
background: 'rgb(0, 253, 0)',
},
{
name: 'pages router, sideEffects false',
url: '/pages/vendor/c',
selector: '#vendor-side-effects-false',
color: 'rgb(252, 0, 0)',
background: 'rgb(0, 252, 0)',
},
{
name: 'pages router, global CSS array',
url: '/pages/vendor/d',
selector: '#vendor-side-effects-global-array',
color: 'rgb(250, 0, 0)',
background: 'rgb(0, 250, 0)',
},
]
const allPairs = getPairs(Object.keys(PAGES)) const allPairs = getPairs(Object.keys(PAGES))
// Each entry is `[label, value]`, where `label` is shown in test names and `value` is what gets // Each entry is `[label, value]`, where `label` is shown in test names and `value` is what gets
...@@ -327,14 +455,21 @@ function isStrictMode(value: CssChunkingValue): boolean { ...@@ -327,14 +455,21 @@ function isStrictMode(value: CssChunkingValue): boolean {
return value === 'strict' return value === 'strict'
} }
const SIDE_EFFECTS_PACKAGES = [
'side-effects-array-dep',
'side-effects-array-global-only-dep',
'side-effects-dep',
'side-effects-false-dep',
]
const options = (value: CssChunkingValue) => ({ const options = (value: CssChunkingValue) => ({
files: { files: {
app: new FileRef(path.join(__dirname, 'app')), app: new FileRef(path.join(__dirname, 'app')),
pages: new FileRef(path.join(__dirname, 'pages')), pages: new FileRef(path.join(__dirname, 'pages')),
'next.config.js': 'next.config.js': `module.exports = ${JSON.stringify({
value === undefined transpilePackages: SIDE_EFFECTS_PACKAGES,
? `module.exports = {}` ...(value === undefined ? {} : { experimental: { cssChunking: value } }),
: `module.exports = { experimental: { cssChunking: ${JSON.stringify(value)} } }`, })}`,
}, },
dependencies: { dependencies: {
sass: 'latest', sass: 'latest',
...@@ -511,3 +646,31 @@ describe.each( ...@@ -511,3 +646,31 @@ describe.each(
}) })
} }
}) })
// Webpack currently applies the client child's CSS module after the parent module in
// App Router server-component-with-client-child cases. Gate only those known divergences;
// the other package sideEffects scenarios share expectations across both bundlers.
describe.each(
process.env.IS_TURBOPACK_TEST ? TURBO_MODES : WEBPACK_MODES_LOOSE
)('css-order sideEffects %s', (_label: string, value: CssChunkingValue) => {
const { next } = nextTestSetup(options(value))
const testPage = (page: SideEffectsPage) => async () => {
const browser = await next.browser(page.url)
const element = browser.waitForElementByCss(page.selector)
expect(await element.getComputedCss('color')).toBe(page.color)
expect(await element.getComputedCss('background-color')).toBe(
page.background
)
await browser.close()
}
for (const page of SIDE_EFFECTS_PAGES.filter((page) => !page.turbopackOnly)) {
it(`should load correct styles for ${page.name}`, testPage(page))
}
for (const page of SIDE_EFFECTS_PAGES.filter((page) => page.turbopackOnly)) {
// @gate turbopack
it(`should load correct styles for ${page.name}`, testPage(page))
}
})
export { default } from '../../../app/vendor/a/page'
export { default } from '../../../app/vendor/b/page'
export { default } from '../../../app/vendor/c/page'
export { default } from '../../../app/vendor/d/page'
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment