Unverified Commit b441cff7 authored by Zack Tanner's avatar Zack Tanner Committed by GitHub

fix NODE_OPTIONS=inspect (#59530)

Passing `NODE_OPTIONS='--inspect'` was failing because a sub-process was
getting created (`getRegistry()`) which would trigger a "address already
in use" error when the process inherited the same debugger port from the
parent process.

I had to disable this test in
https://github.com/vercel/next.js/pull/59508 because it wasn't passing,
CI was just skipping it. This PR fixes the behavior and re-enables the
test.

Fixes #55862

Closes NEXT-1854
parent eb6aae64
import { execSync } from 'child_process' import { execSync } from 'child_process'
import { getPkgManager } from './get-pkg-manager' import { getPkgManager } from './get-pkg-manager'
import { getNodeOptionsWithoutInspect } from '../../server/lib/utils'
/** /**
* Returns the package registry using the user's package manager. * Returns the package registry using the user's package manager.
...@@ -10,7 +11,12 @@ export function getRegistry(baseDir: string = process.cwd()) { ...@@ -10,7 +11,12 @@ export function getRegistry(baseDir: string = process.cwd()) {
let registry = `https://registry.npmjs.org/` let registry = `https://registry.npmjs.org/`
try { try {
const pkgManager = getPkgManager(baseDir) const pkgManager = getPkgManager(baseDir)
const output = execSync(`${pkgManager} config get registry`) const output = execSync(`${pkgManager} config get registry`, {
env: {
...process.env,
NODE_OPTIONS: getNodeOptionsWithoutInspect(),
},
})
.toString() .toString()
.trim() .trim()
......
...@@ -547,8 +547,10 @@ describe('CLI Usage', () => { ...@@ -547,8 +547,10 @@ describe('CLI Usage', () => {
try { try {
await check(() => output, new RegExp(`http://localhost:${port}`)) await check(() => output, new RegExp(`http://localhost:${port}`))
await check(() => errOutput, /Debugger listening on/) await check(() => errOutput, /Debugger listening on/)
// TODO: This should work, but is currently failing. expect(errOutput).not.toContain('address already in use')
// expect(errOutput).not.toContain('address already in use') expect(output).toContain(
'the --inspect option was detected, the Next.js router server should be inspected at port'
)
} finally { } finally {
await killApp(app) await killApp(app)
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment