Fix dev overlay symbolication for project paths needing percent-encoding (#96221)
In a project whose absolute path contains characters that percent-encode in URLs — e.g. a space — the dev overlay showed no code frame and raw `file://` URLs instead of source locations for server frames. Two encoding mismatches caused this: - Turbopack's `trace_source` percent-decoded the source map's original file URL before comparing it against the still-encoded project root URI, so the containment check failed ("Original file ... outside project") for any project path with such characters. The comparisons now stay in the encoded domain and only the outputs are decoded back into paths. - React synthesizes stack frame `file:` URLs by prepending the scheme to a filesystem path, so the overlay receives URLs with e.g. raw spaces. These aren't well-formed, and they don't match the `url.pathToFileURL` form Node.js keys its source map cache by. The overlay middleware now re-encodes them through WHATWG URL parsing, which tolerates such input. ## Test Plan New tests. Known cases that remain broken are commented out with a TODO. These could be resolved if https://github.com/react/react/pull/37105 or equivalent lands. ## Before <img width="825" height="732" alt="Screenshot 2026-07-25 at 14 39 18" src="https://github.com/user-attachments/assets/0f119e52-ec86-495a-bf5c-5339faa1d606" /> ## After <img width="1126" height="733" alt="Screenshot 2026-07-25 at 14 58 14" src="https://github.com/user-attachments/assets/a263ee8a-4cfe-4358-9a8e-2e58b4b16aa5" /> Co-authored-by:Claude Fable 5 <noreply@anthropic.com>
Showing
Please
register
or
sign in
to comment