Unverified Commit b6a45eba authored by Sebastian Silbermann's avatar Sebastian Silbermann Committed by GitHub

Fix sync-react changelog (#66532)

parent 3445a562
...@@ -204,7 +204,7 @@ function extractInfoFromReactVersion(reactVersion) { ...@@ -204,7 +204,7 @@ function extractInfoFromReactVersion(reactVersion) {
async function getChangelogFromGitHub(baseSha, newSha) { async function getChangelogFromGitHub(baseSha, newSha) {
const pageSize = 50 const pageSize = 50
let changelog = [] let changelog = []
for (let currentPage = 0; ; currentPage++) { for (let currentPage = 1; ; currentPage++) {
const url = `https://api.github.com/repos/facebook/react/compare/${baseSha}...${newSha}?per_page=${pageSize}&page=${currentPage}` const url = `https://api.github.com/repos/facebook/react/compare/${baseSha}...${newSha}?per_page=${pageSize}&page=${currentPage}`
const headers = {} const headers = {}
// GITHUB_TOKEN is optional but helps in case of rate limiting during development. // GITHUB_TOKEN is optional but helps in case of rate limiting during development.
...@@ -221,10 +221,7 @@ async function getChangelogFromGitHub(baseSha, newSha) { ...@@ -221,10 +221,7 @@ async function getChangelogFromGitHub(baseSha, newSha) {
} }
const data = await response.json() const data = await response.json()
const { base_commit, commits } = data const { commits } = data
if (currentPage === 0) {
commits.unshift(base_commit)
}
for (const { commit, sha } of commits) { for (const { commit, sha } of commits) {
const title = commit.message.split('\n')[0] || '' const title = commit.message.split('\n')[0] || ''
const match = const match =
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment