Unverified Commit bcbaf8c8 authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Always write FunctionsConfigManifest (#60163)

## What?

Noticed there was a specific guard to avoid writing this manifest when
there was no custom config, but for consistency in the output it's
better to always write it.
Also added a type for this manifest.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Closes NEXT-1960
parent 48355fdc
......@@ -423,6 +423,21 @@ async function writeClientSsgManifest(
)
}
interface FunctionsConfigManifest {
version: number
functions: Record<string, Record<string, string | number>>
}
async function writeFunctionsConfigManifest(
distDir: string,
manifest: FunctionsConfigManifest
): Promise<void> {
await writeManifest(
path.join(distDir, SERVER_DIRECTORY, FUNCTIONS_CONFIG_MANIFEST),
manifest
)
}
interface RequiredServerFilesManifest {
version: number
config: NextConfigComplete
......@@ -1515,7 +1530,11 @@ export default async function build(
const analysisBegin = process.hrtime()
const staticCheckSpan = nextBuildSpan.traceChild('static-check')
const functionsConfigManifest = {} as Record<string, Record<string, any>>
const functionsConfigManifest: FunctionsConfigManifest = {
version: 1,
functions: {},
}
const {
customAppGetInitialProps,
namedExports,
......@@ -1718,7 +1737,8 @@ export default async function build(
: undefined
if (staticInfo?.extraConfig) {
functionsConfigManifest[page] = staticInfo.extraConfig
functionsConfigManifest.functions[page] =
staticInfo.extraConfig
}
const pageRuntime = middlewareManifest.functions[
......@@ -2061,20 +2081,7 @@ export default async function build(
)
}
if (Object.keys(functionsConfigManifest).length > 0) {
const manifest: {
version: number
functions: Record<string, Record<string, string | number>>
} = {
version: 1,
functions: functionsConfigManifest,
}
await writeManifest(
path.join(distDir, SERVER_DIRECTORY, FUNCTIONS_CONFIG_MANIFEST),
manifest
)
}
await writeFunctionsConfigManifest(distDir, functionsConfigManifest)
if (!isGenerateMode && config.outputFileTracing && !buildTracesPromise) {
buildTracesPromise = collectBuildTraces({
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment