Unverified Commit bd6ceddf authored by Tim Neutkens's avatar Tim Neutkens Committed by GitHub

Remove process.env reading in require hook (#55520)

Found that the require hook has some overhead because of reading process.env. This removes the condition after Jimmy reviewed in #55494 as it seems to be no longer needed. Seems to improve RPS by about ~100.
parent eaa4d02a
...@@ -8,8 +8,6 @@ const mod = require('module') ...@@ -8,8 +8,6 @@ const mod = require('module')
const originalRequire = mod.prototype.require const originalRequire = mod.prototype.require
const resolveFilename = mod._resolveFilename const resolveFilename = mod._resolveFilename
const { PHASE_PRODUCTION_BUILD } = require('../shared/lib/constants')
let resolve: typeof require.resolve = process.env.NEXT_MINIMAL let resolve: typeof require.resolve = process.env.NEXT_MINIMAL
? // @ts-ignore ? // @ts-ignore
__non_webpack_require__.resolve __non_webpack_require__.resolve
...@@ -58,11 +56,7 @@ mod._resolveFilename = function ( ...@@ -58,11 +56,7 @@ mod._resolveFilename = function (
// that needs to point to the rendering runtime version, it will point to the correct one. // that needs to point to the rendering runtime version, it will point to the correct one.
// This can happen on `pages` when a user requires a dependency that uses next/image for example. // This can happen on `pages` when a user requires a dependency that uses next/image for example.
mod.prototype.require = function (request: string) { mod.prototype.require = function (request: string) {
if ( if (request.endsWith('.shared-runtime')) {
(process.env.NEXT_PHASE !== PHASE_PRODUCTION_BUILD ||
process.env.NEXT_IS_EXPORT_WORKER) &&
request.endsWith('.shared-runtime')
) {
return originalRequire.call( return originalRequire.call(
this, this,
`next/dist/server/future/route-modules/pages/vendored/contexts/${path.basename( `next/dist/server/future/route-modules/pages/vendored/contexts/${path.basename(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment