Unverified Commit be3c804b authored by Michael Novotny's avatar Michael Novotny Committed by GitHub

Fixes scripts in Electron examples. (#36133)

There were a few issues with the scripts in the Electron examples:

* `dist` and `pack-app` would fail without a `name` and `version` in `package.json`.
* `type-check` didn't work because there isn't a `tsconfig.json` at the root. It needs to look in the `electron-src` and `renderer` folders respectively.

`electron-builder` also needed to be updated in order to run on macOS 12.3+ (see https://github.com/electron-userland/electron-builder/issues/6606). 

## Documentation / Examples

- [x] Make sure the linting passes by running `yarn lint`
Co-authored-by: 's avatarLee Robinson <9113740+leerob@users.noreply.github.com>
parent 953cd9af
...@@ -10,7 +10,7 @@ ...@@ -10,7 +10,7 @@
"build": "npm run build-renderer && npm run build-electron", "build": "npm run build-renderer && npm run build-electron",
"pack-app": "npm run build && electron-builder --dir", "pack-app": "npm run build && electron-builder --dir",
"dist": "npm run build && electron-builder", "dist": "npm run build && electron-builder",
"type-check": "tsc" "type-check": "tsc -p ./renderer/tsconfig.json && tsc -p ./electron-src/tsconfig.json"
}, },
"dependencies": { "dependencies": {
"electron-is-dev": "^1.1.0", "electron-is-dev": "^1.1.0",
...@@ -23,7 +23,7 @@ ...@@ -23,7 +23,7 @@
"@types/react": "^16.9.9", "@types/react": "^16.9.9",
"@types/react-dom": "^16.9.9", "@types/react-dom": "^16.9.9",
"electron": "^13", "electron": "^13",
"electron-builder": "^22.9.1", "electron-builder": "^23.0.3",
"next": "latest", "next": "latest",
"rimraf": "^3.0.0", "rimraf": "^3.0.0",
"typescript": "^4.0.5" "typescript": "^4.0.5"
......
...@@ -18,7 +18,7 @@ ...@@ -18,7 +18,7 @@
}, },
"devDependencies": { "devDependencies": {
"electron": "^12.0.2", "electron": "^12.0.2",
"electron-builder": "^22.10.5", "electron-builder": "^23.0.3",
"next": "latest", "next": "latest",
"react": "^17.0.2", "react": "^17.0.2",
"react-dom": "^17.0.2" "react-dom": "^17.0.2"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment