Unverified Commit c0dc008f authored by Gerald Monaco's avatar Gerald Monaco Committed by GitHub

Stop exposing internal `render` and `renderError` methods from `next/client` (#34069)

These should no longer need to be exposed.
parent 81b537c0
......@@ -434,7 +434,7 @@ export async function initNext(
render(renderCtx)
}
export async function render(renderingProps: RenderRouteInfo): Promise<void> {
async function render(renderingProps: RenderRouteInfo): Promise<void> {
if (renderingProps.err) {
await renderError(renderingProps)
return
......@@ -462,7 +462,7 @@ export async function render(renderingProps: RenderRouteInfo): Promise<void> {
// This method handles all runtime and debug errors.
// 404 and 500 errors are special kind of errors
// and they are still handle via the main render method.
export function renderError(renderErrorProps: RenderErrorProps): Promise<any> {
function renderError(renderErrorProps: RenderErrorProps): Promise<any> {
const { App, err } = renderErrorProps
// In development runtime errors are caught by our overlay
......
import { initNext, version, router, emitter, render, renderError } from './'
import { initNext, version, router, emitter } from './'
import initOnDemandEntries from './dev/on-demand-entries-client'
import initWebpackHMR from './dev/webpack-hot-middleware-client'
import initializeBuildWatcher from './dev/dev-build-watcher'
......@@ -44,8 +44,6 @@ window.next = {
return router
},
emitter,
render,
renderError,
}
initNext({ webpackHMR, beforeRender: displayContent })
.then(() => {
......
import { initNext, version, router, emitter, render, renderError } from './'
import { initNext, version, router, emitter } from './'
window.next = {
version,
......@@ -7,8 +7,6 @@ window.next = {
return router
},
emitter,
render,
renderError,
}
initNext().catch(console.error)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment